[libvirt] [PATCH] Add support for parsing -vga virtio

Since a94f0c5c qemu supports '-vga virtio'. Libvirt also supports it since 21373feb. This patch enables libvirt to parse the qemu-argv: virsh domxml-from-native qemu-argv <(echo '/usr/bin/qemu-system-x86_64 -vga virtio') Signed-off-by: Nehal J Wani <nehaljw.kkd1@gmail.com> --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4a5fce3..d92bf9d 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -100,7 +100,7 @@ VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, "", /* don't support vbox */ "qxl", "", /* don't support parallels */ - "" /* no need for virtio */); + "virtio"); VIR_ENUM_DECL(qemuDeviceVideo) -- 2.7.4

On Fri, Nov 18, 2016 at 12:27 PM, Nehal J Wani <nehaljw.kkd1@gmail.com> wrote:
Since a94f0c5c qemu supports '-vga virtio'. Libvirt also supports it since 21373feb.
This patch enables libvirt to parse the qemu-argv:
virsh domxml-from-native qemu-argv <(echo '/usr/bin/qemu-system-x86_64 -vga virtio')
Signed-off-by: Nehal J Wani <nehaljw.kkd1@gmail.com> --- src/qemu/qemu_command.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 4a5fce3..d92bf9d 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -100,7 +100,7 @@ VIR_ENUM_IMPL(qemuVideo, VIR_DOMAIN_VIDEO_TYPE_LAST, "", /* don't support vbox */ "qxl", "", /* don't support parallels */ - "" /* no need for virtio */); + "virtio");
VIR_ENUM_DECL(qemuDeviceVideo)
-- 2.7.4
Ping! :-) -- Nehal J Wani

On Fri, Nov 18, 2016 at 12:27:49PM +0530, Nehal J Wani wrote:
Since a94f0c5c qemu supports '-vga virtio'. Libvirt also supports it since 21373feb.
This patch enables libvirt to parse the qemu-argv:
virsh domxml-from-native qemu-argv <(echo '/usr/bin/qemu-system-x86_64 -vga virtio')
NACK, this will never happen. If it's possible we always use -device virtio-vga. The only case when we use -vga is for broken QEMU versions < 1.6.0. The virtio graphics was introduced in QEMU 2.4.0. Pavel
participants (2)
-
Nehal J Wani
-
Pavel Hrdina