[libvirt] [PATCH 0/4] domain_addr: make functions static
which are unused outside domain_addr.c The commit where the last external use was removed is linked in each commit when it exists Anya Harter (4): domain_addr: make virDomainPCIAddressBusIsEmpty static domain_addr: make virDomainCCWAddress funcs static domain_addr: make virDomainVirtioSerialAddr funcs static domain_addr: make virDomainUSBAddressPortFormat static src/conf/domain_addr.c | 197 +++++++++++++++++++-------------------- src/conf/domain_addr.h | 39 -------- src/libvirt_private.syms | 8 -- 3 files changed, 98 insertions(+), 146 deletions(-) -- 2.17.1
never used outside domain_addr.c Signed-off-by: Anya Harter <aharter@redhat.com> --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index eb0784cd2c..ec2dfdbbdc 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -386,7 +386,7 @@ virDomainPCIAddressBusIsFullyReserved(virDomainPCIAddressBusPtr bus) } -bool +static bool ATTRIBUTE_NONNULL(1) virDomainPCIAddressBusIsEmpty(virDomainPCIAddressBusPtr bus) { size_t i; diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h index 776399eb63..fc87c14eba 100644 --- a/src/conf/domain_addr.h +++ b/src/conf/domain_addr.h @@ -146,9 +146,6 @@ int virDomainPCIAddressBusSetModel(virDomainPCIAddressBusPtr bus, bool virDomainPCIAddressBusIsFullyReserved(virDomainPCIAddressBusPtr bus) ATTRIBUTE_NONNULL(1); -bool virDomainPCIAddressBusIsEmpty(virDomainPCIAddressBusPtr bus) - ATTRIBUTE_NONNULL(1); - bool virDomainPCIAddressSlotInUse(virDomainPCIAddressSetPtr addrs, virPCIDeviceAddressPtr addr) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -- 2.17.1
Allocate, Validate, SetCreate last uses of these functions outside domain_addr.c removed in commit: 7bdd06b4e103269992122603949f585fc2bfdc6 Signed-off-by: Anya Harter <aharter@redhat.com> --- src/conf/domain_addr.c | 6 +++--- src/conf/domain_addr.h | 12 ------------ src/libvirt_private.syms | 3 --- 3 files changed, 3 insertions(+), 18 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index ec2dfdbbdc..1922412853 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -1134,7 +1134,7 @@ virDomainCCWAddressAssign(virDomainDeviceInfoPtr dev, return ret; } -int +static int ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) virDomainCCWAddressAllocate(virDomainDefPtr def ATTRIBUTE_UNUSED, virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, virDomainDeviceInfoPtr info, @@ -1143,7 +1143,7 @@ virDomainCCWAddressAllocate(virDomainDefPtr def ATTRIBUTE_UNUSED, return virDomainCCWAddressAssign(info, data, true); } -int +static int ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) virDomainCCWAddressValidate(virDomainDefPtr def ATTRIBUTE_UNUSED, virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, virDomainDeviceInfoPtr info, @@ -1161,7 +1161,7 @@ void virDomainCCWAddressSetFree(virDomainCCWAddressSetPtr addrs) VIR_FREE(addrs); } -virDomainCCWAddressSetPtr +static virDomainCCWAddressSetPtr virDomainCCWAddressSetCreate(void) { virDomainCCWAddressSetPtr addrs = NULL; diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h index fc87c14eba..fc5ddcf6f1 100644 --- a/src/conf/domain_addr.h +++ b/src/conf/domain_addr.h @@ -186,18 +186,6 @@ int virDomainCCWAddressAssign(virDomainDeviceInfoPtr dev, bool autoassign) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); void virDomainCCWAddressSetFree(virDomainCCWAddressSetPtr addrs); -int virDomainCCWAddressAllocate(virDomainDefPtr def, - virDomainDeviceDefPtr dev, - virDomainDeviceInfoPtr info, - void *data) - ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); -int virDomainCCWAddressValidate(virDomainDefPtr def, - virDomainDeviceDefPtr dev, - virDomainDeviceInfoPtr info, - void *data) - ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); - -virDomainCCWAddressSetPtr virDomainCCWAddressSetCreate(void); virDomainCCWAddressSetPtr virDomainCCWAddressSetCreateFromDomain(virDomainDefPtr def) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 7000620b41..fef38d29fa 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -104,12 +104,9 @@ virPCIDeviceAddressParseXML; # conf/domain_addr.h -virDomainCCWAddressAllocate; virDomainCCWAddressAssign; -virDomainCCWAddressSetCreate; virDomainCCWAddressSetCreateFromDomain; virDomainCCWAddressSetFree; -virDomainCCWAddressValidate; virDomainPCIAddressAsString; virDomainPCIAddressBusIsFullyReserved; virDomainPCIAddressBusSetModel; -- 2.17.1
SetCreate, SetAddControllers, Reserve last uses of these functions outside domain_addr.c removed in commit: 40c284f0a6b53a182af7b12173bcb5dd3eb0c826 Assign never used outside domain_addr.c move Assign and Reserve above their first call within domain_addr.c Signed-off-by: Anya Harter <aharter@redhat.com> --- src/conf/domain_addr.c | 187 +++++++++++++++++++-------------------- src/conf/domain_addr.h | 21 ----- src/libvirt_private.syms | 4 - 3 files changed, 93 insertions(+), 119 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 1922412853..33f859697b 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -1216,7 +1216,7 @@ virDomainCCWAddressSetCreateFromDomain(virDomainDefPtr def) * * Allocates an address set for virtio serial addresses */ -virDomainVirtioSerialAddrSetPtr +static virDomainVirtioSerialAddrSetPtr virDomainVirtioSerialAddrSetCreate(void) { virDomainVirtioSerialAddrSetPtr ret = NULL; @@ -1318,7 +1318,7 @@ virDomainVirtioSerialAddrSetAddController(virDomainVirtioSerialAddrSetPtr addrs, * Adds virtio serial ports of controllers present in the domain definition * to the address set. */ -int +static int ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2) virDomainVirtioSerialAddrSetAddControllers(virDomainVirtioSerialAddrSetPtr addrs, virDomainDefPtr def) { @@ -1346,6 +1346,65 @@ virDomainVirtioSerialAddrSetFree(virDomainVirtioSerialAddrSetPtr addrs) } } +/* virDomainVirtioSerialAddrReserve + * + * Reserve the virtio serial address of the device + * + * For use with virDomainDeviceInfoIterate, + * opaque should be the address set + */ +static int ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4) +virDomainVirtioSerialAddrReserve(virDomainDefPtr def ATTRIBUTE_UNUSED, + virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, + virDomainDeviceInfoPtr info, + void *data) +{ + virDomainVirtioSerialAddrSetPtr addrs = data; + char *str = NULL; + int ret = -1; + virBitmapPtr map = NULL; + bool b; + ssize_t i; + + if (!virDomainVirtioSerialAddrIsComplete(info)) + return 0; + + VIR_DEBUG("Reserving virtio serial %u %u", info->addr.vioserial.controller, + info->addr.vioserial.port); + + i = virDomainVirtioSerialAddrFindController(addrs, info->addr.vioserial.controller); + if (i < 0) { + virReportError(VIR_ERR_XML_ERROR, + _("virtio serial controller %u is missing"), + info->addr.vioserial.controller); + goto cleanup; + } + + map = addrs->controllers[i]->ports; + if (virBitmapGetBit(map, info->addr.vioserial.port, &b) < 0) { + virReportError(VIR_ERR_XML_ERROR, + _("virtio serial controller %u does not have port %u"), + info->addr.vioserial.controller, + info->addr.vioserial.port); + goto cleanup; + } + + if (b) { + virReportError(VIR_ERR_XML_ERROR, + _("virtio serial port %u on controller %u is already occupied"), + info->addr.vioserial.port, + info->addr.vioserial.controller); + goto cleanup; + } + + ignore_value(virBitmapSetBit(map, info->addr.vioserial.port)); + + ret = 0; + + cleanup: + VIR_FREE(str); + return ret; +} /* virDomainVirtioSerialAddrSetCreateFromDomain * @@ -1487,6 +1546,38 @@ virDomainVirtioSerialAddrNextFromController(virDomainVirtioSerialAddrSetPtr addr return 0; } +static int ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3) +virDomainVirtioSerialAddrAssign(virDomainDefPtr def, + virDomainVirtioSerialAddrSetPtr addrs, + virDomainDeviceInfoPtr info, + bool allowZero, + bool portOnly) +{ + int ret = -1; + virDomainDeviceInfo nfo = { 0 }; + virDomainDeviceInfoPtr ptr = allowZero ? &nfo : info; + + ptr->type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL; + + if (portOnly) { + if (virDomainVirtioSerialAddrNextFromController(addrs, + &ptr->addr.vioserial) < 0) + goto cleanup; + } else { + if (virDomainVirtioSerialAddrNext(def, addrs, &ptr->addr.vioserial, + allowZero) < 0) + goto cleanup; + } + + if (virDomainVirtioSerialAddrReserve(NULL, NULL, ptr, addrs) < 0) + goto cleanup; + + ret = 0; + + cleanup: + return ret; +} + /* virDomainVirtioSerialAddrAutoAssign * * reserve a virtio serial address of the device (if it has one) @@ -1528,38 +1619,6 @@ virDomainVirtioSerialAddrAutoAssign(virDomainDefPtr def, } -int -virDomainVirtioSerialAddrAssign(virDomainDefPtr def, - virDomainVirtioSerialAddrSetPtr addrs, - virDomainDeviceInfoPtr info, - bool allowZero, - bool portOnly) -{ - int ret = -1; - virDomainDeviceInfo nfo = { 0 }; - virDomainDeviceInfoPtr ptr = allowZero ? &nfo : info; - - ptr->type = VIR_DOMAIN_DEVICE_ADDRESS_TYPE_VIRTIO_SERIAL; - - if (portOnly) { - if (virDomainVirtioSerialAddrNextFromController(addrs, - &ptr->addr.vioserial) < 0) - goto cleanup; - } else { - if (virDomainVirtioSerialAddrNext(def, addrs, &ptr->addr.vioserial, - allowZero) < 0) - goto cleanup; - } - - if (virDomainVirtioSerialAddrReserve(NULL, NULL, ptr, addrs) < 0) - goto cleanup; - - ret = 0; - - cleanup: - return ret; -} - /* virDomainVirtioSerialAddrIsComplete * * Check if the address is complete, or it needs auto-assignment @@ -1571,66 +1630,6 @@ virDomainVirtioSerialAddrIsComplete(virDomainDeviceInfoPtr info) info->addr.vioserial.port != 0; } -/* virDomainVirtioSerialAddrReserve - * - * Reserve the virtio serial address of the device - * - * For use with virDomainDeviceInfoIterate, - * opaque should be the address set - */ -int -virDomainVirtioSerialAddrReserve(virDomainDefPtr def ATTRIBUTE_UNUSED, - virDomainDeviceDefPtr dev ATTRIBUTE_UNUSED, - virDomainDeviceInfoPtr info, - void *data) -{ - virDomainVirtioSerialAddrSetPtr addrs = data; - char *str = NULL; - int ret = -1; - virBitmapPtr map = NULL; - bool b; - ssize_t i; - - if (!virDomainVirtioSerialAddrIsComplete(info)) - return 0; - - VIR_DEBUG("Reserving virtio serial %u %u", info->addr.vioserial.controller, - info->addr.vioserial.port); - - i = virDomainVirtioSerialAddrFindController(addrs, info->addr.vioserial.controller); - if (i < 0) { - virReportError(VIR_ERR_XML_ERROR, - _("virtio serial controller %u is missing"), - info->addr.vioserial.controller); - goto cleanup; - } - - map = addrs->controllers[i]->ports; - if (virBitmapGetBit(map, info->addr.vioserial.port, &b) < 0) { - virReportError(VIR_ERR_XML_ERROR, - _("virtio serial controller %u does not have port %u"), - info->addr.vioserial.controller, - info->addr.vioserial.port); - goto cleanup; - } - - if (b) { - virReportError(VIR_ERR_XML_ERROR, - _("virtio serial port %u on controller %u is already occupied"), - info->addr.vioserial.port, - info->addr.vioserial.controller); - goto cleanup; - } - - ignore_value(virBitmapSetBit(map, info->addr.vioserial.port)); - - ret = 0; - - cleanup: - VIR_FREE(str); - return ret; -} - bool virDomainUSBAddressPortIsValid(unsigned int *port) diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h index fc5ddcf6f1..a94d4bda66 100644 --- a/src/conf/domain_addr.h +++ b/src/conf/domain_addr.h @@ -206,12 +206,6 @@ struct _virDomainVirtioSerialAddrSet { typedef struct _virDomainVirtioSerialAddrSet virDomainVirtioSerialAddrSet; typedef virDomainVirtioSerialAddrSet *virDomainVirtioSerialAddrSetPtr; -virDomainVirtioSerialAddrSetPtr -virDomainVirtioSerialAddrSetCreate(void); -int -virDomainVirtioSerialAddrSetAddControllers(virDomainVirtioSerialAddrSetPtr addrs, - virDomainDefPtr def) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); void virDomainVirtioSerialAddrSetFree(virDomainVirtioSerialAddrSetPtr addrs); virDomainVirtioSerialAddrSetPtr @@ -232,21 +226,6 @@ virDomainVirtioSerialAddrAutoAssign(virDomainDefPtr def, bool allowZero) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -int -virDomainVirtioSerialAddrAssign(virDomainDefPtr def, - virDomainVirtioSerialAddrSetPtr addrs, - virDomainDeviceInfoPtr info, - bool allowZero, - bool portOnly) - ATTRIBUTE_NONNULL(2) ATTRIBUTE_NONNULL(3); - -int -virDomainVirtioSerialAddrReserve(virDomainDefPtr def, - virDomainDeviceDefPtr dev, - virDomainDeviceInfoPtr info, - void *data) - ATTRIBUTE_NONNULL(3) ATTRIBUTE_NONNULL(4); - bool virDomainUSBAddressPortIsValid(unsigned int *port) ATTRIBUTE_NONNULL(1); diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index fef38d29fa..0f82f3c38a 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -133,13 +133,9 @@ virDomainUSBAddressSetAddControllers; virDomainUSBAddressSetAddHub; virDomainUSBAddressSetCreate; virDomainUSBAddressSetFree; -virDomainVirtioSerialAddrAssign; virDomainVirtioSerialAddrAutoAssign; virDomainVirtioSerialAddrAutoAssignFromCache; virDomainVirtioSerialAddrIsComplete; -virDomainVirtioSerialAddrReserve; -virDomainVirtioSerialAddrSetAddControllers; -virDomainVirtioSerialAddrSetCreate; virDomainVirtioSerialAddrSetCreateFromDomain; virDomainVirtioSerialAddrSetFree; -- 2.17.1
never used outside domain_addr.c Signed-off-by: Anya Harter <aharter@redhat.com> --- src/conf/domain_addr.c | 2 +- src/conf/domain_addr.h | 3 --- src/libvirt_private.syms | 1 - 3 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index 33f859697b..16f7ffa928 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -1653,7 +1653,7 @@ virDomainUSBAddressPortFormatBuf(virBufferPtr buf, } -char * +static char * ATTRIBUTE_NONNULL(1) virDomainUSBAddressPortFormat(unsigned int *port) { virBuffer buf = VIR_BUFFER_INITIALIZER; diff --git a/src/conf/domain_addr.h b/src/conf/domain_addr.h index a94d4bda66..5ad9d8ef3d 100644 --- a/src/conf/domain_addr.h +++ b/src/conf/domain_addr.h @@ -234,9 +234,6 @@ void virDomainUSBAddressPortFormatBuf(virBufferPtr buf, unsigned int *port) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); -char * -virDomainUSBAddressPortFormat(unsigned int *port) - ATTRIBUTE_NONNULL(1); # define VIR_DOMAIN_USB_HUB_PORTS 8 diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 0f82f3c38a..3e304907b9 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -123,7 +123,6 @@ virDomainPCIControllerModelToConnectType; virDomainUSBAddressAssign; virDomainUSBAddressCountAllPorts; virDomainUSBAddressEnsure; -virDomainUSBAddressPortFormat; virDomainUSBAddressPortFormatBuf; virDomainUSBAddressPortIsValid; virDomainUSBAddressPresent; -- 2.17.1
On Tue, Jul 03, 2018 at 04:19:47PM -0400, Anya Harter wrote:
which are unused outside domain_addr.c
The commit where the last external use was removed is linked in each commit when it exists
Anya Harter (4): domain_addr: make virDomainPCIAddressBusIsEmpty static domain_addr: make virDomainCCWAddress funcs static domain_addr: make virDomainVirtioSerialAddr funcs static domain_addr: make virDomainUSBAddressPortFormat static
The patch 3 could be split into two commits, one that move the code and second that manes function static. Reviewed-by: Pavel Hrdina <phrdina@redhat.com> and pushed.
participants (2)
-
Anya Harter -
Pavel Hrdina