[libvirt] [PATCH] qemu: remove memset params array to zero in qemuDomainGetPercpuStats
the array params is allocated by VIR_ALLOC_N in cmdCPUStats. it had been set to zero. No need to reset it to zero again, and this reset here is incorrect too, nparams * ncpus is the array length not the size of params array. Signed-off-by: Gao feng <gaofeng@cn.fujitsu.com> --- src/qemu/qemu_driver.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 9f71160..7a329f0 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -15820,7 +15820,6 @@ qemuDomainGetPercpuStats(virDomainObjPtr vm, if (virCgroupGetCpuacctPercpuUsage(priv->cgroup, &buf)) goto cleanup; pos = buf; - memset(params, 0, nparams * ncpus); /* return percpu cputime in index 0 */ param_idx = 0; -- 1.8.4.2
On Wed, Jan 15, 2014 at 04:47:21PM +0800, Gao feng wrote:
the array params is allocated by VIR_ALLOC_N in cmdCPUStats. it had been set to zero. No need to reset it to zero again, and this reset here is incorrect too, nparams * ncpus is the array length not the size of params array.
'cmdCPUStats' is virsh client code. The QEMU driver is running server side in libvirtd. So whatever memory was allocated in cmdCPUStats isn't the same as the memory used in qemu_driver.c Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 01/15/2014 06:50 PM, Daniel P. Berrange wrote:
On Wed, Jan 15, 2014 at 04:47:21PM +0800, Gao feng wrote:
the array params is allocated by VIR_ALLOC_N in cmdCPUStats. it had been set to zero. No need to reset it to zero again, and this reset here is incorrect too, nparams * ncpus is the array length not the size of params array.
'cmdCPUStats' is virsh client code. The QEMU driver is running server side in libvirtd. So whatever memory was allocated in cmdCPUStats isn't the same as the memory used in qemu_driver.c
ohh.. this memory is allocated by VIR_ALLOC_N in remoteDispatchDomainGetCPUStats.. I will change the changelog and resend this patch. Thanks!
participants (2)
-
Daniel P. Berrange -
Gao feng