[libvirt] [PATCH]: Add MIGRATE_LIVE definition to ruby-libvirt bindings
Attached is a trivial patch to add the MIGRATE_LIVE flag into the ruby-libvirt bindings. Signed-off-by: Chris Lalancette <clalance@redhat.com>
On Mon, 2008-07-07 at 17:28 +0200, Chris Lalancette wrote:
Attached is a trivial patch to add the MIGRATE_LIVE flag into the ruby-libvirt bindings.
Signed-off-by: Chris Lalancette <clalance@redhat.com>
ACK .. Committed. (1) Do you need a new ruby-libvirt release for this ? (2) How far back has 'enum virDomainMigrateFlags' been around ? IOW, do I need to worry about compilation breaking on old libvirt releases ? David
David Lutterkort wrote:
ACK .. Committed.
(1) Do you need a new ruby-libvirt release for this ?
No, it's fine for now; I'm just hard-coding the "1" in oVirt for now. At some future point when you do a new release, though, I'll convert over to this flag.
(2) How far back has 'enum virDomainMigrateFlags' been around ? IOW, do I need to worry about compilation breaking on old libvirt releases ?
Good question. /me goes to look...according to "cvs annotate", that flag was added to include/libvirt/libvirt.h changeset 1.52 on 21-Aug-07. From the Changelog, it looks like that means it was included in libvirt 0.3.2 onwards. How far back are you looking to make the bindings compatible? Chris Lalancette
participants (2)
-
Chris Lalancette -
David Lutterkort