[libvirt] [PATCH] remote: Don't print a warning every time a remote call fails
$ sudo virsh pool-start idontexist 10:58:18.716: warning : processCallDispatchReply:7612 : Method call error error: failed to get pool 'idontexist' error: Storage pool not found: no pool with matching name 'idontexist' That warning doesn't server much purpose being printed via a virsh call. Change the warning to a debug message. Signed-off-by: Cole Robinson <crobinso@redhat.com> --- src/remote/remote_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/remote/remote_driver.c b/src/remote/remote_driver.c index 284593a..162d682 100644 --- a/src/remote/remote_driver.c +++ b/src/remote/remote_driver.c @@ -7606,7 +7606,7 @@ processCallDispatchReply(virConnectPtr conn, struct private_data *priv, return 0; case REMOTE_ERROR: - VIR_WARN0("Method call error"); + VIR_DEBUG0("Method call error"); memset (&thecall->err, 0, sizeof thecall->err); if (!xdr_remote_error (xdr, &thecall->err)) { error (in_open ? NULL : conn, -- 1.6.5.rc2
On Mon, Oct 12, 2009 at 10:32:11AM -0400, Cole Robinson wrote:
$ sudo virsh pool-start idontexist 10:58:18.716: warning : processCallDispatchReply:7612 : Method call error error: failed to get pool 'idontexist' error: Storage pool not found: no pool with matching name 'idontexist'
That warning doesn't server much purpose being printed via a virsh call. Change the warning to a debug message.
This was random debugging I didn't mean to leave in - we should remove it entirely since we already log all errors in libvirt elsewhere Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On 10/13/2009 09:19 AM, Daniel P. Berrange wrote:
On Mon, Oct 12, 2009 at 10:32:11AM -0400, Cole Robinson wrote:
$ sudo virsh pool-start idontexist 10:58:18.716: warning : processCallDispatchReply:7612 : Method call error error: failed to get pool 'idontexist' error: Storage pool not found: no pool with matching name 'idontexist'
That warning doesn't server much purpose being printed via a virsh call. Change the warning to a debug message.
This was random debugging I didn't mean to leave in - we should remove it entirely since we already log all errors in libvirt elsewhere
Daniel
Okay, I pushed a fix that just drops the VIR_WARN line. Thanks, Cole
participants (2)
-
Cole Robinson -
Daniel P. Berrange