[PATCH 1/2] gobject: Fix typo in documentation of gvir_domain_save_to_file_async
Signed-off-by: Felipe Borges <feborges@redhat.com> --- libvirt-gobject/libvirt-gobject-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index 399b118..0a16cb4 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -777,7 +777,7 @@ gvir_domain_save_to_file_helper(GTask *task, * @filename: path to output file * @custom_conf: (allow-none): configuration for domain or NULL * @flags: the flags - * @cancellable: (allow-none) (transfer none): cancallation object + * @cancellable: (allow-none) (transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback * -- 2.24.1
These are mapped respectively to VIR_DOMAIN_UNDEFINE_NVRAM and VIR_DOMAIN_UNDEFINE_KEEP_NVRAM. Fixes issues such as https://bugzilla.redhat.com/1817031 Signed-off-by: Felipe Borges <feborges@redhat.com> --- libvirt-gobject/libvirt-gobject-domain.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-domain.h b/libvirt-gobject/libvirt-gobject-domain.h index 099cde3..8e55d17 100644 --- a/libvirt-gobject/libvirt-gobject-domain.h +++ b/libvirt-gobject/libvirt-gobject-domain.h @@ -104,6 +104,8 @@ typedef enum { GVIR_DOMAIN_DELETE_NONE = 0, GVIR_DOMAIN_DELETE_SAVED_STATE = VIR_DOMAIN_UNDEFINE_MANAGED_SAVE, GVIR_DOMAIN_DELETE_SNAPSHOTS_METADATA = VIR_DOMAIN_UNDEFINE_SNAPSHOTS_METADATA, + GVIR_DOMAIN_DELETE_REMOVE_NVRAM = VIR_DOMAIN_UNDEFINE_NVRAM, + GVIR_DOMAIN_DELETE_KEEP_NVRAM = VIR_DOMAIN_UNDEFINE_KEEP_NVRAM, } GVirDomainDeleteFlags; /** -- 2.24.1
On Wed, Mar 25, 2020 at 4:51 PM Felipe Borges <felipeborges@gnome.org> wrote:
Signed-off-by: Felipe Borges <feborges@redhat.com> --- libvirt-gobject/libvirt-gobject-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index 399b118..0a16cb4 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -777,7 +777,7 @@ gvir_domain_save_to_file_helper(GTask *task, * @filename: path to output file * @custom_conf: (allow-none): configuration for domain or NULL * @flags: the flags - * @cancellable: (allow-none) (transfer none): cancallation object + * @cancellable: (allow-none) (transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback * -- 2.24.1
For both patches ... Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com> ... and pushed. Do you need a release including 2nd patch in order to unblock something for Boxes on Fedora 32? Best Regards, -- Fabiano Fidêncio
On Wed, Mar 25, 2020 at 5:08 PM Fabiano Fidêncio <fidencio@redhat.com> wrote:
On Wed, Mar 25, 2020 at 4:51 PM Felipe Borges <felipeborges@gnome.org> wrote:
Signed-off-by: Felipe Borges <feborges@redhat.com> --- libvirt-gobject/libvirt-gobject-domain.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/libvirt-gobject-domain.c index 399b118..0a16cb4 100644 --- a/libvirt-gobject/libvirt-gobject-domain.c +++ b/libvirt-gobject/libvirt-gobject-domain.c @@ -777,7 +777,7 @@ gvir_domain_save_to_file_helper(GTask *task, * @filename: path to output file * @custom_conf: (allow-none): configuration for domain or NULL * @flags: the flags - * @cancellable: (allow-none) (transfer none): cancallation object + * @cancellable: (allow-none) (transfer none): cancellation object * @callback: (scope async): completion callback * @user_data: (closure): opaque data for callback * -- 2.24.1
For both patches ... Reviewed-by: Fabiano Fidêncio <fidencio@redhat.com> ... and pushed.
Hi, thanks for the quick review!
Do you need a release including 2nd patch in order to unblock something for Boxes on Fedora 32?
No need. I patched Boxes directly by hardcoding the flag value. https://src.fedoraproject.org/rpms/gnome-boxes/blob/f32/f/0001-libvirt-machi... It would be nice to have a release before Fedora 33, but for that we have plenty of time, so no worries. Cheers! Felipe Borges.
Best Regards, -- Fabiano Fidêncio
participants (3)
-
Fabiano Fidêncio -
Felipe Borges -
Felipe Borges