What we are using really is heap allocated structure rather than stack allocated. And for that it's better to use g_autoptr() + G_DEFINE_AUTOPTR_CLEANUP_FUNC() combo, as Glib documentation for g_auto() reads: This is meant to be used with stack-allocated structures and non-pointer types. For the (more commonly used) pointer version, see g_autoptr(). This will be even more visible, when virSysinfoDefPtr type is gone. Stay tuned. Fixes: cee3a900a0d6a8fc79554db22dc262632fe487a6 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/util/virsysinfo.c | 8 ++++---- src/util/virsysinfo.h | 2 +- tests/sysinfotest.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/util/virsysinfo.c b/src/util/virsysinfo.c index 0016028254..1c8193cc58 100644 --- a/src/util/virsysinfo.c +++ b/src/util/virsysinfo.c @@ -314,7 +314,7 @@ virSysinfoParsePPCProcessor(const char *base, virSysinfoDefPtr ret) virSysinfoDefPtr virSysinfoReadPPC(void) { - g_auto(virSysinfoDefPtr) ret = NULL; + g_autoptr(virSysinfoDef) ret = NULL; g_autofree char *outbuf = NULL; ret = g_new0(virSysinfoDef, 1); @@ -436,7 +436,7 @@ virSysinfoParseARMProcessor(const char *base, virSysinfoDefPtr ret) virSysinfoDefPtr virSysinfoReadARM(void) { - g_auto(virSysinfoDefPtr) ret = NULL; + g_autoptr(virSysinfoDef) ret = NULL; g_autofree char *outbuf = NULL; /* Some ARM systems have DMI tables available. */ @@ -602,7 +602,7 @@ virSysinfoParseS390Processor(const char *base, virSysinfoDefPtr ret) virSysinfoDefPtr virSysinfoReadS390(void) { - g_auto(virSysinfoDefPtr) ret = NULL; + g_autoptr(virSysinfoDef) ret = NULL; g_autofree char *outbuf = NULL; ret = g_new0(virSysinfoDef, 1); @@ -1212,7 +1212,7 @@ virSysinfoParseX86Memory(const char *base, virSysinfoDefPtr ret) virSysinfoDefPtr virSysinfoReadDMI(void) { - g_auto(virSysinfoDefPtr) ret = NULL; + g_autoptr(virSysinfoDef) ret = NULL; g_autofree char *outbuf = NULL; g_autoptr(virCommand) cmd = NULL; diff --git a/src/util/virsysinfo.h b/src/util/virsysinfo.h index 6b25969a4b..6ae4ba7bf3 100644 --- a/src/util/virsysinfo.h +++ b/src/util/virsysinfo.h @@ -157,7 +157,7 @@ void virSysinfoChassisDefFree(virSysinfoChassisDefPtr def); void virSysinfoOEMStringsDefFree(virSysinfoOEMStringsDefPtr def); void virSysinfoDefFree(virSysinfoDefPtr def); -G_DEFINE_AUTO_CLEANUP_FREE_FUNC(virSysinfoDefPtr, virSysinfoDefFree, NULL); +G_DEFINE_AUTOPTR_CLEANUP_FUNC(virSysinfoDef, virSysinfoDefFree); int virSysinfoFormat(virBufferPtr buf, virSysinfoDefPtr def) ATTRIBUTE_NONNULL(1) ATTRIBUTE_NONNULL(2); diff --git a/tests/sysinfotest.c b/tests/sysinfotest.c index 3b418955d0..e40a4564a7 100644 --- a/tests/sysinfotest.c +++ b/tests/sysinfotest.c @@ -91,7 +91,7 @@ testSysinfo(const void *data) { const struct testSysinfoData *testdata = data; const char *sysfsActualData; - g_auto(virSysinfoDefPtr) ret = NULL; + g_autoptr(virSysinfoDef) ret = NULL; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; g_autofree char *sysinfo = NULL; g_autofree char *cpuinfo = NULL; -- 2.26.2

The use of virXXXPtr is going away soon, therefore use 'virXXX *' instead. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/rpc/gendispatch.pl | 66 +++++++++++++++++++++--------------------- 1 file changed, 33 insertions(+), 33 deletions(-) diff --git a/src/rpc/gendispatch.pl b/src/rpc/gendispatch.pl index 0020273d9e..9dcd8c3e89 100755 --- a/src/rpc/gendispatch.pl +++ b/src/rpc/gendispatch.pl @@ -113,7 +113,7 @@ sub name_to_TypeName { sub get_conn_type { if ($structprefix eq "admin") { - return "virNetDaemonPtr"; + return "virNetDaemon *"; } else { return "virConnectPtr"; } @@ -499,10 +499,10 @@ elsif ($mode eq "server") { # First we print out a function declaration for the # real dispatcher body print "static int ${name}(\n"; - print " virNetServerPtr server,\n"; - print " virNetServerClientPtr client,\n"; - print " virNetMessagePtr msg,\n"; - print " virNetMessageErrorPtr rerr"; + print " virNetServer *server,\n"; + print " virNetServerClient *client,\n"; + print " virNetMessage *msg,\n"; + print " struct virNetMessageError *rerr"; if ($argtype ne "void") { print ",\n $argtype *args"; } @@ -516,10 +516,10 @@ elsif ($mode eq "server") { # fixed function signature, for use in the dispatcher # table. This simply callers the real dispatcher method print "static int ${name}Helper(\n"; - print " virNetServerPtr server,\n"; - print " virNetServerClientPtr client,\n"; - print " virNetMessagePtr msg,\n"; - print " virNetMessageErrorPtr rerr,\n"; + print " virNetServer *server,\n"; + print " virNetServerClient *client,\n"; + print " virNetMessage *msg,\n"; + print " struct virNetMessageError *rerr,\n"; print " void *args$argann,\n"; print " void *ret$retann)\n"; print "{\n"; @@ -641,7 +641,7 @@ elsif ($mode eq "server") { } push(@args_list, "$1"); push(@args_list, "n$1"); - push(@getters_list, " if (virTypedParamsDeserialize((virTypedParameterRemotePtr) args->$1.$1_val,\n" . + push(@getters_list, " if (virTypedParamsDeserialize((struct _virTypedParameterRemote *) args->$1.$1_val,\n" . " args->$1.$1_len,\n" . " $2,\n" . " &$1,\n" . @@ -687,7 +687,7 @@ elsif ($mode eq "server") { } elsif ($args_member =~ m/^admin_nonnull_(server) (\S+);/) { my $type_name = name_to_TypeName($1); - push(@vars_list, "virNet${type_name}Ptr $2 = NULL"); + push(@vars_list, "virNet${type_name} *$2 = NULL"); push(@getters_list, " if (!($2 = get_nonnull_$1($conn_var, args->$2)))\n" . " goto cleanup;\n"); @@ -697,8 +697,8 @@ elsif ($mode eq "server") { } elsif ($args_member =~ m/^admin_nonnull_(client) (\S+);/) { my $type_name = name_to_TypeName($1); - push(@vars_list, "virNetServerPtr srv = NULL"); - push(@vars_list, "virNetServer${type_name}Ptr $2 = NULL"); + push(@vars_list, "virNetServer *srv = NULL"); + push(@vars_list, "virNetServer${type_name} *$2 = NULL"); push(@getters_list, " if (!(srv = get_nonnull_server($conn_var, args->$2.srv)))\n" . " goto cleanup;\n"); @@ -930,11 +930,11 @@ elsif ($mode eq "server") { my $type_name = name_to_TypeName($1); if ($1 eq "client") { - push(@vars_list, "virNetServer${type_name}Ptr $2 = NULL"); + push(@vars_list, "virNetServer${type_name} *$2 = NULL"); push(@ret_list, "make_nonnull_$1(&ret->$2, $2);\n"); push(@ret_list, "make_nonnull_server(&ret->$2.srv, srv);\n"); } else { - push(@vars_list, "virNet${type_name}Ptr $2 = NULL"); + push(@vars_list, "virNet${type_name} *$2 = NULL"); push(@ret_list, "make_nonnull_$1(&ret->$2, $2);"); } @@ -955,13 +955,13 @@ elsif ($mode eq "server") { push(@ret_list, "if (virTypedParamsSerialize($1, $1_len,\n" . " $2,\n" . - " (virTypedParameterRemotePtr *) &ret->$1.$1_val,\n" . + " (struct _virTypedParameterRemote **) &ret->$1.$1_val,\n" . " &ret->$1.$1_len,\n" . " VIR_TYPED_PARAM_STRING_OKAY) < 0)\n" . " goto cleanup;\n"); push(@free_list, " virTypedParamsFree($1, $1_len);"); - push(@free_list_on_error, "virTypedParamsRemoteFree((virTypedParameterRemotePtr) ret->params.params_val,\n" . + push(@free_list_on_error, "virTypedParamsRemoteFree((struct _virTypedParameterRemote *) ret->params.params_val,\n" . " ret->params.params_len);\n"); } elsif ($ret_member =~ m/^(\/)?\*/) { # ignore comments @@ -989,7 +989,7 @@ elsif ($mode eq "server") { } } - push(@vars_list, "vir${struct_name}Ptr *result = NULL"); + push(@vars_list, "vir${struct_name} **result = NULL"); push(@vars_list, "int nresults = 0"); @args_list = grep {!/\bneed_results\b/} @args_list; @@ -1031,10 +1031,10 @@ elsif ($mode eq "server") { # print functions signature print "static int $name(\n"; - print " virNetServerPtr server G_GNUC_UNUSED,\n"; - print " virNetServerClientPtr client,\n"; - print " virNetMessagePtr msg G_GNUC_UNUSED,\n"; - print " virNetMessageErrorPtr rerr"; + print " virNetServer *server G_GNUC_UNUSED,\n"; + print " virNetServerClient *client,\n"; + print " virNetMessage *msg G_GNUC_UNUSED,\n"; + print " struct virNetMessageError *rerr"; if ($argtype ne "void") { print ",\n $argtype *args"; } @@ -1057,7 +1057,7 @@ elsif ($mode eq "server") { if ($call->{streamflag} ne "none") { print " virStreamPtr st = NULL;\n"; - print " daemonClientStreamPtr stream = NULL;\n"; + print " daemonClientStream *stream = NULL;\n"; if ($call->{sparseflag} ne "none") { print " const bool sparse = args->flags & $call->{sparseflag};\n" } else { @@ -1439,13 +1439,13 @@ elsif ($mode eq "client") { push(@args_list, "int n$1"); push(@setters_list2, "if (virTypedParamsSerialize($1, n$1,\n" . " $2,\n" . - " (virTypedParameterRemotePtr *) &args.$1.$1_val,\n" . + " (struct _virTypedParameterRemote **) &args.$1.$1_val,\n" . " &args.$1.$1_len,\n" . " VIR_TYPED_PARAM_STRING_OKAY) < 0) {\n" . " xdr_free((xdrproc_t)xdr_$call->{args}, (char *)&args);\n" . " goto done;\n" . " }"); - push(@free_list, " virTypedParamsRemoteFree((virTypedParameterRemotePtr) args.params.params_val,\n" . + push(@free_list, " virTypedParamsRemoteFree((struct _virTypedParameterRemote *) args.params.params_val,\n" . " args.params.params_len);\n"); } elsif ($args_member =~ m/^((?:unsigned )?int) (\S+);\s*\/\*\s*call-by-reference\s*\*\//) { my $type_name = "$1 *"; @@ -1626,7 +1626,7 @@ elsif ($mode eq "client") { push(@vars_list, "virTypedParameterPtr ret_params = NULL"); push(@vars_list, "int ret_nparams = 0"); # virTypedParamsDeserialize allocates the array if @params is null - push(@ret_list2, "if (virTypedParamsDeserialize((virTypedParameterRemotePtr) ret.$1.$1_val,\n" . + push(@ret_list2, "if (virTypedParamsDeserialize((struct _virTypedParameterRemote *) ret.$1.$1_val,\n" . " ret.$1.$1_len,\n" . " $2,\n" . " &ret_params,\n" . @@ -1638,7 +1638,7 @@ elsif ($mode eq "client") { $single_ret_cleanup = 1; } elsif ($ret_member =~ m/^remote_typed_param (\S+)<(\S+)>;\s*\/\*\s*insert@(\d+)\s*\*\//) { splice(@args_list, int($3), 0, ("virTypedParameterPtr $1")); - push(@ret_list2, "if (virTypedParamsDeserialize((virTypedParameterRemotePtr) ret.$1.$1_val,\n" . + push(@ret_list2, "if (virTypedParamsDeserialize((struct _virTypedParameterRemote *) ret.$1.$1_val,\n" . " ret.$1.$1_len,\n" . " $2,\n" . " &$1,\n" . @@ -1791,7 +1791,7 @@ elsif ($mode eq "client") { print "{\n"; print " $single_ret_var;\n"; if ($structprefix eq "admin") { - print " remoteAdminPrivPtr priv = $priv_src->privateData;\n"; + print " remoteAdminPriv *priv = $priv_src->privateData;\n"; } else { print " struct private_data *priv = $priv_src->privateData;\n"; } @@ -1806,7 +1806,7 @@ elsif ($mode eq "client") { } if ($call->{streamflag} ne "none") { - print " virNetClientStreamPtr netst = NULL;\n"; + print " virNetClientStream *netst = NULL;\n"; if ($call->{sparseflag} ne "none") { print " const bool sparse = flags & $call->{sparseflag};\n" } else { @@ -2140,7 +2140,7 @@ elsif ($mode eq "client") { $object =~ s/^(\w)/uc $1/e; $object =~ s/_(\w)/uc $1/e; $object =~ s/Nwfilter/NWFilter/; - my $objecttype = $prefix . $object . "DefPtr"; + my $objecttype = $prefix . $object . "Def *"; $apiname .= $action . "ACL"; if ($arg eq "interface") { @@ -2151,9 +2151,9 @@ elsif ($mode eq "client") { push @argdecls, "$connect_ptr conn"; if ($object ne "Connect") { if ($object eq "StorageVol") { - push @argdecls, "virStoragePoolDefPtr pool"; + push @argdecls, "virStoragePoolDef *pool"; } elsif ($object eq "NetworkPort") { - push @argdecls, "virNetworkDefPtr net"; + push @argdecls, "virNetworkDef *net"; } push @argdecls, "$objecttype $arg"; } @@ -2195,7 +2195,7 @@ elsif ($mode eq "client") { print "/* Returns: $fail on error/denied, $pass on allowed */\n"; print "$ret $apiname(" . join(", ", @argdecls) . ")\n"; print "{\n"; - print " virAccessManagerPtr mgr;\n"; + print " virAccessManager *mgr;\n"; print " int rv;\n"; print "\n"; print " if (!(mgr = virAccessManagerGetDefault())) {\n"; -- 2.26.2

The aim of virSecurity rule is to discourage from using plain virSecurityManager*() APIs within QEMU driver in favor of their qemuSecurity*() counterparts. The reason is simple: namespaces; virSecurityManager*() needs additional virSecurityManagerTransactionCommit() call to enter given namespace and do its work from there. And that's exactly what those qemuSecurity*() wrappers do. To help us ensure correctness (from this POV), we have a syntax-check rule that forbids any occurrence of "virSecurityManager" string under src/qemu/ (except for qemu_security of course). But with if we want to remove virSecurityManagerPtr type, then we have to allow "virSecurityManager *". Therefore, change the rule so that no call of a function with "virSecurityManager" prefix is allowed. And also change the name to better reflect what is going on. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- build-aux/syntax-check.mk | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 2f4f932a5b..c71b608e66 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -1049,10 +1049,10 @@ sc_prohibit_sysconf_pagesize: halt='use virGetSystemPageSize[KB] instead of sysconf(_SC_PAGESIZE)' \ $(_sc_search_regexp) -sc_prohibit_virSecurity: +sc_prohibit_virSecurityManager: @$(VC_LIST_EXCEPT) | $(GREP) 'src/qemu/' | \ $(GREP) -v 'src/qemu/qemu_security' | \ - xargs $(GREP) -Pn 'virSecurityManager(?!Ptr)' /dev/null && \ + xargs $(GREP) -Pn 'virSecurityManager\S*\(' /dev/null && \ { echo '$(ME): prefer qemuSecurity wrappers' 1>&2; exit 1; } || : sc_prohibit_pthread_create: -- 2.26.2

The name is supposed to be virCapsGuestArchPtr not ..ptr. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/conf/virconftypes.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/virconftypes.h b/src/conf/virconftypes.h index c51241cfa5..4658d0de9c 100644 --- a/src/conf/virconftypes.h +++ b/src/conf/virconftypes.h @@ -37,7 +37,7 @@ typedef struct _virCapsGuest virCapsGuest; typedef virCapsGuest *virCapsGuestPtr; typedef struct _virCapsGuestArch virCapsGuestArch; -typedef virCapsGuestArch *virCapsGuestArchptr; +typedef virCapsGuestArch *virCapsGuestArchPtr; typedef struct _virCapsGuestDomain virCapsGuestDomain; typedef virCapsGuestDomain *virCapsGuestDomainPtr; -- 2.26.2

In short, virXXXPtr type is going away. With bing bang. And to help us rewrite the code with a sed script, it's better if each variable is declared on its own line. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/bhyve/bhyve_command.c | 5 ++++- src/bhyve/bhyve_driver.c | 3 ++- src/conf/domain_addr.c | 3 ++- src/conf/domain_conf.c | 3 ++- src/conf/numa_conf.c | 3 ++- src/conf/nwfilter_params.c | 3 ++- src/conf/virnetworkobj.c | 3 ++- src/hypervisor/domain_driver.c | 3 ++- src/hypervisor/virhostdev.c | 3 ++- src/libxl/libxl_driver.c | 9 ++++++--- src/libxl/xen_common.c | 12 ++++++++---- src/libxl/xen_xl.c | 24 +++++++++++++++-------- src/libxl/xen_xm.c | 3 ++- src/lxc/lxc_controller.c | 3 ++- src/lxc/lxc_driver.c | 12 ++++++++---- src/network/bridge_driver.c | 9 +++++++-- src/nwfilter/nwfilter_ebiptables_driver.c | 6 ++++-- src/openvz/openvz_driver.c | 3 ++- src/qemu/qemu_agent.c | 3 ++- src/qemu/qemu_domain.c | 3 ++- src/qemu/qemu_driver.c | 15 +++++++++----- src/qemu/qemu_monitor_json.c | 14 +++++++++---- src/rpc/virnetserverclient.c | 3 ++- src/security/security_stack.c | 3 ++- src/test/test_driver.c | 3 ++- src/util/virconf.c | 11 ++++++++--- src/util/virnetdevbandwidth.c | 3 ++- src/util/virnetdevbandwidth.h | 3 ++- src/vz/vz_driver.c | 3 ++- src/vz/vz_sdk.c | 9 ++++++--- tests/virnetdaemontest.c | 12 ++++++++---- tests/virpcitest.c | 9 ++++++--- 32 files changed, 139 insertions(+), 65 deletions(-) diff --git a/src/bhyve/bhyve_command.c b/src/bhyve/bhyve_command.c index c4c64788b9..e3c2921dea 100644 --- a/src/bhyve/bhyve_command.c +++ b/src/bhyve/bhyve_command.c @@ -917,7 +917,10 @@ virBhyveProcessBuildGrubbhyveCmd(virDomainDefPtr def, const char *devmap_file, char **devicesmap_out) { - virDomainDiskDefPtr hdd, cd, userdef, diskdef; + virDomainDiskDefPtr hdd; + virDomainDiskDefPtr cd; + virDomainDiskDefPtr userdef; + virDomainDiskDefPtr diskdef; virCommandPtr cmd; unsigned int best_idx = UINT_MAX; size_t i; diff --git a/src/bhyve/bhyve_driver.c b/src/bhyve/bhyve_driver.c index 8363259d4c..158fee4445 100644 --- a/src/bhyve/bhyve_driver.c +++ b/src/bhyve/bhyve_driver.c @@ -681,7 +681,8 @@ bhyveConnectDomainXMLToNative(virConnectPtr conn, g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; bhyveConnPtr privconn = conn->privateData; virDomainDefPtr def = NULL; - virCommandPtr cmd = NULL, loadcmd = NULL; + virCommandPtr cmd = NULL; + virCommandPtr loadcmd = NULL; char *ret = NULL; virCheckFlags(0, NULL); diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index fa08f5381d..8b927689f8 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -2082,7 +2082,8 @@ int virDomainUSBAddressSetAddHub(virDomainUSBAddressSetPtr addrs, virDomainHubDefPtr hub) { - virDomainUSBAddressHubPtr targetHub = NULL, newHub = NULL; + virDomainUSBAddressHubPtr targetHub = NULL; + virDomainUSBAddressHubPtr newHub = NULL; int ret = -1; int targetPort; g_autofree char *portStr = NULL; diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 08e09362ee..47756ff0be 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -17621,7 +17621,8 @@ virDomainChrDefPtr virDomainChrRemove(virDomainDefPtr vmdef, virDomainChrDefPtr chr) { - virDomainChrDefPtr ret = NULL, **arrPtr = NULL; + virDomainChrDefPtr ret = NULL; + virDomainChrDefPtr **arrPtr = NULL; size_t i, *cntPtr = NULL; if (virDomainChrGetDomainPtrsInternal(vmdef, chr->deviceType, diff --git a/src/conf/numa_conf.c b/src/conf/numa_conf.c index 338d779e90..64b93fd7d1 100644 --- a/src/conf/numa_conf.c +++ b/src/conf/numa_conf.c @@ -780,7 +780,8 @@ virDomainNumaDefNodeDistanceParseXML(virDomainNumaPtr def, } for (i = 0; i < sibling; i++) { - virDomainNumaDistancePtr ldist, rdist; + virDomainNumaDistancePtr ldist; + virDomainNumaDistancePtr rdist; unsigned int sibling_id, sibling_value; /* siblings are in order of parsing or explicitly numbered */ diff --git a/src/conf/nwfilter_params.c b/src/conf/nwfilter_params.c index 1be492759a..5fa5d4fedb 100644 --- a/src/conf/nwfilter_params.c +++ b/src/conf/nwfilter_params.c @@ -402,7 +402,8 @@ virNWFilterVarCombIterEntryAreUniqueEntries(virNWFilterVarCombIterEntryPtr cie, GHashTable *hash) { size_t i, j; - virNWFilterVarValuePtr varValue, tmp; + virNWFilterVarValuePtr varValue; + virNWFilterVarValuePtr tmp; const char *value; varValue = virHashLookup(hash, cie->varNames[0]); diff --git a/src/conf/virnetworkobj.c b/src/conf/virnetworkobj.c index 1e167c7874..6ff6c63218 100644 --- a/src/conf/virnetworkobj.c +++ b/src/conf/virnetworkobj.c @@ -1254,7 +1254,8 @@ virNetworkObjUpdate(virNetworkObjPtr obj, unsigned int flags) /* virNetworkUpdateFlags */ { int ret = -1; - virNetworkDefPtr livedef = NULL, configdef = NULL; + virNetworkDefPtr livedef = NULL; + virNetworkDefPtr configdef = NULL; /* normalize config data, and check for common invalid requests. */ if (virNetworkObjConfigChangeSetup(obj, xmlopt, flags) < 0) diff --git a/src/hypervisor/domain_driver.c b/src/hypervisor/domain_driver.c index c08b7d46c5..ef5803ec2a 100644 --- a/src/hypervisor/domain_driver.c +++ b/src/hypervisor/domain_driver.c @@ -128,7 +128,8 @@ virDomainDriverMergeBlkioDevice(virBlkioDevicePtr *dest_array, const char *type) { size_t i, j; - virBlkioDevicePtr dest, src; + virBlkioDevicePtr dest; + virBlkioDevicePtr src; for (i = 0; i < src_size; i++) { bool found = false; diff --git a/src/hypervisor/virhostdev.c b/src/hypervisor/virhostdev.c index 01c56f51bc..a3ec63138e 100644 --- a/src/hypervisor/virhostdev.c +++ b/src/hypervisor/virhostdev.c @@ -832,7 +832,8 @@ virHostdevPreparePCIDevicesImpl(virHostdevManagerPtr mgr, /* Step 6: Set driver and domain information */ for (i = 0; i < virPCIDeviceListCount(pcidevs); i++) { - virPCIDevicePtr pci, actual; + virPCIDevicePtr pci; + virPCIDevicePtr actual; /* We need to look up the actual device and set the information * there because 'pci' only contain address information and will diff --git a/src/libxl/libxl_driver.c b/src/libxl/libxl_driver.c index c93dbeeabf..e3d769b5d9 100644 --- a/src/libxl/libxl_driver.c +++ b/src/libxl/libxl_driver.c @@ -3961,9 +3961,12 @@ libxlDomainDetachDeviceLive(libxlDriverPrivatePtr driver, static int libxlDomainDetachDeviceConfig(virDomainDefPtr vmdef, virDomainDeviceDefPtr dev) { - virDomainDiskDefPtr disk, detach; - virDomainHostdevDefPtr hostdev, det_hostdev; - virDomainControllerDefPtr cont, det_cont; + virDomainDiskDefPtr disk; + virDomainDiskDefPtr detach; + virDomainHostdevDefPtr hostdev; + virDomainHostdevDefPtr det_hostdev; + virDomainControllerDefPtr cont; + virDomainControllerDefPtr det_cont; virDomainNetDefPtr net; int idx; diff --git a/src/libxl/xen_common.c b/src/libxl/xen_common.c index c56815d7fc..baa6edf61c 100644 --- a/src/libxl/xen_common.c +++ b/src/libxl/xen_common.c @@ -1611,7 +1611,8 @@ static int xenFormatSerial(virConfValuePtr list, virDomainChrDefPtr serial) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; int ret; if (serial) { @@ -1666,7 +1667,8 @@ xenFormatNet(virConnectPtr conn, const char *vif_typename) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; char macaddr[VIR_MAC_STRING_BUFLEN]; virBufferAsprintf(&buf, "mac=%s", virMacAddrFormat(&net->mac, macaddr)); @@ -1820,7 +1822,8 @@ xenFormatPCI(virConfPtr conf, virDomainDefPtr def) for (i = 0; i < def->nhostdevs; i++) { if (def->hostdevs[i]->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && def->hostdevs[i]->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_PCI) { - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; char *buf; const char *permissive_str = NULL; @@ -2294,7 +2297,8 @@ xenFormatVfb(virConfPtr conf, virDomainDefPtr def) return -1; } } else { - virConfValuePtr vfb, disp; + virConfValuePtr vfb; + virConfValuePtr disp; char *vfbstr = NULL; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; diff --git a/src/libxl/xen_xl.c b/src/libxl/xen_xl.c index 29c145851e..a043f298b4 100644 --- a/src/libxl/xen_xl.c +++ b/src/libxl/xen_xl.c @@ -1395,7 +1395,8 @@ static int xenFormatXLVnode(virConfValuePtr list, virBufferPtr buf) { - virConfValuePtr numaPnode, tmp; + virConfValuePtr numaPnode; + virConfValuePtr tmp; numaPnode = g_new0(virConfValue, 1); @@ -1423,7 +1424,8 @@ xenFormatXLVnuma(virConfValuePtr list, int ret = -1; size_t i; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - virConfValuePtr numaVnode, tmp; + virConfValuePtr numaVnode; + virConfValuePtr tmp; virBitmapPtr cpumask = virDomainNumaGetNodeCpumask(numa, node); size_t nodeSize = virDomainNumaGetNodeMemorySize(numa, node) / 1024; g_autofree char *nodeVcpus = NULL; @@ -1638,7 +1640,8 @@ static int xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; int format = virDomainDiskGetFormat(disk); const char *driver = virDomainDiskGetDriver(disk); g_autofree char *target = NULL; @@ -1858,7 +1861,8 @@ xenFormatXLInputDevs(virConfPtr conf, virDomainDefPtr def) { size_t i; const char *devtype; - virConfValuePtr usbdevices = NULL, lastdev; + virConfValuePtr usbdevices = NULL; + virConfValuePtr lastdev; if (def->os.type == VIR_DOMAIN_OSTYPE_HVM) { usbdevices = g_new0(virConfValue, 1); @@ -1941,7 +1945,8 @@ xenFormatXLUSBController(virConfPtr conf, for (i = 0; i < def->ncontrollers; i++) { if (def->controllers[i]->type == VIR_DOMAIN_CONTROLLER_TYPE_USB) { - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; if (def->controllers[i]->model != -1) { @@ -2019,7 +2024,8 @@ xenFormatXLUSB(virConfPtr conf, for (i = 0; i < def->nhostdevs; i++) { if (def->hostdevs[i]->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && def->hostdevs[i]->source.subsys.type == VIR_DOMAIN_HOSTDEV_SUBSYS_TYPE_USB) { - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; char *buf; buf = g_strdup_printf("hostbus=%x,hostaddr=%x", @@ -2055,7 +2061,8 @@ xenFormatXLChannel(virConfValuePtr list, virDomainChrDefPtr channel) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; int sourceType = channel->source->type; - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; /* connection */ virBufferAddLit(&buf, "connection="); @@ -2145,7 +2152,8 @@ xenFormatXLDomainNamespaceData(virConfPtr conf, virDomainDefPtr def) args->list = NULL; for (i = 0; i < nsdata->num_args; i++) { - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; val = g_new0(virConfValue, 1); diff --git a/src/libxl/xen_xm.c b/src/libxl/xen_xm.c index cc24317a76..a2c1682fcf 100644 --- a/src/libxl/xen_xm.c +++ b/src/libxl/xen_xm.c @@ -275,7 +275,8 @@ xenFormatXMDisk(virConfValuePtr list, virDomainDiskDefPtr disk) { g_auto(virBuffer) buf = VIR_BUFFER_INITIALIZER; - virConfValuePtr val, tmp; + virConfValuePtr val; + virConfValuePtr tmp; const char *src = virDomainDiskGetSource(disk); int format = virDomainDiskGetFormat(disk); const char *driver = virDomainDiskGetDriver(disk); diff --git a/src/lxc/lxc_controller.c b/src/lxc/lxc_controller.c index f633a24b16..9b7cd6408d 100644 --- a/src/lxc/lxc_controller.c +++ b/src/lxc/lxc_controller.c @@ -735,7 +735,8 @@ static int virLXCControllerSetupLoopDevices(virLXCControllerPtr ctrl) static int virLXCControllerSetupCpuAffinity(virLXCControllerPtr ctrl) { int hostcpus, maxcpu = CPU_SETSIZE; - virBitmapPtr cpumap, cpumapToSet; + virBitmapPtr cpumap; + virBitmapPtr cpumapToSet; VIR_DEBUG("Setting CPU affinity"); diff --git a/src/lxc/lxc_driver.c b/src/lxc/lxc_driver.c index 51a1d01ec9..8e0ec82e0b 100644 --- a/src/lxc/lxc_driver.c +++ b/src/lxc/lxc_driver.c @@ -3129,9 +3129,11 @@ lxcDomainDetachDeviceConfig(virDomainDefPtr vmdef, virDomainDeviceDefPtr dev) { int ret = -1; - virDomainDiskDefPtr disk, det_disk; + virDomainDiskDefPtr disk; + virDomainDiskDefPtr det_disk; virDomainNetDefPtr net; - virDomainHostdevDefPtr hostdev, det_hostdev; + virDomainHostdevDefPtr hostdev; + virDomainHostdevDefPtr det_hostdev; int idx; switch (dev->type) { @@ -4294,7 +4296,8 @@ static int lxcDomainAttachDeviceFlags(virDomainPtr dom, virLXCDriverPtr driver = dom->conn->privateData; virDomainObjPtr vm = NULL; virDomainDefPtr vmdef = NULL; - virDomainDeviceDefPtr dev = NULL, dev_copy = NULL; + virDomainDeviceDefPtr dev = NULL; + virDomainDeviceDefPtr dev_copy = NULL; int ret = -1; virLXCDriverConfigPtr cfg = virLXCDriverGetConfig(driver); @@ -4468,7 +4471,8 @@ static int lxcDomainDetachDeviceFlags(virDomainPtr dom, virCapsPtr caps = NULL; virDomainObjPtr vm = NULL; virDomainDefPtr vmdef = NULL; - virDomainDeviceDefPtr dev = NULL, dev_copy = NULL; + virDomainDeviceDefPtr dev = NULL; + virDomainDeviceDefPtr dev_copy = NULL; int ret = -1; virLXCDriverConfigPtr cfg = virLXCDriverGetConfig(driver); diff --git a/src/network/bridge_driver.c b/src/network/bridge_driver.c index 32872d7ec1..3c7a49b115 100644 --- a/src/network/bridge_driver.c +++ b/src/network/bridge_driver.c @@ -1065,7 +1065,10 @@ networkDnsmasqConfContents(virNetworkObjPtr obj, size_t i; virNetworkDNSDefPtr dns = &def->dns; bool wantDNS = dns->enable != VIR_TRISTATE_BOOL_NO; - virNetworkIPDefPtr tmpipdef, ipdef, ipv4def, ipv6def; + virNetworkIPDefPtr tmpipdef; + virNetworkIPDefPtr ipdef; + virNetworkIPDefPtr ipv4def; + virNetworkIPDefPtr ipv6def; bool ipv6SLAAC; *configstr = NULL; @@ -1682,7 +1685,9 @@ networkRefreshDhcpDaemon(virNetworkDriverStatePtr driver, virNetworkDefPtr def = virNetworkObjGetDef(obj); size_t i; pid_t dnsmasqPid; - virNetworkIPDefPtr ipdef, ipv4def, ipv6def; + virNetworkIPDefPtr ipdef; + virNetworkIPDefPtr ipv4def; + virNetworkIPDefPtr ipv6def; g_autoptr(dnsmasqContext) dctx = NULL; /* if no IP addresses specified, nothing to do */ diff --git a/src/nwfilter/nwfilter_ebiptables_driver.c b/src/nwfilter/nwfilter_ebiptables_driver.c index 813ab604ae..f4afbf9ba2 100644 --- a/src/nwfilter/nwfilter_ebiptables_driver.c +++ b/src/nwfilter/nwfilter_ebiptables_driver.c @@ -3199,7 +3199,8 @@ iptablesRuleInstCommand(virFirewallPtr fw, const char *ifname, virNWFilterRuleInstPtr rule) { - virNWFilterVarCombIterPtr vciter, tmp; + virNWFilterVarCombIterPtr vciter; + virNWFilterVarCombIterPtr tmp; int ret = -1; /* rule->vars holds all the variables names that this rule will access. @@ -3234,7 +3235,8 @@ ebtablesRuleInstCommand(virFirewallPtr fw, const char *ifname, virNWFilterRuleInstPtr rule) { - virNWFilterVarCombIterPtr vciter, tmp; + virNWFilterVarCombIterPtr vciter; + virNWFilterVarCombIterPtr tmp; int ret = -1; /* rule->vars holds all the variables names that this rule will access. diff --git a/src/openvz/openvz_driver.c b/src/openvz/openvz_driver.c index 96535a8216..e898af85ab 100644 --- a/src/openvz/openvz_driver.c +++ b/src/openvz/openvz_driver.c @@ -1817,7 +1817,8 @@ openvzUpdateDevice(virDomainDefPtr vmdef, virDomainDeviceDefPtr dev, bool persist) { - virDomainFSDefPtr fs, cur; + virDomainFSDefPtr fs; + virDomainFSDefPtr cur; int pos; if (dev->type == VIR_DOMAIN_DEVICE_FS) { diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 8b880d0d15..01ba2c78c1 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -1255,7 +1255,8 @@ int qemuAgentFSFreeze(qemuAgentPtr agent, const char **mountpoints, unsigned int nmountpoints) { int ret = -1; - virJSONValuePtr cmd, arg = NULL; + virJSONValuePtr cmd; + virJSONValuePtr arg = NULL; virJSONValuePtr reply = NULL; if (mountpoints && nmountpoints) { diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index df332ad870..ed2a1481d4 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -6172,7 +6172,8 @@ qemuDomainDefFormatBufInternal(virQEMUDriverPtr driver, if ((flags & VIR_DOMAIN_XML_MIGRATABLE)) { size_t i; int toremove = 0; - virDomainControllerDefPtr usb = NULL, pci = NULL; + virDomainControllerDefPtr usb = NULL; + virDomainControllerDefPtr pci = NULL; /* If only the default USB controller is present, we can remove it * and make the XML compatible with older versions of libvirt which diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index c7323e1fa5..b7c89a826a 100644 --- a/src/qemu/qemu_driver.c +++ b/src/qemu/qemu_driver.c @@ -7431,12 +7431,16 @@ qemuDomainDetachDeviceConfig(virDomainDefPtr vmdef, unsigned int parse_flags, virDomainXMLOptionPtr xmlopt) { - virDomainDiskDefPtr disk, det_disk; + virDomainDiskDefPtr disk; + virDomainDiskDefPtr det_disk; virDomainNetDefPtr net; virDomainSoundDefPtr sound; - virDomainHostdevDefPtr hostdev, det_hostdev; - virDomainLeaseDefPtr lease, det_lease; - virDomainControllerDefPtr cont, det_cont; + virDomainHostdevDefPtr hostdev; + virDomainHostdevDefPtr det_hostdev; + virDomainLeaseDefPtr lease; + virDomainLeaseDefPtr det_lease; + virDomainControllerDefPtr cont; + virDomainControllerDefPtr det_cont; virDomainChrDefPtr chr; virDomainFSDefPtr fs; virDomainMemoryDefPtr mem; @@ -10240,7 +10244,8 @@ qemuDomainSetInterfaceParameters(virDomainPtr dom, virDomainDefPtr def; virDomainDefPtr persistentDef; int ret = -1; - virDomainNetDefPtr net = NULL, persistentNet = NULL; + virDomainNetDefPtr net = NULL; + virDomainNetDefPtr persistentNet = NULL; g_autoptr(virNetDevBandwidth) bandwidth = NULL; g_autoptr(virNetDevBandwidth) newBandwidth = NULL; g_autoptr(virQEMUDriverConfig) cfg = NULL; diff --git a/src/qemu/qemu_monitor_json.c b/src/qemu/qemu_monitor_json.c index f706ef65fc..ad62e24cfc 100644 --- a/src/qemu/qemu_monitor_json.c +++ b/src/qemu/qemu_monitor_json.c @@ -4006,7 +4006,8 @@ static int qemuMonitorJSONQueryFdsetsParse(virJSONValuePtr msg, qemuMonitorFdsetsPtr *fdsets) { - virJSONValuePtr returnArray, entry; + virJSONValuePtr returnArray; + virJSONValuePtr entry; size_t i; g_autoptr(qemuMonitorFdsets) sets = g_new0(qemuMonitorFdsets, 1); int ninfo; @@ -4213,7 +4214,10 @@ qemuMonitorJSONQueryRxFilterParse(virJSONValuePtr msg, { int ret = -1; const char *tmp; - virJSONValuePtr returnArray, entry, table, element; + virJSONValuePtr returnArray; + virJSONValuePtr entry; + virJSONValuePtr table; + virJSONValuePtr element; size_t nTable; size_t i; virNetDevRxFilterPtr fil = virNetDevRxFilterNew(); @@ -5015,7 +5019,8 @@ int qemuMonitorJSONScreendump(qemuMonitorPtr mon, const char *file) { int ret = -1; - virJSONValuePtr cmd, reply = NULL; + virJSONValuePtr cmd; + virJSONValuePtr reply = NULL; cmd = qemuMonitorJSONMakeCommand("screendump", "s:filename", file, @@ -5386,7 +5391,8 @@ int qemuMonitorJSONOpenGraphics(qemuMonitorPtr mon, bool skipauth) { int ret = -1; - virJSONValuePtr cmd, reply = NULL; + virJSONValuePtr cmd; + virJSONValuePtr reply = NULL; cmd = qemuMonitorJSONMakeCommand("add_client", "s:protocol", protocol, diff --git a/src/rpc/virnetserverclient.c b/src/rpc/virnetserverclient.c index 2bb3443287..6b9c1bbc64 100644 --- a/src/rpc/virnetserverclient.c +++ b/src/rpc/virnetserverclient.c @@ -263,7 +263,8 @@ int virNetServerClientAddFilter(virNetServerClientPtr client, void virNetServerClientRemoveFilter(virNetServerClientPtr client, int filterID) { - virNetServerClientFilterPtr tmp, prev; + virNetServerClientFilterPtr tmp; + virNetServerClientFilterPtr prev; virObjectLock(client); diff --git a/src/security/security_stack.c b/src/security/security_stack.c index 3bfcb1e2f7..2fd7d2e825 100644 --- a/src/security/security_stack.c +++ b/src/security/security_stack.c @@ -90,7 +90,8 @@ static int virSecurityStackClose(virSecurityManagerPtr mgr) { virSecurityStackDataPtr priv = virSecurityManagerGetPrivateData(mgr); - virSecurityStackItemPtr next, item = priv->itemsHead; + virSecurityStackItemPtr item = priv->itemsHead; + virSecurityStackItemPtr next; while (item) { next = item->next; diff --git a/src/test/test_driver.c b/src/test/test_driver.c index 2c1b4cb525..01b3e7bc82 100644 --- a/src/test/test_driver.c +++ b/src/test/test_driver.c @@ -7338,7 +7338,8 @@ testNodeDeviceMockCreateVport(testDriverPtr driver, { virNodeDeviceDefPtr def = NULL; virNodeDevCapsDefPtr caps; - virNodeDeviceObjPtr obj = NULL, objcopy = NULL; + virNodeDeviceObjPtr obj = NULL; + virNodeDeviceObjPtr objcopy = NULL; virNodeDeviceDefPtr objdef; virObjectEventPtr event = NULL; g_autofree char *xml = NULL; diff --git a/src/util/virconf.c b/src/util/virconf.c index 16107bce96..25a3bad50d 100644 --- a/src/util/virconf.c +++ b/src/util/virconf.c @@ -207,7 +207,8 @@ virConfCreate(const char *filename, unsigned int flags) static virConfEntryPtr virConfAddEntry(virConfPtr conf, char *name, virConfValuePtr value, char *comm) { - virConfEntryPtr ret, prev; + virConfEntryPtr ret; + virConfEntryPtr prev; if (conf == NULL) return NULL; @@ -441,7 +442,10 @@ virConfParseString(virConfParserCtxtPtr ctxt) static virConfValuePtr virConfParseValue(virConfParserCtxtPtr ctxt) { - virConfValuePtr ret, lst = NULL, tmp, prev; + virConfValuePtr ret; + virConfValuePtr lst = NULL; + virConfValuePtr tmp; + virConfValuePtr prev; virConfType type = VIR_CONF_NONE; char *str = NULL; long long l = 0; @@ -1332,7 +1336,8 @@ virConfSetValue(virConfPtr conf, const char *setting, virConfValuePtr value) { - virConfEntryPtr cur, prev = NULL; + virConfEntryPtr cur; + virConfEntryPtr prev = NULL; if (value && value->type == VIR_CONF_STRING && value->str == NULL) { virConfFreeValue(value); diff --git a/src/util/virnetdevbandwidth.c b/src/util/virnetdevbandwidth.c index 77a97176b0..f39635b35f 100644 --- a/src/util/virnetdevbandwidth.c +++ b/src/util/virnetdevbandwidth.c @@ -193,7 +193,8 @@ virNetDevBandwidthSet(const char *ifname, bool swapped) { int ret = -1; - virNetDevBandwidthRatePtr rx = NULL, tx = NULL; /* From domain POV */ + virNetDevBandwidthRatePtr rx = NULL; /* From domain POV */ + virNetDevBandwidthRatePtr tx = NULL; /* From domain POV */ virCommandPtr cmd = NULL; char *average = NULL; char *peak = NULL; diff --git a/src/util/virnetdevbandwidth.h b/src/util/virnetdevbandwidth.h index fff83222a9..91de9323ba 100644 --- a/src/util/virnetdevbandwidth.h +++ b/src/util/virnetdevbandwidth.h @@ -33,7 +33,8 @@ struct _virNetDevBandwidthRate { typedef struct _virNetDevBandwidth virNetDevBandwidth; typedef virNetDevBandwidth *virNetDevBandwidthPtr; struct _virNetDevBandwidth { - virNetDevBandwidthRatePtr in, out; + virNetDevBandwidthRatePtr in; + virNetDevBandwidthRatePtr out; }; void virNetDevBandwidthFree(virNetDevBandwidthPtr def); diff --git a/src/vz/vz_driver.c b/src/vz/vz_driver.c index 520ef871e9..f3ad22c270 100644 --- a/src/vz/vz_driver.c +++ b/src/vz/vz_driver.c @@ -408,7 +408,8 @@ vzConnectOpen(virConnectPtr conn, static int vzConnectClose(virConnectPtr conn) { - vzConnPtr curr, *prev = &vz_conn_list; + vzConnPtr curr; + vzConnPtr *prev = &vz_conn_list; vzConnPtr privconn = conn->privateData; if (!privconn) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index d8548e5a3c..ea21181c25 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -889,7 +889,8 @@ prlsdkParseNetAddress(char *addr) char *maskstr = NULL; int nbits; virSocketAddr mask; - virNetDevIPAddrPtr ip = NULL, ret = NULL; + virNetDevIPAddrPtr ip = NULL; + virNetDevIPAddrPtr ret = NULL; if (!(maskstr = strchr(addr, '/'))) goto cleanup; @@ -3141,12 +3142,14 @@ static int prlsdkConfigureGateways(PRL_HANDLE sdknet, virDomainNetDefPtr net) { int ret = -1; size_t i; - virNetDevIPRoutePtr route4 = NULL, route6 = NULL; + virNetDevIPRoutePtr route4 = NULL; + virNetDevIPRoutePtr route6 = NULL; char *gw4 = NULL, *gw6 = NULL; PRL_RESULT pret; for (i = 0; i < net->guestIP.nroutes; i++) { - virSocketAddrPtr addrdst, gateway; + virSocketAddrPtr addrdst; + virSocketAddrPtr gateway; virSocketAddr zero; addrdst = virNetDevIPRouteGetAddress(net->guestIP.routes[i]); diff --git a/tests/virnetdaemontest.c b/tests/virnetdaemontest.c index fb40fe9b80..c77c21611f 100644 --- a/tests/virnetdaemontest.c +++ b/tests/virnetdaemontest.c @@ -84,9 +84,12 @@ static virNetServerPtr testCreateServer(const char *server_name, const char *host, int family) { virNetServerPtr srv = NULL; - virNetServerServicePtr svc1 = NULL, svc2 = NULL; - virNetServerClientPtr cln1 = NULL, cln2 = NULL; - virNetSocketPtr sk1 = NULL, sk2 = NULL; + virNetServerServicePtr svc1 = NULL; + virNetServerServicePtr svc2 = NULL; + virNetServerClientPtr cln1 = NULL; + virNetServerClientPtr cln2 = NULL; + virNetSocketPtr sk1 = NULL; + virNetSocketPtr sk2 = NULL; int fdclient[2]; if (socketpair(PF_UNIX, SOCK_STREAM, 0, fdclient) < 0) { @@ -269,7 +272,8 @@ static int testExecRestart(const void *opaque) const struct testExecRestartData *data = opaque; char *infile = NULL, *outfile = NULL; char *injsonstr = NULL, *outjsonstr = NULL; - virJSONValuePtr injson = NULL, outjson = NULL; + virJSONValuePtr injson = NULL; + virJSONValuePtr outjson = NULL; int fdclient[2] = { -1, -1 }, fdserver[2] = { -1, -1 }; if (socketpair(PF_UNIX, SOCK_STREAM, 0, fdclient) < 0) { diff --git a/tests/virpcitest.c b/tests/virpcitest.c index 6a4bd5518d..b6ca686c5c 100644 --- a/tests/virpcitest.c +++ b/tests/virpcitest.c @@ -93,7 +93,8 @@ testVirPCIDeviceDetach(const void *opaque G_GNUC_UNUSED) int ret = -1; virPCIDevicePtr dev[] = {NULL, NULL, NULL}; size_t i, nDev = G_N_ELEMENTS(dev); - virPCIDeviceListPtr activeDevs = NULL, inactiveDevs = NULL; + virPCIDeviceListPtr activeDevs = NULL; + virPCIDeviceListPtr inactiveDevs = NULL; int count; if (!(activeDevs = virPCIDeviceListNew()) || @@ -136,7 +137,8 @@ testVirPCIDeviceReset(const void *opaque G_GNUC_UNUSED) int ret = -1; virPCIDevicePtr dev[] = {NULL, NULL, NULL}; size_t i, nDev = G_N_ELEMENTS(dev); - virPCIDeviceListPtr activeDevs = NULL, inactiveDevs = NULL; + virPCIDeviceListPtr activeDevs = NULL; + virPCIDeviceListPtr inactiveDevs = NULL; int count; if (!(activeDevs = virPCIDeviceListNew()) || @@ -173,7 +175,8 @@ testVirPCIDeviceReattach(const void *opaque G_GNUC_UNUSED) int ret = -1; virPCIDevicePtr dev[] = {NULL, NULL, NULL}; size_t i, nDev = G_N_ELEMENTS(dev); - virPCIDeviceListPtr activeDevs = NULL, inactiveDevs = NULL; + virPCIDeviceListPtr activeDevs = NULL; + virPCIDeviceListPtr inactiveDevs = NULL; int count; if (!(activeDevs = virPCIDeviceListNew()) || -- 2.26.2