[libvirt] [PATCH python] allow pkg-config binary to be set by env
From: Markus Rothe <markusr815@gmail.com> https://bugzilla.redhat.com/show_bug.cgi?id=1350523 --- setup.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/setup.py b/setup.py index 099b1e0..a4cfb88 100755 --- a/setup.py +++ b/setup.py @@ -28,6 +28,8 @@ _pkgcfg = -1 def get_pkgcfg(do_fail=True): global _pkgcfg if _pkgcfg == -1: + _pkgcfg = os.getenv('PKG_CONFIG') + if _pkgcfg is None: _pkgcfg = distutils.spawn.find_executable("pkg-config") if _pkgcfg is None and do_fail: raise Exception("pkg-config binary is required to compile libvirt-python") -- 2.7.4
ping reviewers On 06/28/2016 03:10 PM, Cole Robinson wrote:
From: Markus Rothe <markusr815@gmail.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1350523 --- setup.py | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/setup.py b/setup.py index 099b1e0..a4cfb88 100755 --- a/setup.py +++ b/setup.py @@ -28,6 +28,8 @@ _pkgcfg = -1 def get_pkgcfg(do_fail=True): global _pkgcfg if _pkgcfg == -1: + _pkgcfg = os.getenv('PKG_CONFIG') + if _pkgcfg is None: _pkgcfg = distutils.spawn.find_executable("pkg-config") if _pkgcfg is None and do_fail: raise Exception("pkg-config binary is required to compile libvirt-python")
On 28.06.2016 21:10, Cole Robinson wrote:
From: Markus Rothe <markusr815@gmail.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1350523 --- setup.py | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/setup.py b/setup.py index 099b1e0..a4cfb88 100755 --- a/setup.py +++ b/setup.py @@ -28,6 +28,8 @@ _pkgcfg = -1 def get_pkgcfg(do_fail=True): global _pkgcfg if _pkgcfg == -1: + _pkgcfg = os.getenv('PKG_CONFIG') + if _pkgcfg is None: _pkgcfg = distutils.spawn.find_executable("pkg-config") if _pkgcfg is None and do_fail: raise Exception("pkg-config binary is required to compile libvirt-python")
ACK Michal
On 07/28/2016 10:57 AM, Michal Privoznik wrote:
On 28.06.2016 21:10, Cole Robinson wrote:
From: Markus Rothe <markusr815@gmail.com>
https://bugzilla.redhat.com/show_bug.cgi?id=1350523 --- setup.py | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/setup.py b/setup.py index 099b1e0..a4cfb88 100755 --- a/setup.py +++ b/setup.py @@ -28,6 +28,8 @@ _pkgcfg = -1 def get_pkgcfg(do_fail=True): global _pkgcfg if _pkgcfg == -1: + _pkgcfg = os.getenv('PKG_CONFIG') + if _pkgcfg is None: _pkgcfg = distutils.spawn.find_executable("pkg-config") if _pkgcfg is None and do_fail: raise Exception("pkg-config binary is required to compile libvirt-python")
ACK
Michal
Thanks, pushed now - Cole
participants (2)
-
Cole Robinson -
Michal Privoznik