[libvirt] [jenkins-ci PATCH] guests: Install dbus-daemon for libvirt-dbus
Apparently it's not part of the base system in current Fedora Rawhide, leading to failures in the test suite. Drag it in explicitly to ensure tests pass. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/vars/mappings.yml | 5 +++++ guests/vars/projects/libvirt-dbus.yml | 1 + 2 files changed, 6 insertions(+) diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml index b160c50..238ae88 100644 --- a/guests/vars/mappings.yml +++ b/guests/vars/mappings.yml @@ -79,6 +79,11 @@ mappings: pkg: cyrus-sasl rpm: cyrus-sasl-devel + dbus-daemon: + default: dbus + Fedora: dbus-daemon + Fedora28: dbus + device-mapper: deb: libdevmapper-dev rpm: device-mapper-devel diff --git a/guests/vars/projects/libvirt-dbus.yml b/guests/vars/projects/libvirt-dbus.yml index 22052de..ce902cb 100644 --- a/guests/vars/projects/libvirt-dbus.yml +++ b/guests/vars/projects/libvirt-dbus.yml @@ -1,5 +1,6 @@ --- packages: + - dbus-daemon - flake8 - glib2 - python3 -- 2.20.1
On Tue, Jan 15, 2019 at 12:28:17PM +0100, Andrea Bolognani wrote:
Apparently it's not part of the base system in current Fedora Rawhide, leading to failures in the test suite. Drag it in explicitly to ensure tests pass.
For now I guess this is OK, but we need to probably improve libvirt-dbus tests to detect the default dbus daemon because in fedora rawhide the default dbus daemon is provided by dbus-broker package with different and supposedly better implementation. Reviewed-by: Pavel Hrdina <phrdina@redhat.com>
On Tue, 2019-01-15 at 13:15 +0100, Pavel Hrdina wrote:
On Tue, Jan 15, 2019 at 12:28:17PM +0100, Andrea Bolognani wrote:
Apparently it's not part of the base system in current Fedora Rawhide, leading to failures in the test suite. Drag it in explicitly to ensure tests pass.
For now I guess this is OK, but we need to probably improve libvirt-dbus tests to detect the default dbus daemon because in fedora rawhide the default dbus daemon is provided by dbus-broker package with different and supposedly better implementation.
Interesting, I didn't know about that! We can definitely change it later, once the relevant libvirt-dbus changes have been merged :) -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Pavel Hrdina