[Libvir] [PATCH] Remove dead code
The attached patch removes 1000 lines of dead code from xml.c and xend_internal.c. It is not clear that this code was ever used at all in the past, and we certainly don't use or test it today. If we truely need it in the future, we can trivially get it back from the CVS repo. KIlling it now makes its easier to maintain the code base because we're not obscuring active code with historical cruft. Finally it will also make the code coverage reporting more useful since it won't be complaining about untested code we never use. Any objections to me applying this ? Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Wed, Feb 07, 2007 at 04:58:10PM +0000, Daniel P. Berrange wrote:
The attached patch removes 1000 lines of dead code from xml.c and xend_internal.c. It is not clear that this code was ever used at all in the past, and we certainly don't use or test it today. If we truely need it in the future, we can trivially get it back from the CVS repo. KIlling it now makes its easier to maintain the code base because we're not obscuring active code with historical cruft. Finally it will also make the code coverage reporting more useful since it won't be complaining about untested code we never use.
Any objections to me applying this ?
Fine by me, some of this is old code from early experiments. Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel P. Berrange -
Daniel Veillard