8:31 a.m.
Andrea Bolognani (2):
syntax-check: Add versioning information
syntax-check: Pull updates from gnulib
build-aux/syntax-check.mk | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
--
2.35.3
8:31 a.m.
New subject: [libvirt PATCH 1/2] syntax-check: Add versioning information
Our copy of syntax-check has diverged quite a bit from the
gnulib original, but a lot of the core logic has remained
identical and it would be nice if we could periodically pull
improvements.
To make this manageable, record the gnulib commit our copy is
derived from: this way, the person updating the file will know
the range of gnulib commits that they have to consider.
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
build-aux/syntax-check.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 09e7a014a3..3ae5abd11a 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -2,6 +2,10 @@
# Rules for running syntax-check, derived from gnulib's
# maint.mk
#
+# Specifically, all shared code should match gnulib commit
+#
+# 1f6fb368c04919243e2c70f2aa514a5f88e95309 (2019-08-19)
+#
# Copyright (C) 2008-2019 Red Hat, Inc.
# Copyright (C) 2003-2019 Free Software Foundation, Inc.
--
2.35.3
8:31 a.m.
New subject: [libvirt PATCH 2/2] syntax-check: Pull updates from gnulib
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
build-aux/syntax-check.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 3ae5abd11a..73f8a21c1b 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -4,10 +4,10 @@
#
# Specifically, all shared code should match gnulib commit
#
-# 1f6fb368c04919243e2c70f2aa514a5f88e95309 (2019-08-19)
+# dd2503c8e73621e919e8e214a29c495ac89d8a92 (2022-05-21)
#
# Copyright (C) 2008-2019 Red Hat, Inc.
-# Copyright (C) 2003-2019 Free Software Foundation, Inc.
+# Copyright (C) 2001-2022 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -1155,7 +1155,7 @@ perl_filename_lineno_text_ = \
-e ' }'
prohibit_doubled_words_ = \
- the then in an on if is it but for or at and do to
+ the then in an on if is it but for or at and do to can
# expand the regex before running the check to avoid using expensive captures
prohibit_doubled_word_expanded_ = \
$(join $(prohibit_doubled_words_),$(addprefix \s+,$(prohibit_doubled_words_)))
--
2.35.3
8:41 a.m.
New subject: [libvirt PATCH 2/2] syntax-check: Pull updates from gnulib
On 5/24/22 15:31, Andrea Bolognani wrote:
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
build-aux/syntax-check.mk | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
index 3ae5abd11a..73f8a21c1b 100644
--- a/build-aux/syntax-check.mk
+++ b/build-aux/syntax-check.mk
@@ -4,10 +4,10 @@
#
# Specifically, all shared code should match gnulib commit
#
-# 1f6fb368c04919243e2c70f2aa514a5f88e95309 (2019-08-19)
+# dd2503c8e73621e919e8e214a29c495ac89d8a92 (2022-05-21)
#
# Copyright (C) 2008-2019 Red Hat, Inc.
-# Copyright (C) 2003-2019 Free Software Foundation, Inc.
+# Copyright (C) 2001-2022 Free Software Foundation, Inc.
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
@@ -1155,7 +1155,7 @@ perl_filename_lineno_text_ = \
-e ' }'
prohibit_doubled_words_ = \
- the then in an on if is it but for or at and do to
+ the then in an on if is it but for or at and do to can
Can can opener open this can?
Michal
8:50 a.m.
New subject: [libvirt PATCH 2/2] syntax-check: Pull updates from gnulib
On Tue, May 24, 2022 at 03:41:47PM +0200, Michal Prívozník wrote:
On 5/24/22 15:31, Andrea Bolognani wrote:
> Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
> ---
> build-aux/syntax-check.mk | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk
> index 3ae5abd11a..73f8a21c1b 100644
> --- a/build-aux/syntax-check.mk
> +++ b/build-aux/syntax-check.mk
> @@ -4,10 +4,10 @@
> #
> # Specifically, all shared code should match gnulib commit
> #
> -# 1f6fb368c04919243e2c70f2aa514a5f88e95309 (2019-08-19)
> +# dd2503c8e73621e919e8e214a29c495ac89d8a92 (2022-05-21)
> #
> # Copyright (C) 2008-2019 Red Hat, Inc.
> -# Copyright (C) 2003-2019 Free Software Foundation, Inc.
> +# Copyright (C) 2001-2022 Free Software Foundation, Inc.
>
> # This program is free software: you can redistribute it and/or modify
> # it under the terms of the GNU General Public License as published by
> @@ -1155,7 +1155,7 @@ perl_filename_lineno_text_ = \
> -e ' }'
>
> prohibit_doubled_words_ = \
> - the then in an on if is it but for or at and do to
> + the then in an on if is it but for or at and do to can
Can can opener open this can?
No, but -EGRAMMAR ;-P
Can the can opener open this can
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
8:51 a.m.
New subject: [libvirt PATCH 2/2] syntax-check: Pull updates from gnulib
On Tue, May 24, 2022 at 03:41:47PM +0200, Michal Prívozník wrote:
On 5/24/22 15:31, Andrea Bolognani wrote:
> prohibit_doubled_words_ = \
> - the then in an on if is it but for or at and do to
> + the then in an on if is it but for or at and do to can
Can can opener open this can?
Not if it wants to keep syntax-check working ;)
Thanks for all the reviews!
--
Andrea Bolognani / Red Hat / Virtualization
8:41 a.m.
On 5/24/22 15:31, Andrea Bolognani wrote:
Andrea Bolognani (2):
syntax-check: Add versioning information
syntax-check: Pull updates from gnulib
build-aux/syntax-check.mk | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn(a)redhat.com>
Michal
914
days inactive
914
days old
6 comments
3 participants
participants (3)
-
Andrea Bolognani -
Daniel P. Berrangé -
Michal Prívozník