[libvirt] [PATCH 0/2] rpm: fix usage of 'nc' dep
Daniel P. Berrangé (2): rpm: depend on /usr/bin/nc instead of nc rpm: move nc dep into the libvirt-daemon sub-RPM libvirt.spec.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) -- 2.21.0
The 'nc' RPM does not in fact exist anymore, this is a virtual provide from the nmap-ncat RPM which the maintainer wishes to delete. Change the dep to use the actual binary path we want to invoke. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index ee4b408510..b941ba1fc2 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -900,7 +900,7 @@ capabilities of recent versions of Linux (and other OSes). Summary: Client side libraries # So remote clients can access libvirt over SSH tunnel # (client invokes 'nc' against the UNIX socket on the server) -Requires: nc +Requires: /usr/bin/nc Requires: cyrus-sasl # Needed by default sasl.conf - no onerous extra deps, since # 100's of other things on a system already pull in krb5-libs -- 2.21.0
The remote client invokes the 'nc' binary on the remote server to tunnel access to the socket. As such the 'nc' binary needs to be pulled in only by the libvirt-daemon sub-RPM, not the libvirt-client sub-RPM. Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> --- libvirt.spec.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index b941ba1fc2..fd956cf0ee 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -425,6 +425,9 @@ Summary: Server side daemon and supporting files for libvirt library # The client side, i.e. shared libs are in a subpackage Requires: %{name}-libs = %{version}-%{release} +# (client invokes 'nc' against the UNIX socket on the server) +Requires: /usr/bin/nc + # for modprobe of pci devices Requires: module-init-tools @@ -899,8 +902,6 @@ capabilities of recent versions of Linux (and other OSes). %package libs Summary: Client side libraries # So remote clients can access libvirt over SSH tunnel -# (client invokes 'nc' against the UNIX socket on the server) -Requires: /usr/bin/nc Requires: cyrus-sasl # Needed by default sasl.conf - no onerous extra deps, since # 100's of other things on a system already pull in krb5-libs -- 2.21.0
ping On Tue, Aug 20, 2019 at 10:17:15AM +0100, Daniel P. Berrangé wrote:
Daniel P. Berrangé (2): rpm: depend on /usr/bin/nc instead of nc rpm: move nc dep into the libvirt-daemon sub-RPM
libvirt.spec.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
-- 2.21.0
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 8/20/19 11:17 AM, Daniel P. Berrangé wrote:
Daniel P. Berrangé (2): rpm: depend on /usr/bin/nc instead of nc rpm: move nc dep into the libvirt-daemon sub-RPM
libvirt.spec.in | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
participants (2)
-
Daniel P. Berrangé -
Michal Privoznik