On Tue, Nov 15, 2011 at 05:20:40PM +0800, Jenna Johnson wrote:

folks, Noticed that in function "networkStartNetworkVirtual" only have IPv4 addr checked in "networkCheckRouteCollision",will it be a problem that we don't check IPv6 addr?

We primarily put the check in there because we have a hardcoded IPv4 address in the default network, and this causes pain when you run libvirt inside a guest. Since we have no default IPv6 address, we don't need to worry about that usecase. That all said, this check also prevents admin mis-configurations which can mess up their host networking, and this is still relevant for IPv6. So yes, we should make our collision check work for IPv6 too, but it is not a critical problem like IPv4 was. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|