[libvirt] [jenkins-ci PATCH v2 0/2] Enable libosinfo tests that require network connectivity
Let's enable both media and tree uris tests in order to early catch URL changes that need to be fixed in osinfo-db. Fabiano Fidêncio (2): guests: Enable {media,tree}uris tests for libosinfo projects: Enable {media,tree}uri tests for libosinfo guests/playbooks/build/projects/libosinfo.yml | 4 ++++ projects/libosinfo.yaml | 3 +++ 2 files changed, 7 insertions(+) -- 2.17.1
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/playbooks/build/projects/libosinfo.yml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/guests/playbooks/build/projects/libosinfo.yml b/guests/playbooks/build/projects/libosinfo.yml index 311a52b..dce1333 100644 --- a/guests/playbooks/build/projects/libosinfo.yml +++ b/guests/playbooks/build/projects/libosinfo.yml @@ -9,6 +9,10 @@ - include: '{{ playbook_base }}/jobs/autotools-build-job.yml' - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml' - include: '{{ playbook_base }}/jobs/autotools-check-job.yml' + vars: + local_env: | + # Run tests that require network connectivity + export LIBOSINFO_NETWORK_TESTS=1 - include: '{{ playbook_base }}/jobs/autotools-rpm-job.yml' vars: machines: '{{ rpm_machines }}' -- 2.17.1
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- projects/libosinfo.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/projects/libosinfo.yaml b/projects/libosinfo.yaml index 0376d0c..bf9ea6b 100644 --- a/projects/libosinfo.yaml +++ b/projects/libosinfo.yaml @@ -12,6 +12,9 @@ parent_jobs: 'libosinfo-build' - autotools-check-job: parent_jobs: 'libosinfo-syntax-check' + local_env: | + # Run tests that require network connectivity + export LIBOSINFO_NETWORK_TESTS=1 - autotools-rpm-job: parent_jobs: 'libosinfo-check' machines: '{rpm_machines}' -- 2.17.1
On Tue, 2018-09-11 at 09:36 +0200, Fabiano Fidêncio wrote:
Let's enable both media and tree uris tests in order to early catch URL changes that need to be fixed in osinfo-db.
Fabiano Fidêncio (2): guests: Enable {media,tree}uris tests for libosinfo projects: Enable {media,tree}uri tests for libosinfo
guests/playbooks/build/projects/libosinfo.yml | 4 ++++ projects/libosinfo.yaml | 3 +++ 2 files changed, 7 insertions(+)
So I guess libosinfo has been fixed in the meantime? Assuming that's the case and that you squash the two patches together[1], Reviewed-by: Andrea Bolognani <abologna@redhat.com> [1] We've been mostly doing that since introducing the build playbooks, as changing both Jenkins and Ansible at the same time makes it obvious that they're being kept in sync. -- Andrea Bolognani / Red Hat / Virtualization
On Wed, Sep 12, 2018 at 12:29 PM, Andrea Bolognani <abologna@redhat.com> wrote:
On Tue, 2018-09-11 at 09:36 +0200, Fabiano Fidêncio wrote:
Let's enable both media and tree uris tests in order to early catch URL changes that need to be fixed in osinfo-db.
Fabiano Fidêncio (2): guests: Enable {media,tree}uris tests for libosinfo projects: Enable {media,tree}uri tests for libosinfo
guests/playbooks/build/projects/libosinfo.yml | 4 ++++ projects/libosinfo.yaml | 3 +++ 2 files changed, 7 insertions(+)
So I guess libosinfo has been fixed in the meantime?
In the end there was no libosinfo issue but a Fedora mirroring issue in our infra. And, yes, it's solved now.
Assuming that's the case and that you squash the two patches together[1],
As I don't have commit rights, would you mind squashing the patches efore pushing them?
Reviewed-by: Andrea Bolognani <abologna@redhat.com>
[1] We've been mostly doing that since introducing the build playbooks, as changing both Jenkins and Ansible at the same time makes it obvious that they're being kept in sync. -- Andrea Bolognani / Red Hat / Virtualization
Best Regards, -- Fabiano Fidêncio
On Wed, 2018-09-12 at 14:23 +0200, Fabiano Fidêncio wrote:
On Wed, Sep 12, 2018 at 12:29 PM, Andrea Bolognani <abologna@redhat.com> wrote:
Assuming that's the case and that you squash the two patches together[1],
As I don't have commit rights, would you mind squashing the patches efore pushing them?
Squashed, pushed, and changes applied to Jenkins :) -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Fabiano Fidêncio