[libvirt] [PATCH] mingw: Add body for virFork and remove double virDriverLoadModule export

Commit 9bd3cce0d2d54e6ab893bb8137218b83d9294714 added virFork and virDriverLoadModule to libvirt_private.syms, but virFork didn't have a body on Win32 and virDriverLoadModule was already correctly exported conditional via libvirt_driver_modules.syms. --- src/libvirt_private.syms | 4 ---- src/util/util.c | 9 +++++++++ 2 files changed, 9 insertions(+), 4 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 1a71e79..670e9f2 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -314,10 +314,6 @@ virDomainConfNWFilterTeardown; virDomainConfVMNWFilterTeardown; -# driver.h -virDriverLoadModule; - - # ebtables.h ebtablesAddForwardAllowIn; ebtablesAddForwardPolicyReject; diff --git a/src/util/util.c b/src/util/util.c index 586baee..fd4d6d4 100644 --- a/src/util/util.c +++ b/src/util/util.c @@ -927,6 +927,15 @@ virExecDaemonize(const char *const*argv ATTRIBUTE_UNUSED, return -1; } +int +virFork(pid_t *pid) +{ + *pid = -1; + errno = ENOTSUP; + + return -1; +} + # endif /* WIN32 */ int -- 1.7.0.4

On Wed, Oct 27, 2010 at 12:02:40PM +0200, Matthias Bolte wrote:
Commit 9bd3cce0d2d54e6ab893bb8137218b83d9294714 added virFork and virDriverLoadModule to libvirt_private.syms, but virFork didn't have a body on Win32 and virDriverLoadModule was already correctly exported conditional via libvirt_driver_modules.syms. --- src/libvirt_private.syms | 4 ---- src/util/util.c | 9 +++++++++ 2 files changed, 9 insertions(+), 4 deletions(-)
ACK thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

2010/10/27 Daniel Veillard <veillard@redhat.com>:
On Wed, Oct 27, 2010 at 12:02:40PM +0200, Matthias Bolte wrote:
Commit 9bd3cce0d2d54e6ab893bb8137218b83d9294714 added virFork and virDriverLoadModule to libvirt_private.syms, but virFork didn't have a body on Win32 and virDriverLoadModule was already correctly exported conditional via libvirt_driver_modules.syms. --- src/libvirt_private.syms | 4 ---- src/util/util.c | 9 +++++++++ 2 files changed, 9 insertions(+), 4 deletions(-)
ACK
thanks !
Daniel
Thanks, pushed. Matthias
participants (2)
-
Daniel Veillard
-
Matthias Bolte