[libvirt] [TCK PATCH] maint: use correct Red Hat copyright
* scripts/domain/050-transient-lifecycle.t: Correct the copyright line. * scripts/domain/051-transient-autostart.t: Likewise. * scripts/domain/060-persistent-lifecycle.t: Likewise. * scripts/domain/061-persistent-autostart.t: Likewise. * scripts/domain/065-persistent-redefine.t: Likewise. * scripts/domain/070-transient-to-persistent.t: Likewise. * scripts/domain/080-unique-id-define.t: Likewise. * scripts/domain/081-unique-id-create.t: Likewise. * scripts/domain/090-invalid-ops-when-inactive.t: Likewise. * scripts/domain/100-transient-save-restore.t: Likewise. * scripts/domain/101-persistent-save-restore.t: Likewise. * scripts/domain/102-broken-save-restore.t: Likewise. * scripts/domain/120-disks-stats.t: Likewise. * scripts/domain/200-disk-hotplug.t: Likewise. * scripts/domain/205-disk-hotplug-ordering.t: Likewise. * scripts/domain/210-nic-hotplug.t: Likewise. * scripts/domain/215-nic-hotplug-many.t: Likewise. * scripts/domain/240-usb-host-hotplug.t: Likewise. * scripts/domain/250-pci-host-hotplug.t: Likewise. * scripts/qemu/100-disk-encryption.t: Likewise. * scripts/storage/100-create-vol-dir.t: Likewise. * scripts/storage/200-clone-vol-dir.t: Likewise. Signed-off-by: Eric Blake <eblake@redhat.com> --- This probably counts as trivial, but since this is my first libvirt-tck patch, I thought I'd ask first. scripts/domain/050-transient-lifecycle.t | 2 +- scripts/domain/051-transient-autostart.t | 2 +- scripts/domain/060-persistent-lifecycle.t | 2 +- scripts/domain/061-persistent-autostart.t | 2 +- scripts/domain/065-persistent-redefine.t | 2 +- scripts/domain/070-transient-to-persistent.t | 2 +- scripts/domain/080-unique-id-define.t | 2 +- scripts/domain/081-unique-id-create.t | 2 +- scripts/domain/090-invalid-ops-when-inactive.t | 2 +- scripts/domain/100-transient-save-restore.t | 2 +- scripts/domain/101-persistent-save-restore.t | 2 +- scripts/domain/102-broken-save-restore.t | 2 +- scripts/domain/120-disks-stats.t | 2 +- scripts/domain/200-disk-hotplug.t | 2 +- scripts/domain/205-disk-hotplug-ordering.t | 2 +- scripts/domain/210-nic-hotplug.t | 2 +- scripts/domain/215-nic-hotplug-many.t | 2 +- scripts/domain/240-usb-host-hotplug.t | 2 +- scripts/domain/250-pci-host-hotplug.t | 2 +- scripts/qemu/100-disk-encryption.t | 2 +- scripts/storage/100-create-vol-dir.t | 2 +- scripts/storage/200-clone-vol-dir.t | 2 +- 22 files changed, 22 insertions(+), 22 deletions(-) diff --git a/scripts/domain/050-transient-lifecycle.t b/scripts/domain/050-transient-lifecycle.t index 22e5c70..89c9d1a 100644 --- a/scripts/domain/050-transient-lifecycle.t +++ b/scripts/domain/050-transient-lifecycle.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/051-transient-autostart.t b/scripts/domain/051-transient-autostart.t index 9114a28..d43caa1 100644 --- a/scripts/domain/051-transient-autostart.t +++ b/scripts/domain/051-transient-autostart.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/060-persistent-lifecycle.t b/scripts/domain/060-persistent-lifecycle.t index 55bdc6c..ddffa02 100644 --- a/scripts/domain/060-persistent-lifecycle.t +++ b/scripts/domain/060-persistent-lifecycle.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/061-persistent-autostart.t b/scripts/domain/061-persistent-autostart.t index c39ec72..5200454 100644 --- a/scripts/domain/061-persistent-autostart.t +++ b/scripts/domain/061-persistent-autostart.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/065-persistent-redefine.t b/scripts/domain/065-persistent-redefine.t index 712803c..c19b292 100644 --- a/scripts/domain/065-persistent-redefine.t +++ b/scripts/domain/065-persistent-redefine.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/070-transient-to-persistent.t b/scripts/domain/070-transient-to-persistent.t index 346b329..7d85ef6 100644 --- a/scripts/domain/070-transient-to-persistent.t +++ b/scripts/domain/070-transient-to-persistent.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/080-unique-id-define.t b/scripts/domain/080-unique-id-define.t index 066c2e8..ed4a8fc 100644 --- a/scripts/domain/080-unique-id-define.t +++ b/scripts/domain/080-unique-id-define.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/081-unique-id-create.t b/scripts/domain/081-unique-id-create.t index c081674..425116f 100644 --- a/scripts/domain/081-unique-id-create.t +++ b/scripts/domain/081-unique-id-create.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/090-invalid-ops-when-inactive.t b/scripts/domain/090-invalid-ops-when-inactive.t index 28f4936..86f332b 100644 --- a/scripts/domain/090-invalid-ops-when-inactive.t +++ b/scripts/domain/090-invalid-ops-when-inactive.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/100-transient-save-restore.t b/scripts/domain/100-transient-save-restore.t index 314493c..bab42da 100644 --- a/scripts/domain/100-transient-save-restore.t +++ b/scripts/domain/100-transient-save-restore.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/101-persistent-save-restore.t b/scripts/domain/101-persistent-save-restore.t index 251aacd..f1c8d4b 100644 --- a/scripts/domain/101-persistent-save-restore.t +++ b/scripts/domain/101-persistent-save-restore.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/102-broken-save-restore.t b/scripts/domain/102-broken-save-restore.t index 2981d64..b93e274 100644 --- a/scripts/domain/102-broken-save-restore.t +++ b/scripts/domain/102-broken-save-restore.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/120-disks-stats.t b/scripts/domain/120-disks-stats.t index c8b3420..5cbaf8c 100644 --- a/scripts/domain/120-disks-stats.t +++ b/scripts/domain/120-disks-stats.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/200-disk-hotplug.t b/scripts/domain/200-disk-hotplug.t index 1272448..0f10dbf 100644 --- a/scripts/domain/200-disk-hotplug.t +++ b/scripts/domain/200-disk-hotplug.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/205-disk-hotplug-ordering.t b/scripts/domain/205-disk-hotplug-ordering.t index f41d45c..a2e3088 100644 --- a/scripts/domain/205-disk-hotplug-ordering.t +++ b/scripts/domain/205-disk-hotplug-ordering.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/210-nic-hotplug.t b/scripts/domain/210-nic-hotplug.t index 6451fd2..7521978 100644 --- a/scripts/domain/210-nic-hotplug.t +++ b/scripts/domain/210-nic-hotplug.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/215-nic-hotplug-many.t b/scripts/domain/215-nic-hotplug-many.t index 48fdfcf..7465f2c 100644 --- a/scripts/domain/215-nic-hotplug-many.t +++ b/scripts/domain/215-nic-hotplug-many.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/240-usb-host-hotplug.t b/scripts/domain/240-usb-host-hotplug.t index ac71e7b..6e74434 100644 --- a/scripts/domain/240-usb-host-hotplug.t +++ b/scripts/domain/240-usb-host-hotplug.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009-2010 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009-2010 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/domain/250-pci-host-hotplug.t b/scripts/domain/250-pci-host-hotplug.t index 5bb4fd9..a9fe422 100644 --- a/scripts/domain/250-pci-host-hotplug.t +++ b/scripts/domain/250-pci-host-hotplug.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009-2010 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009-2010 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/qemu/100-disk-encryption.t b/scripts/qemu/100-disk-encryption.t index 5964aa5..d594607 100644 --- a/scripts/qemu/100-disk-encryption.t +++ b/scripts/qemu/100-disk-encryption.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/storage/100-create-vol-dir.t b/scripts/storage/100-create-vol-dir.t index 2a09036..3a12596 100644 --- a/scripts/storage/100-create-vol-dir.t +++ b/scripts/storage/100-create-vol-dir.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify diff --git a/scripts/storage/200-clone-vol-dir.t b/scripts/storage/200-clone-vol-dir.t index dbc17c5..3b4d864 100644 --- a/scripts/storage/200-clone-vol-dir.t +++ b/scripts/storage/200-clone-vol-dir.t @@ -1,6 +1,6 @@ # -*- perl -*- # -# Copyright (C) 2009 Red Hat +# Copyright (C) 2009-2010 Red Hat, Inc. # Copyright (C) 2009 Daniel P. Berrange # # This program is free software; You can redistribute it and/or modify -- 1.6.6.1
On Tue, Mar 30, 2010 at 02:35:46PM -0600, Eric Blake wrote:
* scripts/domain/050-transient-lifecycle.t: Correct the copyright line. * scripts/domain/051-transient-autostart.t: Likewise. * scripts/domain/060-persistent-lifecycle.t: Likewise. * scripts/domain/061-persistent-autostart.t: Likewise. * scripts/domain/065-persistent-redefine.t: Likewise. * scripts/domain/070-transient-to-persistent.t: Likewise. * scripts/domain/080-unique-id-define.t: Likewise. * scripts/domain/081-unique-id-create.t: Likewise. * scripts/domain/090-invalid-ops-when-inactive.t: Likewise. * scripts/domain/100-transient-save-restore.t: Likewise. * scripts/domain/101-persistent-save-restore.t: Likewise. * scripts/domain/102-broken-save-restore.t: Likewise. * scripts/domain/120-disks-stats.t: Likewise. * scripts/domain/200-disk-hotplug.t: Likewise. * scripts/domain/205-disk-hotplug-ordering.t: Likewise. * scripts/domain/210-nic-hotplug.t: Likewise. * scripts/domain/215-nic-hotplug-many.t: Likewise. * scripts/domain/240-usb-host-hotplug.t: Likewise. * scripts/domain/250-pci-host-hotplug.t: Likewise. * scripts/qemu/100-disk-encryption.t: Likewise. * scripts/storage/100-create-vol-dir.t: Likewise. * scripts/storage/200-clone-vol-dir.t: Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
This probably counts as trivial, but since this is my first libvirt-tck patch, I thought I'd ask first.
The intent is fine, but most of these scripts have not been touched in 2010, so shouldn't have their copyright date extended Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Daniel P. Berrange wrote:
On Tue, Mar 30, 2010 at 02:35:46PM -0600, Eric Blake wrote:
* scripts/domain/050-transient-lifecycle.t: Correct the copyright line. * scripts/domain/051-transient-autostart.t: Likewise. * scripts/domain/060-persistent-lifecycle.t: Likewise. * scripts/domain/061-persistent-autostart.t: Likewise. * scripts/domain/065-persistent-redefine.t: Likewise. * scripts/domain/070-transient-to-persistent.t: Likewise. * scripts/domain/080-unique-id-define.t: Likewise. * scripts/domain/081-unique-id-create.t: Likewise. * scripts/domain/090-invalid-ops-when-inactive.t: Likewise. * scripts/domain/100-transient-save-restore.t: Likewise. * scripts/domain/101-persistent-save-restore.t: Likewise. * scripts/domain/102-broken-save-restore.t: Likewise. * scripts/domain/120-disks-stats.t: Likewise. * scripts/domain/200-disk-hotplug.t: Likewise. * scripts/domain/205-disk-hotplug-ordering.t: Likewise. * scripts/domain/210-nic-hotplug.t: Likewise. * scripts/domain/215-nic-hotplug-many.t: Likewise. * scripts/domain/240-usb-host-hotplug.t: Likewise. * scripts/domain/250-pci-host-hotplug.t: Likewise. * scripts/qemu/100-disk-encryption.t: Likewise. * scripts/storage/100-create-vol-dir.t: Likewise. * scripts/storage/200-clone-vol-dir.t: Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
This probably counts as trivial, but since this is my first libvirt-tck patch, I thought I'd ask first.
The intent is fine, but most of these scripts have not been touched in 2010, so shouldn't have their copyright date extended
That policy has been changed. Now, it's recommended to update all files once per year, regardless of whether they've been changed in that particular year. http://www.gnu.org/prep/maintain/maintain.html#Copyright-Notices To update the list of year numbers, add each year in which you have made nontrivial changes to the package. (Here we assume you're using a publicly accessible revision control server, so that every revision installed is also immediately and automatically published.) When you add the new year, it is not required to keep track of which files have seen significant changes in the new year and which have not. It is recommended and simpler to add the new year to all files in the package, and be done with it for the rest of the year.
On Wed, Mar 31, 2010 at 12:14:33PM +0200, Jim Meyering wrote:
Daniel P. Berrange wrote:
On Tue, Mar 30, 2010 at 02:35:46PM -0600, Eric Blake wrote:
* scripts/domain/050-transient-lifecycle.t: Correct the copyright line. * scripts/domain/051-transient-autostart.t: Likewise. * scripts/domain/060-persistent-lifecycle.t: Likewise. * scripts/domain/061-persistent-autostart.t: Likewise. * scripts/domain/065-persistent-redefine.t: Likewise. * scripts/domain/070-transient-to-persistent.t: Likewise. * scripts/domain/080-unique-id-define.t: Likewise. * scripts/domain/081-unique-id-create.t: Likewise. * scripts/domain/090-invalid-ops-when-inactive.t: Likewise. * scripts/domain/100-transient-save-restore.t: Likewise. * scripts/domain/101-persistent-save-restore.t: Likewise. * scripts/domain/102-broken-save-restore.t: Likewise. * scripts/domain/120-disks-stats.t: Likewise. * scripts/domain/200-disk-hotplug.t: Likewise. * scripts/domain/205-disk-hotplug-ordering.t: Likewise. * scripts/domain/210-nic-hotplug.t: Likewise. * scripts/domain/215-nic-hotplug-many.t: Likewise. * scripts/domain/240-usb-host-hotplug.t: Likewise. * scripts/domain/250-pci-host-hotplug.t: Likewise. * scripts/qemu/100-disk-encryption.t: Likewise. * scripts/storage/100-create-vol-dir.t: Likewise. * scripts/storage/200-clone-vol-dir.t: Likewise.
Signed-off-by: Eric Blake <eblake@redhat.com> ---
This probably counts as trivial, but since this is my first libvirt-tck patch, I thought I'd ask first.
The intent is fine, but most of these scripts have not been touched in 2010, so shouldn't have their copyright date extended
That policy has been changed. Now, it's recommended to update all files once per year, regardless of whether they've been changed in that particular year.
In that case my personal copyright line should be updated at the same time as updating the Red Hat copyright line :-) Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On 03/31/2010 04:19 AM, Daniel P. Berrange wrote:
The intent is fine, but most of these scripts have not been touched in 2010, so shouldn't have their copyright date extended
That policy has been changed. Now, it's recommended to update all files once per year, regardless of whether they've been changed in that particular year.
In that case my personal copyright line should be updated at the same time as updating the Red Hat copyright line :-)
But if you weren't the one making the changes, then what copyright interest do you have in 2010? You have the original copyright, but by adding it to a Red Hat repository, didn't you effectively transfer copyright ownership of further changes to Red Hat? I'm happy to tweak the patch to drop 2010 from any file not otherwise touched this year, if that's what you want. Or, I can even use gnulib's update-copyright-year script to add 2010 globally; but would that be to just the current holder, or to all previous copyright holders? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 03/31/2010 08:45 AM, Eric Blake wrote:
On 03/31/2010 04:19 AM, Daniel P. Berrange wrote:
The intent is fine, but most of these scripts have not been touched in 2010, so shouldn't have their copyright date extended
That policy has been changed. Now, it's recommended to update all files once per year, regardless of whether they've been changed in that particular year.
In that case my personal copyright line should be updated at the same time as updating the Red Hat copyright line :-)
But if you weren't the one making the changes, then what copyright interest do you have in 2010? You have the original copyright, but by adding it to a Red Hat repository, didn't you effectively transfer copyright ownership of further changes to Red Hat?
I'm happy to tweak the patch to drop 2010 from any file not otherwise touched this year, if that's what you want. Or, I can even use gnulib's update-copyright-year script to add 2010 globally; but would that be to just the current holder, or to all previous copyright holders?
For the record, I've pushed a modified version of the patch that only added the Inc. to the Red Hat copyright lines, without adding 2010 to any file that had not previously been touched this year. That way, we have deferred the debate of whether or not to do global copyright update to another day. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (3)
-
Daniel P. Berrange -
Eric Blake -
Jim Meyering