[PATCH v2 0/6] Use 'download.libvirt.org' on our webpage
Note this patchset now depends on: https://gitlab.com/libvirt/libvirt-java/-/merge_requests/36 The above MR exposes freshly generated javadoc via gitlab pages. v2: - point to freshly generated javadoc - drop ocaml patch - add patch removing libvirt-csharp releases - use pkg.go.dev instead of gitlab Peter Krempa (6): docs: java: Clean up links to source code docs: downloads: Replace 'libvirt.org/sources' by 'download.libvirt.org' spec: Use 'download.libvirt.org' as source server docs: downloads: Drop link to sources of 'consoleproxy' docs: downloads: Don't mention releases directory of libvirt-csharp docs: downloads: Point to pkg.go.dev for go module releases docs/downloads.rst | 38 +++++++++++++++++++------------------- docs/java.rst | 11 +++++------ libvirt.spec.in | 2 +- 3 files changed, 25 insertions(+), 26 deletions(-) -- 2.39.2
- drop the link to the FTP server which doesn't exist any more - change links to libvirt.org/source to download.libvirt.org - change link to the maven repository to point to download.libvirt.org - change link to javadoc to the documentation generated via gitlab job in the libvirt-java project Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- docs/java.rst | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/docs/java.rst b/docs/java.rst index df846c6fc6..4371add37e 100644 --- a/docs/java.rst +++ b/docs/java.rst @@ -16,11 +16,10 @@ Getting it The latest versions of the libvirt Java bindings can be downloaded from: -- `libvirt.org FTP server <ftp://libvirt.org/libvirt/java/>`__ -- `libvirt.org HTTP server <https://libvirt.org/sources/java/>`__ +- `libvirt.org HTTP server <https://download.libvirt.org/java/>`__ -A maven repository is located at https://libvirt.org/maven2/ which you can use -to include this in your maven projects. +A maven repository is located at https://download.libvirt.org/maven2/ which you +can use to include this in your maven projects. GIT source repository --------------------- @@ -68,7 +67,7 @@ become There is of course some functions where the mapping is less direct and using extra classes to map complex arguments. The -`Javadoc <https://libvirt.org/sources/java/javadoc>`__ is available online or as +`Javadoc <https://libvirt.gitlab.io/libvirt-java>`__ is available online or as part of a separate libvirt-java-javadoc package. So let's look at a simple example inspired from the ``test.java`` test found in @@ -123,6 +122,6 @@ pom.xml <repositories> <repository> <id>libvirt-org</id> - <url>https://libvirt.org/maven2</url> + <url>https://download.libvirt.org/maven2</url> </repository> </repositories> -- 2.39.2
On Tue, Mar 14, 2023 at 01:37:32PM +0100, Peter Krempa wrote:
There is of course some functions where the mapping is less direct and using extra classes to map complex arguments. The -`Javadoc <https://libvirt.org/sources/java/javadoc>`__ is available online or as +`Javadoc <https://libvirt.gitlab.io/libvirt-java>`__ is available online or as part of a separate libvirt-java-javadoc package.
I think it'd be perfectly fine to use the v1 version of this hunk, to remove the dependency between this patch series and [1]. Then you can push this change as a follow up, once that MR has been merged. Whichever way you decide to proceed, Reviewed-by: Andrea Bolognani <abologna@redhat.com> [1] https://gitlab.com/libvirt/libvirt-java/-/merge_requests/36 -- Andrea Bolognani / Red Hat / Virtualization
We split off the downloads into a new subdomain. Link directly to it instead of relying on redirects. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com> --- docs/downloads.rst | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index e32fd1ba99..2a02c6a482 100644 --- a/docs/downloads.rst +++ b/docs/downloads.rst @@ -24,7 +24,7 @@ Libvirt - Resources * - libvirt - - `libvirt <https://libvirt.org/sources/>`__ + - `libvirt <https://download.libvirt.org/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt>`__ - `issues <https://gitlab.com/libvirt/libvirt/-/issues>`__ - `github <https://github.com/libvirt/libvirt>`__ @@ -45,7 +45,7 @@ Language bindings - Resources * - C# - - `libvirt <https://libvirt.org/sources/csharp/>`__ + - `libvirt <https://download.libvirt.org/csharp/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-csharp>`__ - `issues <https://gitlab.com/libvirt/libvirt-csharp/-/issues>`__ - `github <https://github.com/libvirt/libvirt-csharp>`__ @@ -59,14 +59,14 @@ Language bindings - `api ref <https://pkg.go.dev/libvirt.org/go/libvirt>`__ * - Java - - `libvirt <https://libvirt.org/sources/java/>`__ + - `libvirt <https://download.libvirt.org/java/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-java>`__ - `issues <https://gitlab.com/libvirt/libvirt-java/-/issues>`__ - `github <https://github.com/libvirt/libvirt-java>`__ - * - OCaml - - `libvirt <https://libvirt.org/sources/ocaml/>`__ + - `libvirt <https://download.libvirt.org/ocaml/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-ocaml>`__ - `issues <https://gitlab.com/libvirt/libvirt-ocaml/-/issues>`__ - `github <https://github.com/libvirt/libvirt-ocaml>`__ @@ -81,14 +81,14 @@ Language bindings `changes <https://libvirt.org/git/?p=libvirt-perl.git;a=blob;f=Changes;hb=HEAD>`__ * - PHP - - `libvirt <https://libvirt.org/sources/php/>`__ + - `libvirt <https://download.libvirt.org/php/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-php>`__ - `issues <https://gitlab.com/libvirt/libvirt-php/-/issues>`__ - `github <https://github.com/libvirt/libvirt-php>`__ - * - Python - - `libvirt <https://libvirt.org/sources/python/>`__ + - `libvirt <https://download.libvirt.org/python/>`__ `pypi <https://pypi.python.org/pypi/libvirt-python>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-python>`__ - `issues <https://gitlab.com/libvirt/libvirt-python/-/issues>`__ @@ -96,7 +96,7 @@ Language bindings - * - Ruby - - `libvirt <https://libvirt.org/sources/ruby/>`__ + - `libvirt <https://download.libvirt.org/ruby/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-ruby>`__ - `issues <https://gitlab.com/libvirt/libvirt-ruby/-/issues>`__ - `github <https://github.com/libvirt/libvirt-ruby>`__ @@ -123,7 +123,7 @@ Integration modules - Resources * - GLib / GConfig / GObject - - `libvirt <https://libvirt.org/sources/glib/>`__ + - `libvirt <https://download.libvirt.org/glib/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-glib>`__ - `issues <https://gitlab.com/libvirt/libvirt-glib/-/issues>`__ - `github <https://github.com/libvirt/libvirt-glib>`__ @@ -137,42 +137,42 @@ Integration modules - `api ref <https://pkg.go.dev/libvirt.org/go/libvirtxml>`__ * - D-Bus - - `libvirt <https://libvirt.org/sources/dbus/>`__ + - `libvirt <https://download.libvirt.org/dbus/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-dbus>`__ - `issues <https://gitlab.com/libvirt/libvirt-dbus/-/issues>`__ - `github <https://github.com/libvirt/libvirt-dbus>`__ - * - Console Proxy - - `libvirt <https://libvirt.org/sources/consoleproxy/>`__ + - `libvirt <https://download.libvirt.org/consoleproxy/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-console-proxy>`__ - `issues <https://gitlab.com/libvirt/libvirt-console-proxy/-/issues>`__ - `github <https://github.com/libvirt/libvirt-console-proxy>`__ - * - CIM provider - - `libvirt <https://libvirt.org/sources/CIM/>`__ + - `libvirt <https://download.libvirt.org/CIM/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-cim>`__ - `issues <https://gitlab.com/libvirt/libvirt-cim/-/issues>`__ - `github <https://github.com/libvirt/libvirt-cim>`__ - * - CIM utils - - `libvirt <https://libvirt.org/sources/CIM/>`__ + - `libvirt <https://download.libvirt.org/CIM/>`__ - `gitlab <https://gitlab.com/libvirt/libcmpiutil>`__ - `issues <https://gitlab.com/libvirt/libcmpiutil/-/issues>`__ - `github <https://github.com/libvirt/libcmpiutil>`__ - * - SNMP - - `libvirt <https://libvirt.org/sources/snmp/>`__ + - `libvirt <https://download.libvirt.org/snmp/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-snmp>`__ - `issues <https://gitlab.com/libvirt/libvirt-snmp/-/issues>`__ - `github <https://github.com/libvirt/libvirt-snmp>`__ - * - Application Sandbox - - `libvirt <https://libvirt.org/sources/sandbox/>`__ + - `libvirt <https://download.libvirt.org/sandbox/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-sandbox>`__ - `issues <https://gitlab.com/libvirt/libvirt-sandbox/-/issues>`__ - `github <https://github.com/libvirt/libvirt-sandbox>`__ @@ -191,7 +191,7 @@ Testing - GIT Mirrors * - TCK - - `libvirt <https://libvirt.org/sources/tck/>`__ + - `libvirt <https://download.libvirt.org/tck/>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-tck>`__ - `issues <https://gitlab.com/libvirt/libvirt-tck/-/issues>`__ - `github <https://github.com/libvirt/libvirt-tck>`__ @@ -252,7 +252,7 @@ Most modules have releases made available for download on the project site via HTTPS. Some modules are instead made available at alternative locations, for example, the Perl binding is made available only on CPAN. -- `libvirt.org HTTPS server <https://libvirt.org/sources/>`__ +- `libvirt.org HTTPS server <https://download.libvirt.org/>`__ Primary release schedule ------------------------ @@ -354,7 +354,7 @@ following key is currently used to generate the GPG signatures: Fingerprint=453B 6531 0595 5628 5547 1199 CA68 BE80 1008 4C9C It can be downloaded from `this -site <https://libvirt.org/sources/gpg_key.asc>`__ or from public GPG key +site <https://download.libvirt.org/gpg_key.asc>`__ or from public GPG key servers. Releases prior to libvirt-6.6 were signed with the following GPG key: -- 2.39.2
Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index e62534c31d..cdca418401 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -236,7 +236,7 @@ URL: https://libvirt.org/ %if %(echo %{version} | grep -q "\.0$"; echo $?) == 1 %define mainturl stable_updates/ %endif -Source: https://libvirt.org/sources/%{?mainturl}libvirt-%{version}.tar.xz +Source: https://download.libvirt.org/%{?mainturl}libvirt-%{version}.tar.xz Requires: libvirt-daemon = %{version}-%{release} Requires: libvirt-daemon-config-network = %{version}-%{release} -- 2.39.2
The directory doesn't exist. The project also doesn't have any releases on gitlab so there's nothing to replace it with. Signed-off-by: Peter Krempa <pkrempa@redhat.com> Reviewed-by: Andrea Bolognani <abologna@redhat.com> --- docs/downloads.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index 2a02c6a482..ecf133f00d 100644 --- a/docs/downloads.rst +++ b/docs/downloads.rst @@ -144,7 +144,7 @@ Integration modules - * - Console Proxy - - `libvirt <https://download.libvirt.org/consoleproxy/>`__ + - - `gitlab <https://gitlab.com/libvirt/libvirt-console-proxy>`__ - `issues <https://gitlab.com/libvirt/libvirt-console-proxy/-/issues>`__ - `github <https://github.com/libvirt/libvirt-console-proxy>`__ -- 2.39.2
The releases directory is empty. Don't advertise it on our downloads page. Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- docs/downloads.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index ecf133f00d..ab63d55c15 100644 --- a/docs/downloads.rst +++ b/docs/downloads.rst @@ -45,7 +45,7 @@ Language bindings - Resources * - C# - - `libvirt <https://download.libvirt.org/csharp/>`__ + - - `gitlab <https://gitlab.com/libvirt/libvirt-csharp>`__ - `issues <https://gitlab.com/libvirt/libvirt-csharp/-/issues>`__ - `github <https://github.com/libvirt/libvirt-csharp>`__ -- 2.39.2
On Tue, Mar 14, 2023 at 01:37:36PM +0100, Peter Krempa wrote:
The releases directory is empty. Don't advertise it on our downloads page.
Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- docs/downloads.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
Currently the 'Releases' column pointed to the generic page about the specific go module. Change the link to point to the respective pkg.go.dev page for the module. Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- docs/downloads.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/downloads.rst b/docs/downloads.rst index ab63d55c15..04aaa5b4eb 100644 --- a/docs/downloads.rst +++ b/docs/downloads.rst @@ -52,7 +52,7 @@ Language bindings - * - Go - - `libvirt <https://libvirt.org/go/libvirt>`__ + - `pkg.go.dev <https://pkg.go.dev/libvirt.org/go/libvirt>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-go-module>`__ - `issues <https://gitlab.com/libvirt/libvirt-go-module/-/issues>`__ - `github <https://github.com/libvirt/libvirt-go-module>`__ @@ -130,7 +130,7 @@ Integration modules - * - Go XML - - `libvirt <https://libvirt.org/go/libvirtxml>`__ + - `pkg.go.dev <https://pkg.go.dev/libvirt.org/go/libvirtxml>`__ - `gitlab <https://gitlab.com/libvirt/libvirt-go-xml-module>`__ - `issues <https://gitlab.com/libvirt/libvirt-go-xml-module/-/issues>`__ - `github <https://github.com/libvirt/libvirt-go-xml-module>`__ -- 2.39.2
On Tue, Mar 14, 2023 at 01:37:37PM +0100, Peter Krempa wrote:
Currently the 'Releases' column pointed to the generic page about the specific go module. Change the link to point to the respective pkg.go.dev page for the module.
Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- docs/downloads.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Andrea Bolognani <abologna@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Peter Krempa