[libvirt] [PATCH v2] tests/Makefile.am: use LIBTOOL variable instead of hardcoded name
Fixes "can't find libtool" error when running valgrind checks. --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 7b93fbde6..923d84ed3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \ --trace-children-skip="*/tools/virsh","*/tests/commandhelper" \ --suppressions=$(srcdir)/.valgrind.supp valgrind: - $(MAKE) check VG="libtool --mode=execute $(VALGRIND)" + $(MAKE) check VG="$(top_srcdir)/libtool --mode=execute $(VALGRIND)" sockettest_SOURCES = \ sockettest.c \ -- 2.11.0
On 05/01/2018 05:34 AM, Maciej Wolny wrote:
Fixes "can't find libtool" error when running valgrind checks.
The subject no longer matches the patch.
--- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b/tests/Makefile.am index 7b93fbde6..923d84ed3 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -487,7 +487,7 @@ VALGRIND = valgrind --quiet --leak-check=full --trace-children=yes \ --trace-children-skip="*/tools/virsh","*/tests/commandhelper" \ --suppressions=$(srcdir)/.valgrind.supp valgrind: - $(MAKE) check VG="libtool --mode=execute $(VALGRIND)" + $(MAKE) check VG="$(top_srcdir)/libtool --mode=execute $(VALGRIND)"
Per your comments on v1, $(LIBTOOL) expands to $(top_srcdir)/libtool (actually, looking at a generated Makefile, it expands to "$(SHELL) $(top_builddir)/libtool", which is even better). Your version 2 thus fails on a VPATH build, and I'd rather see us go with your version 1 with a better commit message. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
participants (2)
-
Eric Blake -
Maciej Wolny