[PATCH] virNetDevOpenvswitchGetVhostuserIfname: Remove a single '\n' from ifname
Ovs-vsctl returns a newline result. Signed-off-by: Yalei Li <liyl43@chinatelecom.cn> --- src/util/virnetdevopenvswitch.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index f9b3369b2a..bd840bd3b7 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -575,6 +575,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path, return 0; } + virStringTrimOptionalNewline(*ifname); if (virNetDevOpenvswitchMaybeUnescapeReply(*ifname) < 0) { VIR_FREE(*ifname); return -1; -- 2.27.0
On 1/22/21 7:26 AM, Yalei Li wrote:
Ovs-vsctl returns a newline result. Signed-off-by: Yalei Li <liyl43@chinatelecom.cn> ---
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
src/util/virnetdevopenvswitch.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c index f9b3369b2a..bd840bd3b7 100644 --- a/src/util/virnetdevopenvswitch.c +++ b/src/util/virnetdevopenvswitch.c @@ -575,6 +575,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path, return 0; }
+ virStringTrimOptionalNewline(*ifname); if (virNetDevOpenvswitchMaybeUnescapeReply(*ifname) < 0) { VIR_FREE(*ifname); return -1;
Thank you. Does this patch need other reviews ? On 1/22/21 7:26 AM, Yalei Li wrote: > Ovs-vsctl returns a newline result. > Signed-off-by: Yalei Li <liyl43@chinatelecom.cn> > --- Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com> > src/util/virnetdevopenvswitch.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/util/virnetdevopenvswitch.c b/src/util/virnetdevopenvswitch.c > index f9b3369b2a..bd840bd3b7 100644 > --- a/src/util/virnetdevopenvswitch.c > +++ b/src/util/virnetdevopenvswitch.c > @@ -575,6 +575,7 @@ virNetDevOpenvswitchGetVhostuserIfname(const char *path, > return 0; > } > > + virStringTrimOptionalNewline(*ifname); > if (virNetDevOpenvswitchMaybeUnescapeReply(*ifname) < 0) { > VIR_FREE(*ifname); > return -1; >
participants (2)
-
Daniel Henrique Barboza -
Yalei Li