[libvirt] [PATCH] maint: avoid 'make syntax-check' from tarball

* .gnulib: update to latest gnulib for maint.mk fixes --- In testing the latest release candidate, I ran 'make syntax-check' out of habit, and it died miserably (even hanging waiting for input on stdin). So I fixed maint.mk upstream: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25340 However, we're so close to the release that I don't know if we want this now, or if we just document that 0.8.8 is the last release where 'make syntax-check' on the tarball is expected to fail. * .gnulib ecb020f...aa0f5d7 (30):
maintainer-makefile: make syntax-check a no-op from tarballs longlong: tune, particularly for common case of c99 getloadavg: set errno getloadavg: omit unused var autoupdate doc: update users.txt Consistent macro naming for macros that use GCC __attribute__. Don't interfere with a program's definition of __attribute__. maint: correct a ChangeLog attribution update from texinfo mbrtowc: Add more tests for native Windows platforms. mbrtowc: Work around native Windows bug. mbsinit: Work around mingw bug. mbsinit: Don't crash for a NULL argument. Don't interfere with a program's definition of __attribute__. Fix last ChangeLog entry. stdlib: don't get in the way of non-GCC __attribute__ quotearg test: Avoid test failure on mingw. setlocale: Prefer gnulib's override over libintl's override. stdlib: support non-GCC __attribute__ wcsrtombs: Work around bug on native Windows. mbsrtowcs: Work around bug on native Windows. Avoid setlocale bugs in tests. Fix ChangeLog entry. setlocale: Workaround native Windows bug. Remove unused test-setlocale1 argument. Tests for module 'setlocale'. New module 'setlocale'. Prepare for locale dependent tests on mingw. Prepare for locale dependent tests on mingw.
.gnulib | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/.gnulib b/.gnulib index ecb020f..aa0f5d7 160000 --- a/.gnulib +++ b/.gnulib @@ -1 +1 @@ -Subproject commit ecb020f2b046790d76d05d377ca1e864e2bc9fdc +Subproject commit aa0f5d7586efe7044f6ca9e07be3f579ee0d5618 -- 1.7.4

On Wed, Feb 16, 2011 at 02:39:30PM -0700, Eric Blake wrote:
* .gnulib: update to latest gnulib for maint.mk fixes ---
In testing the latest release candidate, I ran 'make syntax-check' out of habit, and it died miserably (even hanging waiting for input on stdin). So I fixed maint.mk upstream: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25340
However, we're so close to the release that I don't know if we want this now, or if we just document that 0.8.8 is the last release where 'make syntax-check' on the tarball is expected to fail.
Let's keep as is for 0.8.8 considering the existing amount of testing of rc3 Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/

On 02/16/2011 08:14 PM, Daniel Veillard wrote:
On Wed, Feb 16, 2011 at 02:39:30PM -0700, Eric Blake wrote:
* .gnulib: update to latest gnulib for maint.mk fixes ---
In testing the latest release candidate, I ran 'make syntax-check' out of habit, and it died miserably (even hanging waiting for input on stdin). So I fixed maint.mk upstream: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25340
However, we're so close to the release that I don't know if we want this now, or if we just document that 0.8.8 is the last release where 'make syntax-check' on the tarball is expected to fail.
Let's keep as is for 0.8.8 considering the existing amount of testing of rc3
Assuming this was an ACK for post-release, I've now pushed the patch. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org

On 02/17/2011 01:51 PM, Eric Blake wrote:
On 02/16/2011 08:14 PM, Daniel Veillard wrote:
On Wed, Feb 16, 2011 at 02:39:30PM -0700, Eric Blake wrote:
* .gnulib: update to latest gnulib for maint.mk fixes ---
In testing the latest release candidate, I ran 'make syntax-check' out of habit, and it died miserably (even hanging waiting for input on stdin). So I fixed maint.mk upstream: http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/25340
However, we're so close to the release that I don't know if we want this now, or if we just document that 0.8.8 is the last release where 'make syntax-check' on the tarball is expected to fail.
Let's keep as is for 0.8.8 considering the existing amount of testing of rc3
Assuming this was an ACK for post-release, I've now pushed the patch.
And now I'm glad I waited until post-release; it appears that this gnulib update dragged in some code which broke cross-compilation detection of long long support, so I'm trying to get that resolved upstream in gnulib. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Daniel Veillard
-
Eric Blake