[libvirt] [PATCH] docs: <pre> cannot be nested in <p>
xsltproc complained about this. --- docs/hacking.html.in | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/docs/hacking.html.in b/docs/hacking.html.in index f5ec635..03a1bee 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -128,20 +128,19 @@ <p> For variadic macros, stick with C99 syntax: + </p> <pre> #define vshPrint(_ctl, ...) fprintf(stdout, __VA_ARGS__) </pre> - </p> <p>Use parenthesis when checking if a macro is defined, and use indentation to track nesting: - + </p> <pre> #if defined(HAVE_POSIX_FALLOCATE) && !defined(HAVE_FALLOCATE) # define fallocate(a,ignored,b,c) posix_fallocate(a,b,c) #endif </pre> - </p> <h2><a href="types">C types</a></h2> @@ -552,9 +551,11 @@ also rebuild locally, run 'make check syntax-check', and make sure you don't raise errors. Try to look for warnings too; for example, configure with + </p> <pre> --enable-compile-warnings=error </pre> + <p> which adds -Werror to compile flags, so no warnings get missed </p> -- 1.6.3.3
On 03/13/2010 07:09 AM, Matthias Bolte wrote:
xsltproc complained about this. --- docs/hacking.html.in | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in index f5ec635..03a1bee 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -128,20 +128,19 @@
<p> For variadic macros, stick with C99 syntax: + </p> <pre> #define vshPrint(_ctl, ...) fprintf(stdout, __VA_ARGS__) </pre> - </p>
ACK. My bad; how do you run xsltproc to catch this, so I don't repeat? -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
2010/3/17 Eric Blake <eblake@redhat.com>:
On 03/13/2010 07:09 AM, Matthias Bolte wrote:
xsltproc complained about this. --- docs/hacking.html.in | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/docs/hacking.html.in b/docs/hacking.html.in index f5ec635..03a1bee 100644 --- a/docs/hacking.html.in +++ b/docs/hacking.html.in @@ -128,20 +128,19 @@
<p> For variadic macros, stick with C99 syntax: + </p> <pre> #define vshPrint(_ctl, ...) fprintf(stdout, __VA_ARGS__) </pre> - </p>
ACK. My bad; how do you run xsltproc to catch this, so I don't repeat?
Thanks, pushed. xsltproc is run by the Makefile in the docs directory to generate the .html files from the .html.in files. But such issues don't result in fatal errors so you probably don't notice it if you don't have a close look at all the shell when you run make. Try running rm docs/hacking.html && make to see [...] Generating hacking.html.tmp hacking.html.in:134: HTML parser error : Unexpected end tag : p </p> ^ hacking.html.in:144: HTML parser error : Unexpected end tag : p </p> ^ hacking.html.in:559: HTML parser error : Unexpected end tag : p </p> ^ Validating hacking.html [...] Matthias
participants (2)
-
Eric Blake -
Matthias Bolte