[libvirt] [PATCH 0/1] bug: fixup USB input bus check
There's one explicit bug(introduced in commit:317badb) when checking the bus of one input device is USB. Let's fix it. Xiao Feng Ren (1): Fixup USB input bus check src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.16.3
Signed-off-by: Xiao Feng Ren <renxiaof@linux.vnet.ibm.com> --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 27e2bd50eb..e4d39c06e8 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -27878,7 +27878,7 @@ virDomainDeviceIsUSB(virDomainDeviceDefPtr dev) if ((t == VIR_DOMAIN_DEVICE_DISK && dev->data.disk->bus == VIR_DOMAIN_DISK_BUS_USB) || (t == VIR_DOMAIN_DEVICE_INPUT && - dev->data.input->type == VIR_DOMAIN_INPUT_BUS_USB) || + dev->data.input->bus == VIR_DOMAIN_INPUT_BUS_USB) || (t == VIR_DOMAIN_DEVICE_HOSTDEV && dev->data.hostdev->mode == VIR_DOMAIN_HOSTDEV_MODE_SUBSYS && dev->data.hostdev->source.subsys.type == -- 2.16.3
On Thu, May 31, 2018 at 09:55:38AM +0200, Xiao Feng Ren wrote:
There's one explicit bug(introduced in commit:317badb) when checking the bus of one input device is USB. Let's fix it.
The fix looks good to me, but the explanation (which is not really and the mention of the commit that broke it should be a part of the commit message, not the cover letter. (Also, a cover letter is not required for single patches) Jano
Xiao Feng Ren (1): Fixup USB input bus check
src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
-- 2.16.3
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 5/31/2018 4:21 PM, Ján Tomko wrote:
On Thu, May 31, 2018 at 09:55:38AM +0200, Xiao Feng Ren wrote:
There's one explicit bug(introduced in commit:317badb) when checking the bus of one input device is USB. Let's fix it.
The fix looks good to me, but the explanation (which is not really and the mention of the commit that broke it should be a part of the commit message, not the cover letter.
(Also, a cover letter is not required for single patches)
Jano
Ok, will modify.
Xiao Feng Ren (1): Fixup USB input bus check
src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
-- 2.16.3
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Ján Tomko -
Xiao Feng Ren