[libvirt] [PATCH] tests: Update valgrind suppressions file
--- tests/.valgrind.supp | 58 +++++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 51 insertions(+), 7 deletions(-) diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index 4af10b1..68cfa0c 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -258,14 +258,58 @@ Memcheck:Param capget(data) fun:capget + fun:* fun:capng_clear + fun:virClearCapabilities fun:__virExec fun:virExecWithHook - fun:virExec - fun:qemudProbeMachineTypes - fun:qemudCapsInitGuest - fun:qemudCapsInit - fun:qemudStartup - fun:virStateInitialize - fun:main +} +{ + libnlMemoryLeak1 + Memcheck:Leak + fun:malloc + fun:strdup + obj:/usr/lib/libnl.so.1.1 +} +{ + libnlMemoryLeak2 + Memcheck:Leak + fun:calloc + obj:/usr/lib/libnl.so.1.1 +} +{ + libselinuxMemoryLeak1 + Memcheck:Leak + fun:malloc + fun:getdelim + obj:/lib/libselinux.so.1 +} +{ + dashMemoryLeak1 + Memcheck:Leak + fun:malloc + obj:/bin/dash +} +{ + dashMemoryLeak2 + Memcheck:Leak + fun:malloc + fun:strdup + obj:/bin/dash +} +{ + vboxMemoryLeak1 + Memcheck:Leak + ... + fun:VBoxNsxpNS_InitXPCOM2 +} +{ + libnetcfMemoryLeak1 + fun:malloc + fun:xmlStrndup + fun:xmlHashUpdateEntry3 + fun:* + fun:xsltRegisterAllExtras + fun:drv_init + fun:interfaceOpenInterface } -- 1.7.0.4
On 04/30/2011 05:13 AM, Matthias Bolte wrote:
--- tests/.valgrind.supp | 58 +++++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 51 insertions(+), 7 deletions(-)
diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index 4af10b1..68cfa0c 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -258,14 +258,58 @@ Memcheck:Param capget(data) fun:capget + fun:* fun:capng_clear + fun:virClearCapabilities fun:__virExec fun:virExecWithHook - fun:virExec
Makes sense.
+{ + libnlMemoryLeak1 + Memcheck:Leak + fun:malloc + fun:strdup + obj:/usr/lib/libnl.so.1.1 +}
Nice. It would be nicer if these other programs plugged their leaks, but doing this makes it easier to find just the libvirt leaks. ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
2011/4/30 Eric Blake <eblake@redhat.com>:
On 04/30/2011 05:13 AM, Matthias Bolte wrote:
--- tests/.valgrind.supp | 58 +++++++++++++++++++++++++++++++++++++++++++------ 1 files changed, 51 insertions(+), 7 deletions(-)
diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index 4af10b1..68cfa0c 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -258,14 +258,58 @@ Memcheck:Param capget(data) fun:capget + fun:* fun:capng_clear + fun:virClearCapabilities fun:__virExec fun:virExecWithHook - fun:virExec
Makes sense.
+{ + libnlMemoryLeak1 + Memcheck:Leak + fun:malloc + fun:strdup + obj:/usr/lib/libnl.so.1.1 +}
Nice. It would be nicer if these other programs plugged their leaks, but doing this makes it easier to find just the libvirt leaks.
well, the world isn't perfect and for example the VBoxNsxpNS_InitXPCOM2 suppression probably isn't a real leak, it's just initializing tons of global stuff that later on isn't freed and leaks on purpose. But this clutters valgrind's output massively.
ACK.
Thanks, pushed. Matthias
* tests/.valgrind.supp: Consolidate bash suppressions. Ignore more libnl issues. --- Matthias tested on a debian-based system; I found more issues when testing on Fedora 14. With this in place, I had a silent run of 'make -C tests valgrind'. Shouldn't be a problem applying this before 0.9.1 if it gets acks. tests/.valgrind.supp | 72 +++++-------------------------------------------- 1 files changed, 8 insertions(+), 64 deletions(-) diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index 68cfa0c..7190103 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -3,15 +3,7 @@ Memcheck:Leak fun:malloc fun:xmalloc - fun:set_signal - fun:trap_builtin - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:parse_and_execute - obj:/bin/bash - fun:source_file - fun:source_builtin + ... obj:/bin/bash } { @@ -19,61 +11,6 @@ Memcheck:Leak fun:malloc fun:xmalloc - fun:make_command - fun:yyparse - fun:parse_command - fun:read_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak3 - Memcheck:Leak - fun:malloc - fun:xmalloc - obj:/bin/bash - fun:execute_command_internal - obj:/bin/bash - fun:execute_command_internal - fun:execute_command_internal - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:parse_and_execute - fun:command_substitute -} -{ - bashMemoryLeak4 - Memcheck:Leak - fun:malloc - fun:xmalloc - fun:make_bare_simple_command - fun:make_simple_command - fun:yyparse - fun:parse_command - fun:read_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak5 - Memcheck:Leak - fun:malloc - fun:xmalloc - fun:set_signal - fun:trap_builtin - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:execute_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak6 - Memcheck:Leak - fun:malloc - fun:xmalloc fun:make_bare_simple_command fun:make_simple_command fun:yyparse @@ -278,6 +215,13 @@ obj:/usr/lib/libnl.so.1.1 } { + libnlMemoryLeak3 + Memcheck:Leak + fun:?alloc + ... + obj:/lib64/libnl.so.1.1 +} +{ libselinuxMemoryLeak1 Memcheck:Leak fun:malloc -- 1.7.4.4
On Mon, May 02, 2011 at 04:56:53PM -0600, Eric Blake wrote:
* tests/.valgrind.supp: Consolidate bash suppressions. Ignore more libnl issues. ---
Matthias tested on a debian-based system; I found more issues when testing on Fedora 14. With this in place, I had a silent run of 'make -C tests valgrind'.
Shouldn't be a problem applying this before 0.9.1 if it gets acks.
tests/.valgrind.supp | 72 +++++-------------------------------------------- 1 files changed, 8 insertions(+), 64 deletions(-)
diff --git a/tests/.valgrind.supp b/tests/.valgrind.supp index 68cfa0c..7190103 100644 --- a/tests/.valgrind.supp +++ b/tests/.valgrind.supp @@ -3,15 +3,7 @@ Memcheck:Leak fun:malloc fun:xmalloc - fun:set_signal - fun:trap_builtin - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:parse_and_execute - obj:/bin/bash - fun:source_file - fun:source_builtin + ... obj:/bin/bash } { @@ -19,61 +11,6 @@ Memcheck:Leak fun:malloc fun:xmalloc - fun:make_command - fun:yyparse - fun:parse_command - fun:read_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak3 - Memcheck:Leak - fun:malloc - fun:xmalloc - obj:/bin/bash - fun:execute_command_internal - obj:/bin/bash - fun:execute_command_internal - fun:execute_command_internal - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:parse_and_execute - fun:command_substitute -} -{ - bashMemoryLeak4 - Memcheck:Leak - fun:malloc - fun:xmalloc - fun:make_bare_simple_command - fun:make_simple_command - fun:yyparse - fun:parse_command - fun:read_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak5 - Memcheck:Leak - fun:malloc - fun:xmalloc - fun:set_signal - fun:trap_builtin - obj:/bin/bash - obj:/bin/bash - fun:execute_command_internal - fun:execute_command - fun:reader_loop - fun:main -} -{ - bashMemoryLeak6 - Memcheck:Leak - fun:malloc - fun:xmalloc fun:make_bare_simple_command fun:make_simple_command fun:yyparse @@ -278,6 +215,13 @@ obj:/usr/lib/libnl.so.1.1 } { + libnlMemoryLeak3 + Memcheck:Leak + fun:?alloc + ... + obj:/lib64/libnl.so.1.1 +} +{ libselinuxMemoryLeak1 Memcheck:Leak fun:malloc
Okay, go for it, ACK, please push Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On 05/02/2011 09:36 PM, Daniel Veillard wrote:
On Mon, May 02, 2011 at 04:56:53PM -0600, Eric Blake wrote:
* tests/.valgrind.supp: Consolidate bash suppressions. Ignore more libnl issues. ---
Matthias tested on a debian-based system; I found more issues when testing on Fedora 14. With this in place, I had a silent run of 'make -C tests valgrind'.
Okay, go for it, ACK, please push
Thanks; pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (3)
-
Daniel Veillard -
Eric Blake -
Matthias Bolte