[Libvir] [PATCH] virsh dumpxml and create fails with no UNAME cdrom device
Hi, In the xmexample.hvm(/etc/xen/xmexample.hvm), no UNAME cdrom device is written. disk = [ 'file:/var/images/min-el3-i386.img,hda,w', ',hdc:cdrom,r' ] But virsh dumpxml fails if the domain has virtual cdrom device without UNAME. And virsh create fails if the domain config XML has no UNAME cdrom device, too. The attached patch adds to solve this problem. Signed-off-by: Nobuhiro Itou <fj0873gn@aa.jp.fujitsu.com> Thanks, Nobuhiro Itou.
On Fri, Apr 06, 2007 at 11:53:36AM +0900, Nobuhiro Itou wrote:
Hi,
In the xmexample.hvm(/etc/xen/xmexample.hvm), no UNAME cdrom device is written. disk = [ 'file:/var/images/min-el3-i386.img,hda,w', ',hdc:cdrom,r' ]
But virsh dumpxml fails if the domain has virtual cdrom device without UNAME. And virsh create fails if the domain config XML has no UNAME cdrom device, too.
The attached patch adds to solve this problem.
Hum, this would be clearer if you could gave the XML and sexpr format for such an example, that would also allow to add it to the regression tests in tests/sexpr2xmldata and tests/xml2sexprdata . Ideally every change to the conversion routines should be added to the regression tests suite to help stabilizing the behaviour over long term. Could you provide this ? thanks in advance, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
Hi, Daniel
Hum, this would be clearer if you could gave the XML and sexpr format for such an example, that would also allow to add it to the regression tests in tests/sexpr2xmldata and tests/xml2sexprdata . Ideally every change to the conversion routines should be added to the regression tests suite to help stabilizing the behaviour over long term.
Could you provide this ?
All right, I would give you the XML and sexpr data. Thanks, Nobuhiro Itou.
On Fri, Apr 06, 2007 at 06:41:51PM +0900, Nobuhiro Itou wrote:
Hi, Daniel
Hum, this would be clearer if you could gave the XML and sexpr format for such an example, that would also allow to add it to the regression tests in tests/sexpr2xmldata and tests/xml2sexprdata . Ideally every change to the conversion routines should be added to the regression tests suite to help stabilizing the behaviour over long term.
Could you provide this ?
All right, I would give you the XML and sexpr data.
Okay, after making the changes needed to integrate them in the regression tests I commited the patch and tests to CVS, thanks a lot, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel Veillard -
Nobuhiro Itou