On Thu, Jul 19, 2007 at 09:01:36AM -0400, Daniel Veillard wrote:
On Thu, Jul 19, 2007 at 06:24:57PM +0530, Shuveb Hussain wrote:
> Hi,
>
> Here are some cleanups as per discussions on the list:
>
> Change log:
> * Make sure we are running on OpenVZ enebled kernel in the driver open()
> method
> * Some minor macro cleanups
> * Use generic UUID parsing rather than own and scanf()
okay, I changed the generation function yesterday, using virUUIDGenerate()
if you noticed.
> * Made private functions static
> * New files utils.[c,h] added that have 2 functions virExec and
> virExecNonBlock
> * Removed popen and used virExec in openvz_driver.c
> * qemu_driver.c updated to use new virExecNonBlock() functions instead
> of qemudExec, which is removed
Will check :-)
Okay, checked, this looks just what Dan and I suggested, so I applied
both patches, added src/util.[ch] and commited.
thanks a lot !
Daniel
--
Red Hat Virtualization group
http://redhat.com/virtualization/
Daniel Veillard | virtualization library
http://libvirt.org/
veillard(a)redhat.com | libxml GNOME XML XSLT toolkit
http://xmlsoft.org/
http://veillard.com/ | Rpmfind RPM search engine
http://rpmfind.net/