[libvirt] [PATCH v2] docs: mention bhyve SATA address changes in news.xml

--- docs/news.xml | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index f408293a1..7990cc6d4 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -56,6 +56,25 @@ a fabric name has been removed by making it optional. </description> </change> + <change> + <summary> + bhyve: change address allocation schema for SATA disks + </summary> + <description> + Previously, the bhyve driver assigned PCI addresses to SATA disks + directly rather than assigning that to a controller and + using SATA addresses for disks. It was implemented this way + because bhyve has no notion of an explicit SATA controller. + However, as this doesn't match libvirt's understanding of + disk addresses, it was changed for the bhyve driver + to follow the common schema and have PCI addresses + for SATA controllers and SATA addresses for disks. If you're + having issues because of this, it's recommended to edit + the domain's XML and remove <address type='pci'> + from the <disk> elements with <target bus='sata'/> + and let libvirt regenerate it properly. + </description> + </change> </section> </release> <release version="v3.0.0" date="2017-01-17"> -- 2.11.0

On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote: [...]
+ However, as this doesn't match libvirt's understanding of + disk addresses, it was changed for the bhyve driver
"it was changed for the bhyve driver" → "the bhyve driver was changed" Sorry for not catching it the first time around :/ ACK with that fixed. -- Andrea Bolognani / Red Hat / Virtualization

Andrea Bolognani wrote:
On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote: [...]
+ However, as this doesn't match libvirt's understanding of + disk addresses, it was changed for the bhyve driver
"it was changed for the bhyve driver" → "the bhyve driver was changed"
Sorry for not catching it the first time around :/
ACK with that fixed.
Thanks, I've included this change as well. I'm not sure if it's better to push it right now or wait for https://www.redhat.com/archives/libvir-list/2017-February/msg00012.html to get reviewed, because the bhyve driver as it is now is not completely fixed (the patch I mentioned fixes virtio devices), so if it happens that this patch won't get into the upcoming release, it'd be at least a little less awkward not to claim everything's fixed... Roman Bogorodskiy

Andrea Bolognani wrote:
On Mon, 2017-02-06 at 21:49 +0400, Roman Bogorodskiy wrote: [...]
+ However, as this doesn't match libvirt's understanding of + disk addresses, it was changed for the bhyve driver
"it was changed for the bhyve driver" → "the bhyve driver was changed"
Sorry for not catching it the first time around :/
ACK with that fixed.
Pushed with this fix included, thanks! Roman Bogorodskiy
participants (2)
-
Andrea Bolognani
-
Roman Bogorodskiy