[libvirt] building failed
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ============================== The command convert does not exist. Which package should I install? PS: I find another command fig2dev can convert *.fig to *.png. Thanks Wen Congyang
I think you can install the package gif2png. On Mon, 2011-10-31 at 10:01 +0800, Wen Congyang wrote:
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ==============================
The command convert does not exist. Which package should I install?
PS: I find another command fig2dev can convert *.fig to *.png.
Thanks Wen Congyang
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
________________________________ This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you. 本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确的收件人，请您立即删除本邮件。请不要将本电邮进行复制并用作任何其他用途、或透露本邮件之内容。谢谢。
At 10/31/2011 10:14 AM, lingjiao.lc Write:
I think you can install the package gif2png.
This package does not exist on both RHEL6 and Fedora15-beta. I use google to search it, and read the man page for gif2png. This command can convert *.git to *.png. But we need to convert *.fig to *.png Thanks Wen Congyang.
On Mon, 2011-10-31 at 10:01 +0800, Wen Congyang wrote:
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ==============================
The command convert does not exist. Which package should I install?
PS: I find another command fig2dev can convert *.fig to *.png.
Thanks Wen Congyang
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
________________________________
This email (including any attachments) is confidential and may be legally privileged. If you received this email in error, please delete it immediately and do not copy it or use it for any purpose or disclose its contents to any other person. Thank you.
本电邮(包括任何附件)可能含有机密资料并受法律保护。如您不是正确的收件人，请您立即删除本邮件。请不要将本电邮进行复制并用作任何其他用途、或透露本邮件之内容。谢谢。
On 10/30/2011 08:25 PM, Wen Congyang wrote:
At 10/31/2011 10:14 AM, lingjiao.lc Write:
I think you can install the package gif2png.
This package does not exist on both RHEL6 and Fedora15-beta.
I use google to search it, and read the man page for gif2png. This command can convert *.git to *.png. But we need to convert *.fig to *.png
convert is part of ImageMagick. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
于 2011年10月31日 10:01, Wen Congyang 写道:
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ==============================
The command convert does not exist. Which package should I install?
The package should be ImageMagick. I have played convert when converting my photos. :) Regards Osier
At 10/31/2011 11:18 AM, Osier Yang Write:
于 2011年10月31日 10:01, Wen Congyang 写道:
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ==============================
The command convert does not exist. Which package should I install?
The package should be ImageMagick. I have played convert when converting my photos. :)
Yes, the package ImageMagick provides the command convert. I will try it. Thank you very much. Wen Congyang
Regards Osier
On Mon, Oct 31, 2011 at 10:01:16AM +0800, Wen Congyang wrote:
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ==============================
Hmm, this is an unintended consequence of me removing trailing whitespace from the docs/*.fig files. It seems that make now considers the corresponding png files to be out of date. Is it possible to just update the timestamp on the png files in GIT, or should I just re-create the pngs and commit them again. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 10/31/2011 05:00 AM, Daniel P. Berrange wrote:
On Mon, Oct 31, 2011 at 10:01:16AM +0800, Wen Congyang wrote:
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ==============================
Hmm, this is an unintended consequence of me removing trailing whitespace from the docs/*.fig files. It seems that make now considers the corresponding png files to be out of date. Is it possible to just update the timestamp on the png files in GIT, or should I just re-create the pngs and commit them again.
Git only updates timestamps on png files if they change in content from the previous release. Either we make 'convert' a pre-req to building the package, or we have to rewrite the Makefile rules to gracefully fall back to use 'touch' if 'convert' is not present (similar to how we gracefully fall back if tools to generate html files are not present). I'm in favor of the latter. Also, if it helps, we can exempt the .fig files from the git whitespace hooks (is this a case of the normal tools for modifying fig files generating the trailing space by default?). -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On Mon, Oct 31, 2011 at 10:52:14AM -0600, Eric Blake wrote:
On 10/31/2011 05:00 AM, Daniel P. Berrange wrote:
On Mon, Oct 31, 2011 at 10:01:16AM +0800, Wen Congyang wrote:
When I try to build libvirt, I meet the following error messages: ============================== Generating internals/rpc.html.tmp Validating internals/rpc.html GEN libvirt-api.xml GEN html/index.html GEN devhelp/libvirt.devhelp convert -rotate 90 libvirt-net-logical.fig libvirt-net-logical.png make[1]: convert: Command not found make[1]: *** [libvirt-net-logical.png] Error 127 ==============================
Hmm, this is an unintended consequence of me removing trailing whitespace from the docs/*.fig files. It seems that make now considers the corresponding png files to be out of date. Is it possible to just update the timestamp on the png files in GIT, or should I just re-create the pngs and commit them again.
Git only updates timestamps on png files if they change in content from the previous release.
Either we make 'convert' a pre-req to building the package, or we have to rewrite the Makefile rules to gracefully fall back to use 'touch' if 'convert' is not present (similar to how we gracefully fall back if tools to generate html files are not present). I'm in favor of the latter.
Trouble is we don't want everyone who does have 'convert' to be constantly dirtying the png files. So sounds like I just need to re-create the PNGs - merely twiddling a bit in the PNG text comment field will trick GIT into thinking they've changed
Also, if it helps, we can exempt the .fig files from the git whitespace hooks (is this a case of the normal tools for modifying fig files generating the trailing space by default?).
Yeah, xfig leaves a bogus trailing whitespace on 1 line in the file Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 10/31/2011 11:04 AM, Daniel P. Berrange wrote:
Trouble is we don't want everyone who does have 'convert' to be constantly dirtying the png files. So sounds like I just need to re-create the PNGs - merely twiddling a bit in the PNG text comment field will trick GIT into thinking they've changed
Do you get identical png files with consecutive runs of convert, or do the contents of the binary files differ with a rerun? [/me tries it...] They differ - probably a timestamp, at a minimum. And the time to fire up the first convert is non-trivial (it gets better on subsequent runs, due to caching, but .25 seconds on my machine is still noticeable). It almost sounds like we want the rules to generate the .png to NOT be present during a normal build, but to be something that a maintainer has to consciously rerun.
Also, if it helps, we can exempt the .fig files from the git whitespace hooks (is this a case of the normal tools for modifying fig files generating the trailing space by default?).
Yeah, xfig leaves a bogus trailing whitespace on 1 line in the file
Have you reported a bug against xfig? At any rate, since xfig is the preferred editor, it seems like we are probably better off providing the exemption than having to manually clean up after xfig every time we touch the .fig files, since those are the preferred source file format for our binary pngs. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (5)
-
Daniel P. Berrange -
Eric Blake -
lingjiao.lc -
Osier Yang -
Wen Congyang