[libvirt] [PATCH libvirt-python 0/2] fix build dependency & increment version
Although they're trivial and one is a build breaker, I haven't pushed either in case I've made incorrect assumptions about something. Laine Stump (2): build: add BuildRequires for python-lxml and python3-lxml increment version post-release libvirt-python.spec.in | 2 ++ setup.py | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 1.9.0
python-lxml is likely always already present anyway (due to so many packages being dependent on it), but at least on my F20 system, python3-lxml wasn't installed, leading to a failure of "python setup.py rpm" without an informative error message. --- libvirt-python.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 25d22cd..b51571e 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -15,9 +15,11 @@ Group: Development/Libraries BuildRequires: libvirt-devel >= @C_VERSION@ BuildRequires: python-devel BuildRequires: python-nose +BuildRequires: python-lxml %if %{with_python3} BuildRequires: python3-devel BuildRequires: python3-nose +BuildRequires: python3-lxml %endif %if %{with_python3} -- 1.9.0
On Mon, Apr 07, 2014 at 02:30:51PM +0300, Laine Stump wrote:
python-lxml is likely always already present anyway (due to so many packages being dependent on it), but at least on my F20 system, python3-lxml wasn't installed, leading to a failure of "python setup.py rpm" without an informative error message. --- libvirt-python.spec.in | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/libvirt-python.spec.in b/libvirt-python.spec.in index 25d22cd..b51571e 100644 --- a/libvirt-python.spec.in +++ b/libvirt-python.spec.in @@ -15,9 +15,11 @@ Group: Development/Libraries BuildRequires: libvirt-devel >= @C_VERSION@ BuildRequires: python-devel BuildRequires: python-nose +BuildRequires: python-lxml %if %{with_python3} BuildRequires: python3-devel BuildRequires: python3-nose +BuildRequires: python3-lxml %endif
%if %{with_python3}
ACK, just tested a scratch buildin fedora which confirms this fix is needed. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
As is now done with libvirt. git head will always have the version number of the expected *next* release. --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/setup.py b/setup.py index 44ebcf7..f4c05ca 100755 --- a/setup.py +++ b/setup.py @@ -309,7 +309,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists() setup(name = 'libvirt-python', - version = '1.2.3', + version = '1.2.4', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list@redhat.com', -- 1.9.0
On Mon, Apr 07, 2014 at 02:30:52PM +0300, Laine Stump wrote:
As is now done with libvirt. git head will always have the version number of the expected *next* release. --- setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.py b/setup.py index 44ebcf7..f4c05ca 100755 --- a/setup.py +++ b/setup.py @@ -309,7 +309,7 @@ class my_clean(clean): _c_modules, _py_modules = get_module_lists()
setup(name = 'libvirt-python', - version = '1.2.3', + version = '1.2.4', url = 'http://www.libvirt.org', maintainer = 'Libvirt Maintainers', maintainer_email = 'libvir-list@redhat.com',
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (2)
-
Daniel P. Berrange -
Laine Stump