[libvirt] [PATCH] Improve some debugging log messages in LXC mount setup

Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_container.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index f5b0bc6..8fbbc0d 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -556,8 +556,9 @@ static int lxcContainerMountBasicFS(bool pivotRoot, srcpath, mnts[i].dst, mnts[i].type, mnts[i].mflags, mnts[i].opts); if (mount(srcpath, mnts[i].dst, mnts[i].type, mnts[i].mflags, mnts[i].opts) < 0) { virReportSystemError(errno, - _("Failed to mount %s on %s type %s"), - mnts[i].src, mnts[i].dst, NULLSTR(mnts[i].type)); + _("Failed to mount %s on %s type %s flags=%d opts=%s"), + srcpath, mnts[i].dst, NULLSTR(mnts[i].type), + mnts[i].mflags, NULLSTR(mnts[i].opts)); goto cleanup; } } @@ -579,8 +580,8 @@ static int lxcContainerMountBasicFS(bool pivotRoot, MS_NOSUID, opts); if (mount("devfs", "/dev", "tmpfs", MS_NOSUID, opts) < 0) { virReportSystemError(errno, - _("Failed to mount %s on %s type %s"), - "devfs", "/dev", "tmpfs"); + _("Failed to mount %s on %s type %s (%s)"), + "devfs", "/dev", "tmpfs", opts); goto cleanup; } } -- 1.7.1

On 09/18/2012 05:29 AM, Daniel P. Berrange wrote:
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_container.c | 9 +++++---- 1 files changed, 5 insertions(+), 4 deletions(-)
ACK. Safe for 0.10.2 -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Daniel P. Berrange
-
Eric Blake