[libvirt] [PATCH] cpu: add ABM to Haswell* and Broadwell* CPU models
Corresponding QEMU commits: becb66673ec30cb604926d247ab9449a60ad8b11 Signed-off-by: Eli Qiao <liyong.qiao@intel.com> --- src/cpu/cpu_map.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/cpu/cpu_map.xml b/src/cpu/cpu_map.xml index 0b6d424..d9eb729 100644 --- a/src/cpu/cpu_map.xml +++ b/src/cpu/cpu_map.xml @@ -919,6 +919,7 @@ <model name='Haswell-noTSX'> <vendor name='Intel'/> + <feature name='abm'/> <feature name='aes'/> <feature name='apic'/> <feature name='avx'/> @@ -971,6 +972,7 @@ <model name='Haswell'> <vendor name='Intel'/> + <feature name='abm'/> <feature name='aes'/> <feature name='apic'/> <feature name='avx'/> @@ -1026,6 +1028,7 @@ <model name='Broadwell-noTSX'> <vendor name='Intel'/> <feature name='3dnowprefetch'/> + <feature name='abm'/> <feature name='adx'/> <feature name='aes'/> <feature name='apic'/> @@ -1082,6 +1085,7 @@ <model name='Broadwell'> <vendor name='Intel'/> <feature name='3dnowprefetch'/> + <feature name='abm'/> <feature name='adx'/> <feature name='aes'/> <feature name='apic'/> -- 1.9.1
On Fri, May 06, 2016 at 17:53:04 +0800, Eli Qiao wrote:
Corresponding QEMU commits: becb66673ec30cb604926d247ab9449a60ad8b11
Signed-off-by: Eli Qiao <liyong.qiao@intel.com> --- src/cpu/cpu_map.xml | 4 ++++ 1 file changed, 4 insertions(+)
NACK. We don't add features to models since it could break existing setups. In any case, presence of any flag in CPU models does not really influence whether that flag is going to be provided to a guest. That part is driven by QEMU. Jirka
Hi jiri, Thanks for you kindly reviewing, I wonder what cpu/cpu_map.xml does in libvirt if QEMU already provide all features to guest? Best Regards, Qiao, Liyong (Eli) OTC SSG Intel ------------------------------------------------ 此致 敬礼！ 英特尔（中国）有限公司软件与服务部开源技术中心 乔立勇 -----Original Message----- From: Jiri Denemark [mailto:jdenemar@redhat.com] Sent: Friday, May 06, 2016 6:56 PM To: Qiao, Liyong <liyong.qiao@intel.com> Cc: libvir-list@redhat.com Subject: Re: [libvirt] [PATCH] cpu: add ABM to Haswell* and Broadwell* CPU models On Fri, May 06, 2016 at 17:53:04 +0800, Eli Qiao wrote: > Corresponding QEMU commits: > becb66673ec30cb604926d247ab9449a60ad8b11 > > Signed-off-by: Eli Qiao <liyong.qiao@intel.com> > --- > src/cpu/cpu_map.xml | 4 ++++ > 1 file changed, 4 insertions(+) NACK. We don't add features to models since it could break existing setups. In any case, presence of any flag in CPU models does not really influence whether that flag is going to be provided to a guest. That part is driven by QEMU. Jirka
participants (3)
-
Eli Qiao -
Jiri Denemark -
Qiao, Liyong