[libvirt] [PATCH] netdev: fix build on non-Linux
Fix some typos in the source code: - Missplaced ")", - virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and syntax-checking failing, so I cannot do a complete test build. src/util/virnetdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virnetdev.c b/src/util/virnetdev.c index 598d1c61a..47e2b20d5 100644 --- a/src/util/virnetdev.c +++ b/src/util/virnetdev.c @@ -316,7 +316,7 @@ virNetDevSetMACInternal(const char *ifname, ret = 0; cleanup: - VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1), + VIR_DEBUG("SIOCSIFLLADDR %s MAC=%s - %s", ifname, mac + 1, ret < 0 ? "Fail" : "Success"); VIR_FORCE_CLOSE(s); @@ -2336,7 +2336,7 @@ virNetDevReadNetConfig(const char *linkdev ATTRIBUTE_UNUSED, int vf ATTRIBUTE_UNUSED, const char *stateDir ATTRIBUTE_UNUSED, virMacAddrPtr *adminMAC ATTRIBUTE_UNUSED, - virNetDevVLanPtr *vlan ATTRIBUTE_UNUSED, + virNetDevVlanPtr *vlan ATTRIBUTE_UNUSED, virMacAddrPtr *MAC ATTRIBUTE_UNUSED) { virReportSystemError(ENOSYS, "%s", -- 2.11.0
On Mon, Mar 27, 2017 at 07:25:16PM +0400, Roman Bogorodskiy wrote:
Fix some typos in the source code:
- Missplaced ")",
s/Miss/Mis/ Jan
- virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and syntax-checking failing, so I cannot do a complete test build.
src/util/virnetdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Ján Tomko wrote:
On Mon, Mar 27, 2017 at 07:25:16PM +0400, Roman Bogorodskiy wrote:
Fix some typos in the source code:
- Missplaced ")",
s/Miss/Mis/
Thanks for the correction, I fixed it locally. Now that I have everything building fine with this patch and the virmdev fix I just posted, I think I'll push these two fixes later today or tomorrow it there will be no objections.
Jan
- virNetDevVLanPtr -> virNetDevVlanPtr --- I'm NOT pushing that under the build breaker rule right now because I also have some other build failures and syntax-checking failing, so I cannot do a complete test build.
src/util/virnetdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
Roman Bogorodskiy
On 03/27/2017 11:25 AM, Roman Bogorodskiy wrote:
Fix some typos in the source code:
- Missplaced ")", - virNetDevVLanPtr -> virNetDevVlanPtr
Sigh. Sorry for the mess. Some day I should setup a guest running a *BSD and start doing a build there with each patch. (BTW, this is the top reason that I'm so loathe to push anything after a pre-release freeze)
participants (3)
-
Ján Tomko -
Laine Stump -
Roman Bogorodskiy