[libvirt] [PATCH 1/3] Revert "VMX: Some serial ports are not actually connected"
This reverts commit dba04e7fa070a79415ea16141ad2e2ebd4f23033. This change was unfortunately not correct. We should have been changing the boolean argument supplied. --- src/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 38b7cc0..9906a9c 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2718,7 +2718,7 @@ virVMXParseSerial(virVMXContext *ctx, virConfPtr conf, int port, /* vmx:fileName -> def:data.file.path */ if (virVMXGetConfigString(conf, fileName_name, &fileName, false) < 0) { - goto ignore; + goto cleanup; } /* vmx:network.endPoint -> def:data.tcp.listen */ -- 1.8.1.5
Serial devices don't necessarily have to be attached to an output to be shown to the guest. --- src/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/vmx/vmx.c b/src/vmx/vmx.c index 9906a9c..36bc338 100644 --- a/src/vmx/vmx.c +++ b/src/vmx/vmx.c @@ -2717,7 +2717,7 @@ virVMXParseSerial(virVMXContext *ctx, virConfPtr conf, int port, } /* vmx:fileName -> def:data.file.path */ - if (virVMXGetConfigString(conf, fileName_name, &fileName, false) < 0) { + if (virVMXGetConfigString(conf, fileName_name, &fileName, true) < 0) { goto cleanup; } -- 1.8.1.5
On 10/12/2013 10:21 PM, Doug Goldstein wrote:
Serial devices don't necessarily have to be attached to an output to be shown to the guest. --- src/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK to both. I didn't receive 3/3. Jan
On Mon, Oct 14, 2013 at 2:32 AM, Ján Tomko <jtomko@redhat.com> wrote:
On 10/12/2013 10:21 PM, Doug Goldstein wrote:
Serial devices don't necessarily have to be attached to an output to be shown to the guest. --- src/vmx/vmx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK to both.
I didn't receive 3/3.
Jan
Thanks. Yeah I decided to hold back 3/3 and forgot to edit the subject. -- Doug Goldstein
participants (2)
-
Doug Goldstein -
Ján Tomko