[libvirt] [PATCH] qemu: fix qemuCgroupControllerActive
Since 56f27b3 it always returned false. --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2cdc2b7..9e11a05 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -58,6 +58,8 @@ bool qemuCgroupControllerActive(virQEMUDriverPtr driver, if (!virCgroupMounted(driver->cgroup, controller)) goto cleanup; + ret = true; + cleanup: virObjectUnref(cfg); return ret; -- 1.8.1.5
On Mon, Apr 08, 2013 at 02:29:05PM +0200, Ján Tomko wrote:
Since 56f27b3 it always returned false. --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2cdc2b7..9e11a05 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -58,6 +58,8 @@ bool qemuCgroupControllerActive(virQEMUDriverPtr driver, if (!virCgroupMounted(driver->cgroup, controller)) goto cleanup;
+ ret = true; + cleanup: virObjectUnref(cfg); return ret;
Be better if someone just reviewed the following patch which kills the rest of this method https://www.redhat.com/archives/libvir-list/2013-April/msg00358.html Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 08/04/13 20:29, Ján Tomko wrote:
Since 56f27b3 it always returned false. --- src/qemu/qemu_cgroup.c | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c index 2cdc2b7..9e11a05 100644 --- a/src/qemu/qemu_cgroup.c +++ b/src/qemu/qemu_cgroup.c @@ -58,6 +58,8 @@ bool qemuCgroupControllerActive(virQEMUDriverPtr driver, if (!virCgroupMounted(driver->cgroup, controller)) goto cleanup;
+ ret = true; + cleanup: virObjectUnref(cfg); return ret; ACK
participants (3)
-
Daniel P. Berrange -
Ján Tomko -
Osier Yang