[libvirt] [PATCH] vz: fixed null-pointer dereference in applying graphic params

Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com> --- src/vz/vz_sdk.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index f4c2b3b..903440b 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2790,6 +2790,7 @@ static int prlsdkApplyGraphicsParams(PRL_HANDLE sdkdom, if (!gr) { pret = PrlVmCfg_SetVNCMode(sdkdom, PRD_DISABLED); prlsdkCheckRetExit(pret, -1); + return 1; } pret = PrlVmCfg_SetVNCPassword(sdkdom, gr->data.vnc.auth.passwd ? : ""); -- 1.8.3.1

On 29.06.2016 20:04, Olga Krishtal wrote:
Signed-off-by: Olga Krishtal <okrishtal@virtuozzo.com> --- src/vz/vz_sdk.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/vz/vz_sdk.c b/src/vz/vz_sdk.c index f4c2b3b..903440b 100644 --- a/src/vz/vz_sdk.c +++ b/src/vz/vz_sdk.c @@ -2790,6 +2790,7 @@ static int prlsdkApplyGraphicsParams(PRL_HANDLE sdkdom, if (!gr) { pret = PrlVmCfg_SetVNCMode(sdkdom, PRD_DISABLED); prlsdkCheckRetExit(pret, -1); + return 1;
let's return 0 as usual, otherwise ACK
}
pret = PrlVmCfg_SetVNCPassword(sdkdom, gr->data.vnc.auth.passwd ? : "");
participants (2)
-
Nikolay Shirokovskiy
-
Olga Krishtal