[libvirt] [PATCH] Remove invalid ATTRIBUTE_UNUSED
Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached. Thanks, Cole
Cole Robinson <crobinso@redhat.com> wrote:
Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached.
diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 09be3fb..20d3c0c 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2883,7 +2883,7 @@ cleanup:
static char *qemudDomainDumpXML(virDomainPtr dom, - int flags ATTRIBUTE_UNUSED) { + int flags) {
Obviously used. ACK
On Mon, Feb 16, 2009 at 06:42:50PM -0500, Cole Robinson wrote:
Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached.
diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 09be3fb..20d3c0c 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -2883,7 +2883,7 @@ cleanup:
static char *qemudDomainDumpXML(virDomainPtr dom, - int flags ATTRIBUTE_UNUSED) { + int flags) { struct qemud_driver *driver = dom->conn->privateData; virDomainObjPtr vm; char *ret = NULL;
ACK Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Anno domini 2009 Cole Robinson scripsit:
Cole Robinson wrote:
Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached.
Pushed now.
Nice idea, wrong function though. See attached patch and please git pull http://git.rfc2324.org/repositories/libvirt.git 4upstream Ciao Max -- Follow the white penguin.
Maximilian Wilhelm wrote:
Anno domini 2009 Cole Robinson scripsit:
Cole Robinson wrote:
Stumbled on an ATTRIBUTE_UNUSED that is actually used. Patch attached.
Pushed now.
Nice idea, wrong function though.
Wow, I'm a dope. Sorry about that. I committed the patch on a separate machine, and just attempted to reproduce the edit by hand. Clearly that failed. Unfortunately I can't pull from your git tree since we have to commit via cvs, so I just applied the patch manually. This should be fixed now. Thanks, Cole
participants (4)
-
Cole Robinson -
Daniel P. Berrange -
Jim Meyering -
Maximilian Wilhelm