[libvirt] [PATCH] virsh iface-bridge: Ignore delay if stp is turned off
Delay only makes sense with STP enabled. --- tools/virsh-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index 1c2e40b..2bdb215 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -894,7 +894,7 @@ cmdInterfaceBridge(vshControl *ctl, const vshCmd *cmd) goto cleanup; } - if ((delay || stp) && + if (stp && ((virAsprintf(&delay_str, "%d", delay) < 0) || !xmlSetProp(br_node, BAD_CAST "delay", BAD_CAST delay_str))) { vshError(ctl, _("Failed to set bridge delay %d in xml document"), delay); -- 1.8.2.1
On 06/03/2013 04:23 AM, Jiri Denemark wrote:
Delay only makes sense with STP enabled. --- tools/virsh-interface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK.
diff --git a/tools/virsh-interface.c b/tools/virsh-interface.c index 1c2e40b..2bdb215 100644 --- a/tools/virsh-interface.c +++ b/tools/virsh-interface.c @@ -894,7 +894,7 @@ cmdInterfaceBridge(vshControl *ctl, const vshCmd *cmd) goto cleanup; }
- if ((delay || stp) && + if (stp && ((virAsprintf(&delay_str, "%d", delay) < 0) || !xmlSetProp(br_node, BAD_CAST "delay", BAD_CAST delay_str))) { vshError(ctl, _("Failed to set bridge delay %d in xml document"), delay);
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Jiri Denemark