[PATCH] vircpi: Add PCIe 5.0 and 6.0 link speeds

The PCIe 5.0 and PCIe 6.0 standards define new link speeds: 32GT/s and 64GT/s, respectively. Update our internal enum to include these new speeds. Otherwise we format incorrect XML: <pci-express> <link validity='cap' port='0' speed='(null)' width='16'/> <link validity='sta' speed='16' width='16'/> </pci-express> Like all "good" specifications, these are also locked behind a login portal. But we can look at pciutils' source code: [1] and [2]. 1: https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/commit/ls-caps.c?... 2: https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/commit/ls-caps.c?... Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2105231 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/util/virpci.c | 2 +- src/util/virpci.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/util/virpci.c b/src/util/virpci.c index 03d1d7b074..7800966963 100644 --- a/src/util/virpci.c +++ b/src/util/virpci.c @@ -45,7 +45,7 @@ VIR_LOG_INIT("util.pci"); VIR_ENUM_IMPL(virPCIELinkSpeed, VIR_PCIE_LINK_SPEED_LAST, - "", "2.5", "5", "8", "16", + "", "2.5", "5", "8", "16", "32", "64" ); VIR_ENUM_IMPL(virPCIStubDriver, diff --git a/src/util/virpci.h b/src/util/virpci.h index b9b9cd7b34..4d9193f24e 100644 --- a/src/util/virpci.h +++ b/src/util/virpci.h @@ -83,6 +83,8 @@ typedef enum { VIR_PCIE_LINK_SPEED_5, VIR_PCIE_LINK_SPEED_8, VIR_PCIE_LINK_SPEED_16, + VIR_PCIE_LINK_SPEED_32, + VIR_PCIE_LINK_SPEED_64, VIR_PCIE_LINK_SPEED_LAST } virPCIELinkSpeed; -- 2.35.1

On a Friday in 2022, Michal Privoznik wrote:
The PCIe 5.0 and PCIe 6.0 standards define new link speeds: 32GT/s and 64GT/s, respectively. Update our internal enum to include these new speeds. Otherwise we format incorrect XML:
<pci-express> <link validity='cap' port='0' speed='(null)' width='16'/> <link validity='sta' speed='16' width='16'/> </pci-express>
Like all "good" specifications, these are also locked behind a login portal. But we can look at pciutils' source code: [1] and [2].
1: https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/commit/ls-caps.c?... 2: https://git.kernel.org/pub/scm/utils/pciutils/pciutils.git/commit/ls-caps.c?...
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2105231 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/util/virpci.c | 2 +- src/util/virpci.h | 2 ++ 2 files changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
participants (2)
-
Ján Tomko
-
Michal Privoznik