[libvirt] Reconfiguring doesn't trigger regeneration of libvirt.syms
Consider this sequence of commands $ ./configure ... $ make ... GEN libvirt.syms ... $ ./configure --with-driver-modules ... $ make ... libvirt.syms doesn't get regenerated but it should as it should contain virDriverLoadModule now. make clean after a configure run doesn't help, as make clean dosen't remove libvirt.syms. So either the libvirt.syms rule needs to depend on something that triggers a regeneration of libvirt.syms after a reconfiguration or make clean needs to remove libvirt.syms. I'm not sure about the correct solution here. Any suggestions? Matthias
$ ./configure ... $ make ... GEN libvirt.syms ... $ ./configure --with-driver-modules ... $ make ... libvirt.syms doesn't get regenerated but it should as it should contain virDriverLoadModule now. * src/Makefile.am (libvirt.syms): Depend on configure changes. Reported by Matthias Bolte. --- This is not the first time we've had a file that needs to be rebuilt after a configure change (see {daemon/tools}/Makefile.am for precedence). src/Makefile.am | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/Makefile.am b/src/Makefile.am index 02d5250..30c6cd3 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -1074,7 +1074,8 @@ EXTRA_DIST += \ BUILT_SOURCES += libvirt.syms libvirt.def libvirt_qemu.def -libvirt.syms: libvirt_public.syms $(USED_SYM_FILES) +libvirt.syms: libvirt_public.syms $(USED_SYM_FILES) \ + $(top_builddir)/config.status $(AM_V_GEN)rm -f $@-tmp $@ ; \ printf '# WARNING: generated from the following:\n# $^\n\n' >$@-tmp && \ cat $(srcdir)/libvirt_public.syms >>$@-tmp && \ -- 1.7.4
2011/2/17 Eric Blake <eblake@redhat.com>:
$ ./configure ... $ make ... GEN libvirt.syms ... $ ./configure --with-driver-modules ... $ make ...
libvirt.syms doesn't get regenerated but it should as it should contain virDriverLoadModule now.
* src/Makefile.am (libvirt.syms): Depend on configure changes. Reported by Matthias Bolte. ---
ACK, works as expected now. Matthias
On 02/18/2011 02:38 AM, Matthias Bolte wrote:
2011/2/17 Eric Blake <eblake@redhat.com>:
$ ./configure ... $ make ... GEN libvirt.syms ... $ ./configure --with-driver-modules ... $ make ...
libvirt.syms doesn't get regenerated but it should as it should contain virDriverLoadModule now.
* src/Makefile.am (libvirt.syms): Depend on configure changes. Reported by Matthias Bolte. ---
ACK, works as expected now.
Thanks; pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (2)
-
Eric Blake -
Matthias Bolte