[libvirt] [PATCH] conf: fix use of uninitialized variable

If same boot order is specified twice (or more) in domain xml we call free for uninitiaziled loadparm on cleanup in virDomainDeviceBootParseXML and SIGABRT (or similar) as a result. --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c index 516f9fa..25d48f9 100644 --- a/src/conf/domain_conf.c +++ b/src/conf/domain_conf.c @@ -6188,7 +6188,7 @@ virDomainDeviceBootParseXML(xmlNodePtr node, virHashTablePtr bootHash) { char *order; - char *loadparm; + char *loadparm = NULL; int ret = -1; if (!(order = virXMLPropString(node, "order"))) { -- 1.8.3.1

On 10/17/2017 09:56 AM, Nikolay Shirokovskiy wrote:
If same boot order is specified twice (or more) in domain xml we call free for uninitiaziled loadparm on cleanup in virDomainDeviceBootParseXML and SIGABRT (or similar) as a result. --- src/conf/domain_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: John Ferlan <jferlan@redhat.com> (and pushed) - Tks - John
participants (2)
-
John Ferlan
-
Nikolay Shirokovskiy