2011/7/5 Jean-Baptiste Rouault <jean-baptiste.rouault(a)diateam.net>:
On Tuesday 05 July 2011 17:43:06 Daniel P. Berrange wrote:
> On Tue, Jul 05, 2011 at 05:30:09PM +0200, Jean-Baptiste Rouault wrote:
> > This patch adds #if HAVE_SASL where needed in libvirtd.h
> > ---
> >
> > daemon/libvirtd.h | 8 +++++++-
> > 1 files changed, 7 insertions(+), 1 deletions(-)
>
> This was already fixed last week
>
> commit 0e4b921a57b670bbe55c27d17ca19aa5780ee196
> Author: Daniel P. Berrange <berrange(a)redhat.com>
> Date: Thu Jun 30 18:18:08 2011 +0100
>
> Add conditionals to allow build without SASL
>
> * daemon/libvirtd.c, daemon/remote.c: Add #if HAVE_SASL and
> suitable function stubs to allow build without SASL
>
>
> Daniel
Hi,
The patch you are referring to adds conditionals to libvirtd.c and remote.c.
My patch adds conditionals to the libvirtd.h file because it includes
virnetsaslcontext.h and uses SASL-related types and libvirt fails to build
with "--without-sasl" flag.
Regards,
Jean-Baptiste
I can reproduce this, but I need to uninstall the SASL header for
that. Just compiling with --without-sasl but the SASL headers
installed works. Also libvirtd.h is the only place that includes
virnetsaslcontext.h unconditional. So this patch is correct and
necessary.
I've pushed it.
--
Matthias Bolte
http://photron.blogspot.com