[libvirt] qemu: Unlock the NWFilter update lock by leaving via the cleanup label
Fix a locking problem by leaving the function via the cleanup label. Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com> --- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: libvirt-acl/src/qemu/qemu_driver.c =================================================================== --- libvirt-acl.orig/src/qemu/qemu_driver.c +++ libvirt-acl/src/qemu/qemu_driver.c @@ -6140,7 +6140,7 @@ qemuDomainCreateWithFlags(virDomainPtr d virNWFilterReadLockFilterUpdates(); if (!(vm = qemuDomObjFromDomain(dom))) - return -1; + goto cleanup; if (virDomainCreateWithFlagsEnsureACL(dom->conn, vm->def) < 0) goto cleanup;
On 04/16/2014 11:54 PM, Stefan Berger wrote:
Fix a locking problem by leaving the function via the cleanup label.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
--- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Index: libvirt-acl/src/qemu/qemu_driver.c =================================================================== --- libvirt-acl.orig/src/qemu/qemu_driver.c +++ libvirt-acl/src/qemu/qemu_driver.c @@ -6140,7 +6140,7 @@ qemuDomainCreateWithFlags(virDomainPtr d virNWFilterReadLockFilterUpdates();
if (!(vm = qemuDomObjFromDomain(dom))) - return -1; + goto cleanup;
if (virDomainCreateWithFlagsEnsureACL(dom->conn, vm->def) < 0) goto cleanup;
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 04/17/2014 02:31 AM, Ján Tomko wrote:
On 04/16/2014 11:54 PM, Stefan Berger wrote:
Fix a locking problem by leaving the function via the cleanup label.
Signed-off-by: Stefan Berger <stefanb@linux.vnet.ibm.com>
--- src/qemu/qemu_driver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
ACK
Pushed.
participants (2)
-
Ján Tomko -
Stefan Berger