[libvirt] [PATCH] usb: don't spoil decadic addresses

For USB devices, dev->name gets formated as %.3o:%.3o even though the numbers are decadic. Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=967712 Signed-off-by: Martin Kletzander <mkletzan@redhat.com> --- Notes: It can be seen few lines down the file src/util/virusb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/util/virusb.c b/src/util/virusb.c index 27ba9c7..d34e44f 100644 --- a/src/util/virusb.c +++ b/src/util/virusb.c @@ -342,10 +342,10 @@ virUSBDeviceNew(unsigned int bus, dev->bus = bus; dev->dev = devno; - if (snprintf(dev->name, sizeof(dev->name), "%.3o:%.3o", + if (snprintf(dev->name, sizeof(dev->name), "%.3d:%.3d", dev->bus, dev->dev) >= sizeof(dev->name)) { virReportError(VIR_ERR_INTERNAL_ERROR, - _("dev->name buffer overflow: %.3o:%.3o"), + _("dev->name buffer overflow: %.3d:%.3d"), dev->bus, dev->dev); virUSBDeviceFree(dev); return NULL; -- 1.8.2.1

On 06/01/2013 01:52 AM, Martin Kletzander wrote:
For USB devices, dev->name gets formated as %.3o:%.3o even though the numbers are decadic.
s/decadic/decimal/ here and in the subject line.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=967712
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> ---
ACK. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org

On 06/02/2013 02:41 AM, Eric Blake wrote:
On 06/01/2013 01:52 AM, Martin Kletzander wrote:
For USB devices, dev->name gets formated as %.3o:%.3o even though the numbers are decadic.
s/decadic/decimal/ here and in the subject line.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=967712
Signed-off-by: Martin Kletzander <mkletzan@redhat.com> ---
ACK.
Thanks, fixed both occurrences and pushed. Martin
participants (2)
-
Eric Blake
-
Martin Kletzander