[adding libvirt] On 05/11/2012 12:46 AM, Amos Kong wrote:

On 05/11/2012 02:12 AM, Michael Roth wrote:

...

On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote:

...

On 05/10/2012 10:27 AM, Amos Kong wrote:

...

Those patches updated help functions in qemu-socket.c, and used them in migrate-tcp.c to supporting IPv6 migration.

...

addr parsing now relies on qemu-sockets.c:inet_parse(), which has supported [ip6addr]:port for a while, as opposed to net.c:parse_host_port(), which didn't.

yeah.

I didn't change qemu monitor cmd interface in this patchset, and the transport of data is done by qemu, not libvirt.

I guess libvirt only needs to update addr string parse, for example:

---- GOOD start a VM: # qemu-kvm --enable-kvm -boot n -incoming tcp:ipv6alias:16514 -vnc :1 -monitor stdio -name qemu-vm1

try to migrate vm by virsh with addr alias # virsh migrate libivrt-vm2 tcp:ipv6alias (connection can establish)

--- FAIL start a VM: # qemu-kvm-apply-my-patches --enable-kvm -boot n -incoming tcp:[2002::3:4]:16514 -vnc :1 -monitor stdio -name qemu-vm1

try to migrate vm by virsh with ipv6 addr: # virsh migrate libvirt-vm2 tcp:[2002::3:4] error: invalid argument: could not parse connection URI tcp:[2002::3:4]

Thanks for researching that. Looks like it should be fixed in libvirt to match, then. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org