[libvirt] [PATCH] spec: Disable -Werror in Fedora RPM builds
Since we switched to using GIT to apply patches in the RPM spec, we automagically also turned on -Werror, since the .git directory now exists. We don't want this on in Fedora, since changing header files often lead to new warnings being issued. Explicitly turn off -Werror for non-RHEL platforms, instead of relying on the defaults --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libvirt.spec.in b/libvirt.spec.in index 264c06f..edf2df8 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -357,6 +357,8 @@ # changes in reported warnings %if 0%{?rhel} %define enable_werror --enable-werror +else + %define enable_werror --disable-werror %endif -- 2.1.0
On 12/15/2014 08:25 AM, Daniel P. Berrange wrote:
Since we switched to using GIT to apply patches in the RPM spec, we automagically also turned on -Werror, since the .git directory now exists. We don't want this on in Fedora, since changing header files often lead to new warnings being issued. Explicitly turn off -Werror for non-RHEL platforms, instead of relying on the defaults --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+)
ACK
diff --git a/libvirt.spec.in b/libvirt.spec.in index 264c06f..edf2df8 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -357,6 +357,8 @@ # changes in reported warnings %if 0%{?rhel} %define enable_werror --enable-werror +else + %define enable_werror --disable-werror %endif
-- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On 12/15/2014 04:25 PM, Daniel P. Berrange wrote:
Since we switched to using GIT to apply patches in the RPM spec, we automagically also turned on -Werror, since the .git directory now exists. We don't want this on in Fedora, since changing header files often lead to new warnings being issued. Explicitly turn off -Werror for non-RHEL platforms, instead of relying on the defaults --- libvirt.spec.in | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 264c06f..edf2df8 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -357,6 +357,8 @@ # changes in reported warnings %if 0%{?rhel} %define enable_werror --enable-werror +else + %define enable_werror --disable-werror %endif
This breaks 'make rpm' in jenkins: error: line 360: Unknown tag: else Jan
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index edf2df8..ba1cf41 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -357,7 +357,7 @@ # changes in reported warnings %if 0%{?rhel} %define enable_werror --enable-werror -else +%else %define enable_werror --disable-werror %endif -- 2.2.0
On Tue, Dec 16, 2014 at 09:23:49 +0100, Jiri Denemark wrote:
Signed-off-by: Jiri Denemark <jdenemar@redhat.com> --- libvirt.spec.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index edf2df8..ba1cf41 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -357,7 +357,7 @@ # changes in reported warnings %if 0%{?rhel} %define enable_werror --enable-werror -else +%else %define enable_werror --disable-werror %endif
Already pushed as trivial. Jirka
participants (4)
-
Daniel P. Berrange -
Eric Blake -
Jiri Denemark -
Ján Tomko