On Mon, Jan 31, 2011 at 12:52:55PM +0800, Osier Yang wrote: > * src/qemu/qemu_driver.c > --- > src/qemu/qemu_driver.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 84d339b..929dc94 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -8014,7 +8014,8 @@ qemudDomainMigratePrepareTunnel(virConnectPtr dconn, > if (!(def = virDomainDefParseString(driver->caps, dom_xml, > VIR_DOMAIN_XML_INACTIVE))) { > qemuReportError(VIR_ERR_OPERATION_FAILED, > - "%s", _("failed to parse XML")); > + "%s", _("failed to parse XML, libvirt version may be " > + "different between source and destination host")); > goto cleanup; > } > ACK, please push :-)

Daniel

On Sun, Jan 30, 2011 at 04:46:39PM +0800, Osier Yang wrote: > * src/qemu/qemu_driver.c > --- > src/qemu/qemu_driver.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c > index 84d339b..929dc94 100644 > --- a/src/qemu/qemu_driver.c > +++ b/src/qemu/qemu_driver.c > @@ -8014,7 +8014,8 @@ qemudDomainMigratePrepareTunnel(virConnectPtr dconn, > if (!(def = virDomainDefParseString(driver->caps, dom_xml, > VIR_DOMAIN_XML_INACTIVE))) { > qemuReportError(VIR_ERR_OPERATION_FAILED, > - "%s", _("failed to parse XML")); > + "%s", _("failed to parse XML, libvirt version may be " > + "diffrent between source and destination host")); > goto cleanup; NACK, this code is already broken. The virDomainDefParseString() method *already* reported the real problem. This call to qemuReportError() is overwriting the real error message with something that is useless. The qemuReportError() call needs to just be deleted entirely.