[libvirt] [libvirt-ci][PATCH] Remove builders for Centos 6
These builds often fails with false positives due to ancient compiler found on this system. For instance it fails to see when symbol is used as a variable and when it is used as a function producing the following warnings: ../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow] /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow] Users trying to use libvirt from git on stable system are doomed to fix it themselves. Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- projects/libvirt-cim.yaml | 1 - projects/libvirt-python.yaml | 1 - projects/libvirt.yaml | 3 --- 3 files changed, 5 deletions(-) diff --git a/projects/libvirt-cim.yaml b/projects/libvirt-cim.yaml index d1705af..dd40eb1 100644 --- a/projects/libvirt-cim.yaml +++ b/projects/libvirt-cim.yaml @@ -2,7 +2,6 @@ - project: name: libvirt-cim machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 diff --git a/projects/libvirt-python.yaml b/projects/libvirt-python.yaml index baca308..adf22f4 100644 --- a/projects/libvirt-python.yaml +++ b/projects/libvirt-python.yaml @@ -2,7 +2,6 @@ - project: name: libvirt-python machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 diff --git a/projects/libvirt.yaml b/projects/libvirt.yaml index 20de27c..2b4e5d3 100644 --- a/projects/libvirt.yaml +++ b/projects/libvirt.yaml @@ -2,7 +2,6 @@ - project: name: libvirt machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-fedora-23 - libvirt-fedora-24 @@ -13,7 +12,6 @@ - autotools-build-job: parent_jobs: machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - libvirt-fedora-23 @@ -23,7 +21,6 @@ - autotools-syntax-check-job: parent_jobs: 'libvirt-master-build' machines: - - libvirt-centos-6 - libvirt-centos-7 - libvirt-debian - libvirt-fedora-23 -- 2.11.0
On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote:
These builds often fails with false positives due to ancient compiler found on this system. For instance it fails to see when symbol is used as a variable and when it is used as a function producing the following warnings:
../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow] /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow]
Users trying to use libvirt from git on stable system are doomed to fix it themselves.
NACK, CentOS 6 is a supported platform and we need to make sure we continue to build on there. Working around these compiler warnings is not hard. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
On 13.12.2016 11:51, Daniel P. Berrange wrote:
On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote:
These builds often fails with false positives due to ancient compiler found on this system. For instance it fails to see when symbol is used as a variable and when it is used as a function producing the following warnings:
../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow] /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow]
Users trying to use libvirt from git on stable system are doomed to fix it themselves.
NACK, CentOS 6 is a supported platform and we need to make sure we continue to build on there. Working around these compiler warnings is not hard.
I know it is supported but frankly I've never tried running git libvirt there. Do we even know it still works? Otherwise our claim is just an empty promise that we do compile cleanly there. Michal
On Tue, Dec 13, 2016 at 12:04:17PM +0100, Michal Privoznik wrote:
On 13.12.2016 11:51, Daniel P. Berrange wrote:
On Tue, Dec 13, 2016 at 11:41:55AM +0100, Michal Privoznik wrote:
These builds often fails with false positives due to ancient compiler found on this system. For instance it fails to see when symbol is used as a variable and when it is used as a function producing the following warnings:
../../src/qemu/qemu_monitor_text.c: In function 'parseMemoryStat': ../../src/qemu/qemu_monitor_text.c:604: error: declaration of 'stat' shadows a global declaration [-Wshadow] /usr/include/sys/stat.h:455: error: shadowed declaration is here [-Wshadow]
Users trying to use libvirt from git on stable system are doomed to fix it themselves.
NACK, CentOS 6 is a supported platform and we need to make sure we continue to build on there. Working around these compiler warnings is not hard.
I know it is supported but frankly I've never tried running git libvirt there. Do we even know it still works? Otherwise our claim is just an empty promise that we do compile cleanly there.
Just because we don't have automated testing doesn't mean the code has stopped working. You can say the same about pretty much every single distro, since we don't have our CI running integration tests yet. This is a gap I'd like to see us address, though it likely requires us to get more hardware resource, since the current CI host is pretty fully loaded just doing builds. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
participants (2)
-
Daniel P. Berrange -
Michal Privoznik