[libvirt] [PATCH] aarch64: Disable -fstack-protector.
From: "Richard W.M. Jones" <rjones@redhat.com> I'm using gcc-4.8.2-7.fc21.aarch64 which does not appear to support this option. --- m4/virt-compile-warnings.m4 | 3 +++ 1 file changed, 3 insertions(+) diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 1547e03..574fbc4 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -163,6 +163,9 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ dnl -fstack-protector stuff passes gl_WARN_ADD with gcc dnl on Mingw32, but fails when actually used case $host in + aarch64-*-*) + dnl "error: -fstack-protector not supported for this target [-Werror]" + ;; *-*-linux*) dnl Fedora only uses -fstack-protector, but doesn't seem to dnl be great overhead in adding -fstack-protector-all instead -- 1.8.3.1
On 01/01/2014 06:42 AM, Richard W.M. Jones wrote:
From: "Richard W.M. Jones" <rjones@redhat.com>
I'm using gcc-4.8.2-7.fc21.aarch64 which does not appear to support this option. --- m4/virt-compile-warnings.m4 | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 1547e03..574fbc4 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -163,6 +163,9 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ dnl -fstack-protector stuff passes gl_WARN_ADD with gcc dnl on Mingw32, but fails when actually used case $host in + aarch64-*-*) + dnl "error: -fstack-protector not supported for this target [-Werror]" + ;;
ACK. It would be nicer to figure out why gl_WARN_ADD isn't able to flag this warning as broken for your setup in the first place, but as that's probably more of a task for gnulib, I'm okay with this patch in the meantime. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Wed, Jan 01, 2014 at 06:52:09AM -0700, Eric Blake wrote:
On 01/01/2014 06:42 AM, Richard W.M. Jones wrote:
From: "Richard W.M. Jones" <rjones@redhat.com>
I'm using gcc-4.8.2-7.fc21.aarch64 which does not appear to support this option. --- m4/virt-compile-warnings.m4 | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/m4/virt-compile-warnings.m4 b/m4/virt-compile-warnings.m4 index 1547e03..574fbc4 100644 --- a/m4/virt-compile-warnings.m4 +++ b/m4/virt-compile-warnings.m4 @@ -163,6 +163,9 @@ AC_DEFUN([LIBVIRT_COMPILE_WARNINGS],[ dnl -fstack-protector stuff passes gl_WARN_ADD with gcc dnl on Mingw32, but fails when actually used case $host in + aarch64-*-*) + dnl "error: -fstack-protector not supported for this target [-Werror]" + ;;
ACK. It would be nicer to figure out why gl_WARN_ADD isn't able to flag this warning as broken for your setup in the first place, but as that's probably more of a task for gnulib, I'm okay with this patch in the meantime.
Well ... gl_WARN_ADD is a horrible mess of m4 and autoconf macros so it's hard to understand exactly how it works. However it is only *specified* to work on warnings (-Wstack-protector) not on feature flags (-fstack-protector). So it seems like a mistake that libvirt's m4 module calls gl_WARN_ADD with all the flags. Anyway I've pushed this now, thanks. Obviously this is a commit that we'll revert when gcc is fixed/enhanced! Rich. -- Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones Fedora Windows cross-compiler. Compile Windows programs, test, and build Windows installers. Over 100 libraries supported. http://fedoraproject.org/wiki/MinGW
participants (2)
-
Eric Blake -
Richard W.M. Jones