11:23 a.m.
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 193959f..a146463 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
if (sdl > 1 || vnc > 1 || spice > 1) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("only 1 graphics device of each type "
- "(sdl, vnc, spice) is supported"));
+ "(vnc, spice) is supported"));
goto error;
}
--
1.9.3
11:26 a.m.
On Fri, May 23, 2014 at 05:23:36PM +0800, tzheng(a)redhat.com wrote:
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 193959f..a146463 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
if (sdl > 1 || vnc > 1 || spice > 1) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("only 1 graphics device of each type "
- "(sdl, vnc, spice) is supported"));
+ "(vnc, spice) is supported"));
goto error;
}
What makes you think SDL is unsupported ?
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
11:30 a.m.
I just filed bug and the patch resolves the
bug:https://bugzilla.redhat.com/show_bug.cgi?id=1100634
Best regards,
Tingting Zheng（郑婷婷）
----- Original Message -----
From: "Daniel P. Berrange" <berrange(a)redhat.com>
To: tzheng(a)redhat.com
Cc: libvir-list(a)redhat.com
Sent: Friday, May 23, 2014 5:26:23 PM
Subject: Re: [libvirt] [PATCH] Remove unsupported type sdl from error info when set 2 vnc
or spice graphics
On Fri, May 23, 2014 at 05:23:36PM +0800, tzheng(a)redhat.com wrote:
---
src/qemu/qemu_command.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 193959f..a146463 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
if (sdl > 1 || vnc > 1 || spice > 1) {
virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
_("only 1 graphics device of each type "
- "(sdl, vnc, spice) is supported"));
+ "(vnc, spice) is supported"));
goto error;
}
What makes you think SDL is unsupported ?
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
11:31 a.m.
On 05/23/14 11:26, Daniel P. Berrange wrote:
On Fri, May 23, 2014 at 05:23:36PM +0800, tzheng(a)redhat.com wrote:
> ---
> src/qemu/qemu_command.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 193959f..a146463 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
> if (sdl > 1 || vnc > 1 || spice > 1) {
> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> _("only 1 graphics device of each type "
> - "(sdl, vnc, spice) is supported"));
> + "(vnc, spice) is supported"));
> goto error;
> }
What makes you think SDL is unsupported ?
It's unsupported in rhel-7 (
https://bugzilla.redhat.com/show_bug.cgi?id=1100634 ). Upstream we do
support it.
NACK to the patch.
Regards,
Daniel
Peter
11:35 a.m.
On Fri, May 23, 2014 at 11:31:17AM +0200, Peter Krempa wrote:
On 05/23/14 11:26, Daniel P. Berrange wrote:
> On Fri, May 23, 2014 at 05:23:36PM +0800, tzheng(a)redhat.com wrote:
>> ---
>> src/qemu/qemu_command.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>> index 193959f..a146463 100644
>> --- a/src/qemu/qemu_command.c
>> +++ b/src/qemu/qemu_command.c
>> @@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
>> if (sdl > 1 || vnc > 1 || spice > 1) {
>> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>> _("only 1 graphics device of each type "
>> - "(sdl, vnc, spice) is supported"));
>> + "(vnc, spice) is supported"));
>> goto error;
>> }
>
> What makes you think SDL is unsupported ?
>
It's unsupported in rhel-7 (
https://bugzilla.redhat.com/show_bug.cgi?id=1100634 ). Upstream we do
support it.
Even that's wrong. The KVM binary shipped in RHEL doesn't support it,
but libvirt does support it. The user may be using libvirt with a
different QEMU/KVM binary than the one we expect - eg a newer version
shipped by a software collection or RHEL add-on like RDO
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
11:38 a.m.
On 05/23/14 11:35, Daniel P. Berrange wrote:
On Fri, May 23, 2014 at 11:31:17AM +0200, Peter Krempa wrote:
> On 05/23/14 11:26, Daniel P. Berrange wrote:
>> On Fri, May 23, 2014 at 05:23:36PM +0800, tzheng(a)redhat.com wrote:
>>> ---
>>> src/qemu/qemu_command.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>>> index 193959f..a146463 100644
>>> --- a/src/qemu/qemu_command.c
>>> +++ b/src/qemu/qemu_command.c
>>> @@ -8579,7 +8579,7 @@ qemuBuildCommandLine(virConnectPtr conn,
>>> if (sdl > 1 || vnc > 1 || spice > 1) {
>>> virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
>>> _("only 1 graphics device of each type "
>>> - "(sdl, vnc, spice) is supported"));
>>> + "(vnc, spice) is supported"));
>>> goto error;
>>> }
>>
>> What makes you think SDL is unsupported ?
>>
>
> It's unsupported in rhel-7 (
> https://bugzilla.redhat.com/show_bug.cgi?id=1100634 ). Upstream we do
> support it.
Even that's wrong. The KVM binary shipped in RHEL doesn't support it,
but libvirt does support it. The user may be using libvirt with a
different QEMU/KVM binary than the one we expect - eg a newer version
shipped by a software collection or RHEL add-on like RDO
Indeed. I was talking about the qemu version of course. :)
Regards,
Daniel
3769
days inactive
3769
days old
5 comments
4 participants
participants (4)
-
Daniel P. Berrange -
Peter Krempa -
Tingting Zheng -
tzheng＠redhat.com