[libvirt] [jenkins-ci PATCH 0/7] guests: Use Python 3 for Ansible
The initial trigger for working on this was the fact that Fedora Rawhide no longer contains the python2-dnf package, breaking our update procedure; while looking into it, however, I ended up cleaning up some other stuff and dropping some code which is no longer needed with modern Ansible versions. Andrea Bolognani (7): guests: Store OS details as strings guests: Remove casts for OS details guests: Install Python 3 during bootstrap guests: Use ansible_python_interpreter everywhere guests: Don't dynamically look for Python binary guests: Drop package module bootstrap step guests: Drop SELinux file editing enablement guests/host_vars/libvirt-centos-7/main.yml | 8 ++++--- guests/host_vars/libvirt-debian-8/main.yml | 8 ++++--- guests/host_vars/libvirt-debian-9/main.yml | 8 ++++--- guests/host_vars/libvirt-debian-sid/main.yml | 8 ++++--- guests/host_vars/libvirt-fedora-28/main.yml | 8 ++++--- guests/host_vars/libvirt-fedora-29/main.yml | 8 ++++--- .../host_vars/libvirt-fedora-rawhide/main.yml | 8 ++++--- guests/host_vars/libvirt-freebsd-11/main.yml | 10 ++++---- guests/host_vars/libvirt-freebsd-12/main.yml | 10 ++++---- .../libvirt-freebsd-current/main.yml | 10 ++++---- guests/host_vars/libvirt-ubuntu-16/main.yml | 8 ++++--- guests/host_vars/libvirt-ubuntu-18/main.yml | 8 ++++--- guests/lcitool | 2 +- guests/playbooks/update/tasks/base.yml | 24 ------------------- guests/playbooks/update/tasks/bootstrap.yml | 21 +++++++++++++--- guests/playbooks/update/tasks/packages.yml | 4 ++-- guests/playbooks/update/tasks/paths.yml | 15 ------------ guests/playbooks/update/templates/bashrc.j2 | 2 +- 18 files changed, 82 insertions(+), 88 deletions(-) -- 2.19.2
When parsing something like os_version: 9 YAML will, somewhat reasonably, decide that os_version is a number rather than a string. This would be okay if not for the fact that in-development versions of operating systems are usually assigned a codename rather than a version number (Debian sid, Fedora Rawhide, FreeBSD -CURRENT) and so we will always need to convert the version to string before comparison to account for that. Quote all details about the OS to make sure they're stored as strings to begin with. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 6 +++--- guests/host_vars/libvirt-debian-8/main.yml | 6 +++--- guests/host_vars/libvirt-debian-9/main.yml | 6 +++--- guests/host_vars/libvirt-debian-sid/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-28/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-29/main.yml | 6 +++--- guests/host_vars/libvirt-fedora-rawhide/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-11/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-12/main.yml | 6 +++--- guests/host_vars/libvirt-freebsd-current/main.yml | 6 +++--- guests/host_vars/libvirt-ubuntu-16/main.yml | 6 +++--- guests/host_vars/libvirt-ubuntu-18/main.yml | 6 +++--- 12 files changed, 36 insertions(+), 36 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/libvirt-centos-7/main.yml index 8be54b6..4e3692f 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -14,6 +14,6 @@ projects: - osinfo-db-tools - virt-viewer -package_format: rpm -os_name: CentOS -os_version: 7 +package_format: 'rpm' +os_name: 'CentOS' +os_version: '7' diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/libvirt-debian-8/main.yml index fb37205..0ac5130 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -13,6 +13,6 @@ projects: - osinfo-db-tools - virt-viewer -package_format: deb -os_name: Debian -os_version: 8 +package_format: 'deb' +os_name: 'Debian' +os_version: '8' diff --git a/guests/host_vars/libvirt-debian-9/main.yml b/guests/host_vars/libvirt-debian-9/main.yml index 33476ad..4a1b197 100644 --- a/guests/host_vars/libvirt-debian-9/main.yml +++ b/guests/host_vars/libvirt-debian-9/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer -package_format: deb -os_name: Debian -os_version: 9 +package_format: 'deb' +os_name: 'Debian' +os_version: '9' diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_vars/libvirt-debian-sid/main.yml index f2594e7..911b491 100644 --- a/guests/host_vars/libvirt-debian-sid/main.yml +++ b/guests/host_vars/libvirt-debian-sid/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer -package_format: deb -os_name: Debian -os_version: Sid +package_format: 'deb' +os_name: 'Debian' +os_version: 'Sid' diff --git a/guests/host_vars/libvirt-fedora-28/main.yml b/guests/host_vars/libvirt-fedora-28/main.yml index 13555af..dc1b3f3 100644 --- a/guests/host_vars/libvirt-fedora-28/main.yml +++ b/guests/host_vars/libvirt-fedora-28/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer -package_format: rpm -os_name: Fedora -os_version: 28 +package_format: 'rpm' +os_name: 'Fedora' +os_version: '28' diff --git a/guests/host_vars/libvirt-fedora-29/main.yml b/guests/host_vars/libvirt-fedora-29/main.yml index b6140ed..aba292d 100644 --- a/guests/host_vars/libvirt-fedora-29/main.yml +++ b/guests/host_vars/libvirt-fedora-29/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer -package_format: rpm -os_name: Fedora -os_version: 29 +package_format: 'rpm' +os_name: 'Fedora' +os_version: '29' diff --git a/guests/host_vars/libvirt-fedora-rawhide/main.yml b/guests/host_vars/libvirt-fedora-rawhide/main.yml index 604f57f..d8d5dbc 100644 --- a/guests/host_vars/libvirt-fedora-rawhide/main.yml +++ b/guests/host_vars/libvirt-fedora-rawhide/main.yml @@ -27,6 +27,6 @@ projects: - virt-viewer+mingw32 - virt-viewer+mingw64 -package_format: rpm -os_name: Fedora -os_version: Rawhide +package_format: 'rpm' +os_name: 'Fedora' +os_version: 'Rawhide' diff --git a/guests/host_vars/libvirt-freebsd-11/main.yml b/guests/host_vars/libvirt-freebsd-11/main.yml index 887c9e6..ca32329 100644 --- a/guests/host_vars/libvirt-freebsd-11/main.yml +++ b/guests/host_vars/libvirt-freebsd-11/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer -package_format: pkg -os_name: FreeBSD -os_version: 11 +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: '11' diff --git a/guests/host_vars/libvirt-freebsd-12/main.yml b/guests/host_vars/libvirt-freebsd-12/main.yml index ac50271..e8d6a49 100644 --- a/guests/host_vars/libvirt-freebsd-12/main.yml +++ b/guests/host_vars/libvirt-freebsd-12/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer -package_format: pkg -os_name: FreeBSD -os_version: 12 +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: '12' diff --git a/guests/host_vars/libvirt-freebsd-current/main.yml b/guests/host_vars/libvirt-freebsd-current/main.yml index 1f3e911..3609ddb 100644 --- a/guests/host_vars/libvirt-freebsd-current/main.yml +++ b/guests/host_vars/libvirt-freebsd-current/main.yml @@ -17,6 +17,6 @@ projects: - virt-manager - virt-viewer -package_format: pkg -os_name: FreeBSD -os_version: Current +package_format: 'pkg' +os_name: 'FreeBSD' +os_version: 'Current' diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars/libvirt-ubuntu-16/main.yml index 6ec1df8..11cd095 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -15,6 +15,6 @@ projects: - osinfo-db-tools - virt-viewer -package_format: deb -os_name: Ubuntu -os_version: 16 +package_format: 'deb' +os_name: 'Ubuntu' +os_version: '16' diff --git a/guests/host_vars/libvirt-ubuntu-18/main.yml b/guests/host_vars/libvirt-ubuntu-18/main.yml index 61c7384..166d0e3 100644 --- a/guests/host_vars/libvirt-ubuntu-18/main.yml +++ b/guests/host_vars/libvirt-ubuntu-18/main.yml @@ -16,6 +16,6 @@ projects: - virt-manager - virt-viewer -package_format: deb -os_name: Ubuntu -os_version: 18 +package_format: 'deb' +os_name: 'Ubuntu' +os_version: '18' -- 2.19.2
We're always storing os_version as string now, so casting it before use has become unnecessary. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/lcitool | 2 +- guests/playbooks/update/tasks/packages.yml | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/guests/lcitool b/guests/lcitool index f63122d..759eff6 100755 --- a/guests/lcitool +++ b/guests/lcitool @@ -498,7 +498,7 @@ class Application: facts = self._inventory.get_facts(host) package_format = facts["package_format"] os_name = facts["os_name"] - os_version = str(facts["os_version"]) + os_version = facts["os_version"] os_full = os_name + os_version if package_format not in ["deb", "rpm"]: diff --git a/guests/playbooks/update/tasks/packages.yml b/guests/playbooks/update/tasks/packages.yml index 8cebb5f..7fdfc45 100644 --- a/guests/playbooks/update/tasks/packages.yml +++ b/guests/playbooks/update/tasks/packages.yml @@ -46,11 +46,11 @@ - name: '{{ project }}: Look up mappings (OS version)' set_fact: - temp: '{{ temp|combine({ item: mappings[item][os_name + os_version|string] }) }}' + temp: '{{ temp|combine({ item: mappings[item][os_name + os_version] }) }}' with_items: '{{ packages }}' when: - - mappings[item][os_name + os_version|string] is defined + - mappings[item][os_name + os_version] is defined - set_fact: flattened: [] -- 2.19.2
Almost all our target operating systems have a version of Python 3 which is recent enough (>= 3.5) to be used by Ansible available. In fact, almost all of them have it pre-installed, which makes installing Python 2 in addition to it just to use Ansible, when Ansible itself would be absolutely happy running on Python 3, quite silly. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/playbooks/update/tasks/bootstrap.yml | 21 ++++++++++++++++++--- 1 file changed, 18 insertions(+), 3 deletions(-) diff --git a/guests/playbooks/update/tasks/bootstrap.yml b/guests/playbooks/update/tasks/bootstrap.yml index d7abb86..f2b40e0 100644 --- a/guests/playbooks/update/tasks/bootstrap.yml +++ b/guests/playbooks/update/tasks/bootstrap.yml @@ -4,17 +4,32 @@ when: - package_format == 'pkg' +- set_fact: + python: python3 + +- set_fact: + python: python2 + when: + - os_name == 'CentOS' + - os_version == '7' + +- set_fact: + python: python + when: + - os_name == 'Debian' + - os_version == '8' + - name: Bootstrap Ansible - raw: yum install -y python2 + raw: 'yum install -y {{ python }}' when: - package_format == 'rpm' - name: Bootstrap Ansible - raw: apt-get install -y python + raw: 'apt-get install -y {{ python }}' when: - package_format == 'deb' - name: Bootstrap Ansible - raw: pkg install -y python2 + raw: 'pkg install -y {{ python }}' when: - package_format == 'pkg' -- 2.19.2
So far we've only needed to use ansible_python_interpreter for FreeBSD, where Ansible is unable to locate the Python binary itself; nowever, now that we want to use Python 3 instead of the default Python 2 almost everywhere, we need to make sure we always point Ansible to the appropriate Python binary. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 2 ++ guests/host_vars/libvirt-debian-8/main.yml | 2 ++ guests/host_vars/libvirt-debian-9/main.yml | 2 ++ guests/host_vars/libvirt-debian-sid/main.yml | 2 ++ guests/host_vars/libvirt-fedora-28/main.yml | 2 ++ guests/host_vars/libvirt-fedora-29/main.yml | 2 ++ guests/host_vars/libvirt-fedora-rawhide/main.yml | 2 ++ guests/host_vars/libvirt-freebsd-11/main.yml | 4 ++-- guests/host_vars/libvirt-freebsd-12/main.yml | 4 ++-- guests/host_vars/libvirt-freebsd-current/main.yml | 4 ++-- guests/host_vars/libvirt-ubuntu-16/main.yml | 2 ++ guests/host_vars/libvirt-ubuntu-18/main.yml | 2 ++ 12 files changed, 24 insertions(+), 6 deletions(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/libvirt-centos-7/main.yml index 4e3692f..da05935 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -17,3 +17,5 @@ projects: package_format: 'rpm' os_name: 'CentOS' os_version: '7' + +ansible_python_interpreter: /usr/bin/python2 diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/libvirt-debian-8/main.yml index 0ac5130..c5b82b3 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -16,3 +16,5 @@ projects: package_format: 'deb' os_name: 'Debian' os_version: '8' + +ansible_python_interpreter: /usr/bin/python2 diff --git a/guests/host_vars/libvirt-debian-9/main.yml b/guests/host_vars/libvirt-debian-9/main.yml index 4a1b197..ec7e6b4 100644 --- a/guests/host_vars/libvirt-debian-9/main.yml +++ b/guests/host_vars/libvirt-debian-9/main.yml @@ -19,3 +19,5 @@ projects: package_format: 'deb' os_name: 'Debian' os_version: '9' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-debian-sid/main.yml b/guests/host_vars/libvirt-debian-sid/main.yml index 911b491..1c7a29b 100644 --- a/guests/host_vars/libvirt-debian-sid/main.yml +++ b/guests/host_vars/libvirt-debian-sid/main.yml @@ -19,3 +19,5 @@ projects: package_format: 'deb' os_name: 'Debian' os_version: 'Sid' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-fedora-28/main.yml b/guests/host_vars/libvirt-fedora-28/main.yml index dc1b3f3..b12a670 100644 --- a/guests/host_vars/libvirt-fedora-28/main.yml +++ b/guests/host_vars/libvirt-fedora-28/main.yml @@ -20,3 +20,5 @@ projects: package_format: 'rpm' os_name: 'Fedora' os_version: '28' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-fedora-29/main.yml b/guests/host_vars/libvirt-fedora-29/main.yml index aba292d..bebf171 100644 --- a/guests/host_vars/libvirt-fedora-29/main.yml +++ b/guests/host_vars/libvirt-fedora-29/main.yml @@ -20,3 +20,5 @@ projects: package_format: 'rpm' os_name: 'Fedora' os_version: '29' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-fedora-rawhide/main.yml b/guests/host_vars/libvirt-fedora-rawhide/main.yml index d8d5dbc..ed0a3fa 100644 --- a/guests/host_vars/libvirt-fedora-rawhide/main.yml +++ b/guests/host_vars/libvirt-fedora-rawhide/main.yml @@ -30,3 +30,5 @@ projects: package_format: 'rpm' os_name: 'Fedora' os_version: 'Rawhide' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-freebsd-11/main.yml b/guests/host_vars/libvirt-freebsd-11/main.yml index ca32329..ed805c9 100644 --- a/guests/host_vars/libvirt-freebsd-11/main.yml +++ b/guests/host_vars/libvirt-freebsd-11/main.yml @@ -1,6 +1,4 @@ --- -ansible_python_interpreter: /usr/local/bin/python2 - projects: - libosinfo - libvirt @@ -20,3 +18,5 @@ projects: package_format: 'pkg' os_name: 'FreeBSD' os_version: '11' + +ansible_python_interpreter: /usr/local/bin/python3 diff --git a/guests/host_vars/libvirt-freebsd-12/main.yml b/guests/host_vars/libvirt-freebsd-12/main.yml index e8d6a49..8bbe158 100644 --- a/guests/host_vars/libvirt-freebsd-12/main.yml +++ b/guests/host_vars/libvirt-freebsd-12/main.yml @@ -1,6 +1,4 @@ --- -ansible_python_interpreter: /usr/local/bin/python2 - projects: - libosinfo - libvirt @@ -20,3 +18,5 @@ projects: package_format: 'pkg' os_name: 'FreeBSD' os_version: '12' + +ansible_python_interpreter: /usr/local/bin/python3 diff --git a/guests/host_vars/libvirt-freebsd-current/main.yml b/guests/host_vars/libvirt-freebsd-current/main.yml index 3609ddb..62498fd 100644 --- a/guests/host_vars/libvirt-freebsd-current/main.yml +++ b/guests/host_vars/libvirt-freebsd-current/main.yml @@ -1,6 +1,4 @@ --- -ansible_python_interpreter: /usr/local/bin/python2 - projects: - libosinfo - libvirt @@ -20,3 +18,5 @@ projects: package_format: 'pkg' os_name: 'FreeBSD' os_version: 'Current' + +ansible_python_interpreter: /usr/local/bin/python3 diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars/libvirt-ubuntu-16/main.yml index 11cd095..0e38128 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -18,3 +18,5 @@ projects: package_format: 'deb' os_name: 'Ubuntu' os_version: '16' + +ansible_python_interpreter: /usr/bin/python3 diff --git a/guests/host_vars/libvirt-ubuntu-18/main.yml b/guests/host_vars/libvirt-ubuntu-18/main.yml index 166d0e3..bb465e8 100644 --- a/guests/host_vars/libvirt-ubuntu-18/main.yml +++ b/guests/host_vars/libvirt-ubuntu-18/main.yml @@ -19,3 +19,5 @@ projects: package_format: 'deb' os_name: 'Ubuntu' os_version: '18' + +ansible_python_interpreter: /usr/bin/python3 -- 2.19.2
Now that we need to point Ansible to the Python binary explicitly and we prefer Python 3 to Python 2 while doing so, we might as well just re-use the path stored in the inventory instead of looking for it dynamically. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/playbooks/update/tasks/paths.yml | 15 --------------- guests/playbooks/update/templates/bashrc.j2 | 2 +- 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/guests/playbooks/update/tasks/paths.yml b/guests/playbooks/update/tasks/paths.yml index 00decc9..08717ba 100644 --- a/guests/playbooks/update/tasks/paths.yml +++ b/guests/playbooks/update/tasks/paths.yml @@ -12,8 +12,6 @@ - gmake - java - make - - python2 - - python3 - su - name: 'Look for files' @@ -54,16 +52,3 @@ make: '{{ commands["make"] }}' when: - make is undefined - -# Prefer python3, fall back to python2 -- name: 'Export paths' - set_fact: - python: '{{ commands["python3"] }}' - when: - - commands["python3"] != '' - -- name: 'Export paths' - set_fact: - python: '{{ commands["python2"] }}' - when: - - python is undefined diff --git a/guests/playbooks/update/templates/bashrc.j2 b/guests/playbooks/update/templates/bashrc.j2 index f0ab23e..1f39cf2 100644 --- a/guests/playbooks/update/templates/bashrc.j2 +++ b/guests/playbooks/update/templates/bashrc.j2 @@ -1,7 +1,7 @@ export PS1="[\u@\h \w]\$ " export MAKE="{{ make }}" -export PYTHON="{{ python }}" +export PYTHON="{{ ansible_python_interpreter }}" export MAKEFLAGS="-j{{ install_vcpus|int + 1 }}" -- 2.19.2
Modern Ansible versions can take care of this step automatically the first time the package module is used, which is nice because it means we don't have to worry about whether we're using Python 3 or Python 2 on the managed host. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/playbooks/update/tasks/base.yml | 16 ---------------- 1 file changed, 16 deletions(-) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml index cc16eb0..2899382 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -1,20 +1,4 @@ --- -- name: Bootstrap the package module - command: apt-get install -y python-apt - args: - creates: /usr/lib/python2*/*-packages/apt - warn: no - when: - - package_format == 'deb' - -- name: Bootstrap the package module - command: dnf install -y python2-dnf - args: - creates: /usr/lib*/python2*/*-packages/dnf - warn: no - when: - - os_name == 'Fedora' - - name: Permit file editing on SELinux-enabled systems package: name: libselinux-python -- 2.19.2
Modern Ansible versions do this automatically. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/playbooks/update/tasks/base.yml | 8 -------- 1 file changed, 8 deletions(-) diff --git a/guests/playbooks/update/tasks/base.yml b/guests/playbooks/update/tasks/base.yml index 2899382..5cffbeb 100644 --- a/guests/playbooks/update/tasks/base.yml +++ b/guests/playbooks/update/tasks/base.yml @@ -1,12 +1,4 @@ --- -- name: Permit file editing on SELinux-enabled systems - package: - name: libselinux-python - state: present - when: - - ( os_name == 'CentOS' or - os_name == 'Fedora' ) - - name: Enable jessie-backports repository template: src: '{{ playbook_base }}/templates/jessie-backports.sources.j2' -- 2.19.2
On Fri, Dec 21, 2018 at 09:36:20AM +0100, Andrea Bolognani wrote:
The initial trigger for working on this was the fact that Fedora Rawhide no longer contains the python2-dnf package, breaking our update procedure; while looking into it, however, I ended up cleaning up some other stuff and dropping some code which is no longer needed with modern Ansible versions.
Andrea Bolognani (7): guests: Store OS details as strings guests: Remove casts for OS details guests: Install Python 3 during bootstrap guests: Use ansible_python_interpreter everywhere guests: Don't dynamically look for Python binary guests: Drop package module bootstrap step guests: Drop SELinux file editing enablement
guests/host_vars/libvirt-centos-7/main.yml | 8 ++++--- guests/host_vars/libvirt-debian-8/main.yml | 8 ++++--- guests/host_vars/libvirt-debian-9/main.yml | 8 ++++--- guests/host_vars/libvirt-debian-sid/main.yml | 8 ++++--- guests/host_vars/libvirt-fedora-28/main.yml | 8 ++++--- guests/host_vars/libvirt-fedora-29/main.yml | 8 ++++--- .../host_vars/libvirt-fedora-rawhide/main.yml | 8 ++++--- guests/host_vars/libvirt-freebsd-11/main.yml | 10 ++++---- guests/host_vars/libvirt-freebsd-12/main.yml | 10 ++++---- .../libvirt-freebsd-current/main.yml | 10 ++++---- guests/host_vars/libvirt-ubuntu-16/main.yml | 8 ++++--- guests/host_vars/libvirt-ubuntu-18/main.yml | 8 ++++--- guests/lcitool | 2 +- guests/playbooks/update/tasks/base.yml | 24 ------------------- guests/playbooks/update/tasks/bootstrap.yml | 21 +++++++++++++--- guests/playbooks/update/tasks/packages.yml | 4 ++-- guests/playbooks/update/tasks/paths.yml | 15 ------------ guests/playbooks/update/templates/bashrc.j2 | 2 +- 18 files changed, 82 insertions(+), 88 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Andrea Bolognani -
Daniel P. Berrangé