[PATCH v2] qemu_agent: remove unused code

This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg01064.html Diff to v1: * I forgot to delete another part of the unused code which belonged together (noticed by Jano) This section of code was left unused ever since it was introduced ten years ago. I think we can safely remove it. Signed-off-by: Kristina Hanicova <khanicov@redhat.com> --- src/qemu/qemu_agent.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/src/qemu/qemu_agent.c b/src/qemu/qemu_agent.c index 5f421be6f6..f319b881fc 100644 --- a/src/qemu/qemu_agent.c +++ b/src/qemu/qemu_agent.c @@ -60,17 +60,6 @@ VIR_LOG_INIT("qemu.qemu_agent"); */ #define QEMU_AGENT_MAX_RESPONSE (10 * 1024 * 1024) -/* When you are the first to uncomment this, - * don't forget to uncomment the corresponding - * part in qemuAgentIOProcessEvent as well. - * -static struct { - const char *type; - void (*handler)(qemuAgent *agent, virJSONValue *data); -} eventHandlers[] = { -}; -*/ - typedef struct _qemuAgentMessage qemuAgentMessage; struct _qemuAgentMessage { char *txBuffer; @@ -237,17 +226,6 @@ qemuAgentIOProcessEvent(qemuAgent *agent, return -1; } -/* - for (i = 0; i < G_N_ELEMENTS(eventHandlers); i++) { - if (STREQ(eventHandlers[i].type, type)) { - virJSONValue *data = virJSONValueObjectGet(obj, "data"); - VIR_DEBUG("handle %s handler=%p data=%p", type, - eventHandlers[i].handler, data); - (eventHandlers[i].handler)(agent, data); - break; - } - } -*/ return 0; } -- 2.31.1

On a Wednesday in 2021, Kristina Hanicova wrote:
This is v2 of: https://listman.redhat.com/archives/libvir-list/2021-October/msg01064.html
Diff to v1: * I forgot to delete another part of the unused code which belonged together (noticed by Jano)
The comments about patch history belong either in the cover letter..
This section of code was left unused ever since it was introduced ten years ago. I think we can safely remove it.
Signed-off-by: Kristina Hanicova <khanicov@redhat.com> ---
.. or below this line. They are not interesting enough to become a part of the git history.
src/qemu/qemu_agent.c | 22 ---------------------- 1 file changed, 22 deletions(-)
Reviewed-by: Ján Tomko <jtomko@redhat.com> and pushed Jano
participants (2)
-
Ján Tomko
-
Kristina Hanicova